Bug Obtaining Crown of the Goblin King changes the Preference questL05Goblin from unstarted to finished

I run CS and do not have access to the Knob Goblin Treasury or the quest yet for some reason KolMafia thought I had the Treasury unlocked causing my scripts to crash. Upon further inspection..., I noticed the day before that I had a Crown of the Goblin King drop from Serendipity and mafia adjusted my "questL05Goblin" pref from unstarted to finished thus causing mafia to think I had the zones available.

Please see the session log portion below of this:

After Battle: Every melty freezeface has a tiny little mechanical core.
You acquire an item: clockwork key
After Battle: Hadolph smiles and winks at you.
You acquire an item: oversized ice molecule
After Battle: Looks like luck is on your side, you just tripped on this:
You acquire an item: Crown of the Goblin King
Preference questL05Goblin changed from unstarted to finished
After Battle: You gain 33 Strengthliness
After Battle: You gain 15 Mysteriousness
After Battle: You gain 15 Chutzpah

Thanks as always.

Huh.

We set the quest completed if you:

1) get the Crown, Glass Balls, or Codpiece from an adventure
2) get goblin water from an adventure and we were fighting the Aquagoblin
3) defeat Ricardo Belmont, Hammer Brother, or Gobot King

The last three are not the only Goblin King replacements that do not drop the crown; for example, the goblin king's shadow, in ASoL, goblodocus in Dinocore, and on and on.

MonsterDatabase has MONSTER_PATH_MAP which maps Quest Bosses to the path-specific monster name (or monsterId).
Updating that is part of What We Have To Do to support a new path.

Seems like we could have an inverse data structure which would map a monster id to the generic "Boss" monster.
QuestManager could have updateQuestData(responseText, monsterId) to handle quest boss progress and otherwise dispatch to updateQuestData(responseText, monsterName), which currently exists.

(We didn't used to have ready access to monsterId, but now we do.)

Given this, no need to update quest progress from ResultProcessor using boss drops.

I feel as though it's odd though the crown is an identifier for completion of the quest as it is tradeable for 200ish meat in the mall. The others being non-tradeable make complete sense to continue to use as identifiers.

Actually, I think I misread what you sent (sorry), so instead of just the item drop it will include the response text of the drop in correlation with the after-combat text of the monster id?

It's only acquisition of the item from a combat that is a trigger for quest completion.
It doesn't include the response text, but we have access to the monster. That is how goblin water works.

This could all be simplified a lot.

I'm working on this right now.

You rock, thanks so much Veracity

r28564