Feature shop.php support

Yeah. I was not addressing ASH support for specialized coinmasters, yet.
You are exactly correct. I'll look into this, by and by - and your previous bug reports.
Thanks!
 
ckb said:
One more point of information about coinmasters. Most of them are simple and take a single type of token that is an $item[]. Some have multiple tokens that are different $item[]s. Some have tokens that are not $item[]s and are reported as $item[none] but are hidden counters in Kol that Mafia tracks in properties (like Dimes and Quarters).

Parsing Mafia data, there are some coinmasters with $item[] tokens that do report as such and those should be fixed.

***** coinmasters with token==$item[none] that should be some other $item
Bat-Fabricator
Cosmic Ray's Bazaar
Fancy Dan the Cocktail Man
Your SpinMaster™ lathe


***** coinmasters with no [item] token (tracked by property)
Dimemaster
Quartersmaster
Sept-Ember Censer
The Swagger Shop
Mr. Store 2002
Game Shoppe
PirateRealm Fun-a-Log
Crimbo 2011
Click to expand...

Thanks for logging these! I was in the process of trying to automate spending my excess coinmaster tokens and ran into Fancy Dan's coinmaster .token being empty
 
Shiverwarp said:
Thanks for logging these! I was in the process of trying to automate spending my excess coinmaster tokens and ran into Fancy Dan's coinmaster .token being empty
Click to expand...
Fancy Dan doesn't have a token because it has multiple currencies.

ckb said:
One more point of information about coinmasters. Most of them are simple and take a single type of token that is an $item[]. Some have multiple tokens that are different $item[]s. Some have tokens that are not $item[]s and are reported as $item[none] but are hidden counters in Kol that Mafia tracks in properties (like Dimes and Quarters).
Click to expand...
This is accurate. A little more info:

A Coinmaster is a shop where you can trade N of a currency for M of an item.

Most coinmasters have a single currency.
We define string $coinmaster.token for such.
If it's a real item, item $coinmaster.item is not $item[none].
If it's a pseudo item, string $coinmaster.property is how we track it.

Old coinmasters were not implemented using shop.php. I see 18 of those.
New coinmasters are in shop.php and use "ROWs". I see 78 of those.

Some coinmasters - such as Mr. Store - have multiple currencies.
Those coinmasters do not have a "token" or "item" or "property".
The mapping from item to required currency is implemented in code.
(New shop.php coinmasters can define their sales in coinmasters.txt, rather than requiring code.)

There are two ASH functions for seeing what an item sells for:

int sell_price($coinmaster, $item)

If the coinmaster has a "token", easy: that's how many tokens it requires.
If it doesn't have a "token" - it has multiple currencies - you'll get an integer, but what is the cost?

Gausie's new function
int[item] sell_cost($coinmaster, $item)
SHOULD let you see the currency - but I notice it has an issue. More later.

Lastly, NPC stores - shop.php or not - can trade multiple different currencies for an item.
Mostly, we have this implemented as "concoctions".
I see 22 of them that use shop.php.

My shop.php work allows us to implement anything that uses shop.php - single or multiple currency, real or pseudo item, coinmaster-like or concoction-like - as a new-style coinmaster.
(Gausie's function works correctly with those coinmasters.)

ckb said:
Parsing Mafia data, there are some coinmasters with $item[] tokens that do report as such and those should be fixed.

***** coinmasters with token==$item[none] that should be some other $item
Bat-Fabricator
Click to expand...
multiple currencies:
Code: 
782    batman_cave    bat-oomerang    high-grade metal (3)
783    batman_cave    bat-jute    high-tensile-strength fibers (3)
784    batman_cave    bat-o-mite    high-grade explosives (3)

ckb said:
Cosmic Ray's Bazaar
Click to expand...
multiple currencies:
Code: 
1088    exploathing    space shield    rare Meat isotope (25)
1089    exploathing    signal jammer    rare Meat isotope (25)
1090    exploathing    digital key    white pixel (30)
1091    exploathing    low-pressure oxygen tank    rare Meat isotope (10)
1092    exploathing    Wand of Nagamar    rare Meat isotope (30)
1093    exploathing    Boris's key    fat loot token
1094    exploathing    Jarlsberg's key    fat loot token
1095    exploathing    Sneaky Pete's key    fat loot token
1096    exploathing    rare Meat isotope    1000 Meat
1097    exploathing    antique accordion    rare Meat isotope (10)
1098    exploathing    space chowder    rare Meat isotope (5)
1099    exploathing    space wine    rare Meat isotope (5)
1100    exploathing    lucky-ish pill    rare Meat isotope (20)

ckb said:
Fancy Dan the Cocktail Man
Click to expand...
multiple currencies:
Code: 
1289    olivers    Charleston Choo-Choo    drink chit
1290    olivers    Velvet Veil    drink chit
1291    olivers    Marltini    drink chit
1292    olivers    Strong, Silent Type    milk cap
1293    olivers    Mysterious Stranger    milk cap
1294    olivers    Champagne Shimmy    milk cap

ckb said:
Your SpinMaster™ lathe
Click to expand...
multiple currencies:
Code: 
1160    lathe    birch battery    flimsy hardwood scraps
1161    lathe    ebony epee    flimsy hardwood scraps
1162    lathe    weeping willow wand    flimsy hardwood scraps
1163    lathe    beechwood blowgun    flimsy hardwood scraps
1164    lathe    maple magnet    flimsy hardwood scraps
1165    lathe    hemlock helm    Dreadsylvanian hemlock
1166    lathe    balsam barrel    sweaty balsam
1167    lathe    redwood rain stick    ancient redwood
1168    lathe    purpleheart "pants"    purpleheart logs
1169    lathe    wormwood wedding ring    wormwood stick
1170    lathe    drippy diadem    Dripwood slab

ckb said:
***** coinmasters with no [item] token (tracked by property)
Dimemaster
Quartersmaster
Sept-Ember Censer
The Swagger Shop
Mr. Store 2002
Game Shoppe
PirateRealm Fun-a-Log
Crimbo 2011
Click to expand...
Yes. As mentioned, they have $coinmaster.token and $coinmaster.property

Also, as mentioned, sell_price and sell_cost will tell you how many "currency" things cost - and the latter will tell what what the costs are, for new-style coinmasters - but, perhaps it could use work for old-style coinmasters with multiple currencies.

Code: 
> ash sell_price($coinmaster[Fancy Dan the Cocktail Man], $item[Marltini])

Returned: 1

> ash sell_cost($coinmaster[Fancy Dan the Cocktail Man], $item[Marltini])

Returned: aggregate int [item]
none => 1

It's be nice if the last one was drink chit => 1
 
Just one report as I'm working with this:

$coinmaster[Cheer-o-Vend 3000] is incorrectly seen as inaccessible with is_accessible. And also attempting to buy with buy. Clicking the [exchange] link on crystalline cheer brings you to the coinmaster shop. So I assume it should be accessible as long as you have any amount of crystalline cheer in inventory?
 
Last edited:
I see this:

Code: 
  public static String accessible() {
    int cheer = CHEER.getCount(KoLConstants.inventory);
    if (cheer == 0) {
      return "You need some crystalline cheer.";
    }
    return null;
  }

But I also see this:

Code: 
  public String accessible() {
    // Returns an error reason or null
    if ("Removed".equals(this.getRootZone())) {
      return "Zone is no longer accessible";
    }

    return this.accessible.get();
  }

and this:

Code: 
Crimbo17    Removed    Christmas 2017

I think the "Removed" check should only be done if the Coinmaster does not have a custom accessible method...
 
Yeah, that's an easy enough fix.

Code: 
> inv crystalline cheer

> ash is_accessible($coinmaster[Cheer-o-Vend 3000])

Returned: false

> ash inaccessible_reason($coinmaster[Cheer-o-Vend 3000])

Returned: You need some crystalline cheer.

> pull 1 crystalline cheer

Pulling items from storage...
Requests complete.

> ash is_accessible($coinmaster[Cheer-o-Vend 3000])

Returned: true
 
Veracity said:
Yeah, that's an easy enough fix.
Click to expand...
Awesome! The accessibility is working great, but there is an issue with sell_price/sells_item for Cheer-o-Vend 3000 with relation to the Journals of Mime Science. They are only able to be purchased if you were active during that Crimbo.

So for me, the shop does not have any of the journals, but the commands believe that it has the one related to my current class.

Code: 
> ash sell_price($coinmaster[Cheer-o-Vend 3000], $item[The Journal of Mime Science Vol. 3])

Returned: 1000

> ash sells_item($coinmaster[Cheer-o-Vend 3000], $item[The Journal of Mime Science Vol. 3])

Returned: true

But my actual shop looks like: 1742241338320.png
 
I have a fix for sell_cost for coinmasters that don't use new-style ShopRows.
Some examples:

Ordinary coinmaster with a single currency.

Code: 
> ash sell_cost($coinmaster[The Terrified Eagle Inn], $item[silver Dreadsylvanian flask])

Returned: aggregate int [item]
Freddy Kruegerand => 100

Coinmasters with multiple currencies.

Code: 
> ash sell_cost($coinmaster[Fancy Dan the Cocktail Man], $item[Marltini])
Returned: aggregate int [item]
drink chit => 1

> ash sell_cost($coinmaster[Fancy Dan the Cocktail Man], $item[Mysterious Stranger])
Returned: aggregate int [item]
milk cap => 1

> ash sell_cost($coinmaster[Cosmic Ray's Bazaar], $item[space shield])
Returned: aggregate int [item]
rare Meat isotope => 25

> ash sell_cost($coinmaster[Cosmic Ray's Bazaar], $item[digital key])
Returned: aggregate int [item]
white pixel => 30

> ash sell_cost($coinmaster[Cosmic Ray's Bazaar], $item[Boris's key])
Returned: aggregate int [item]
fat loot token => 1

> ash sell_cost($coinmaster[Your Spinmaster™ lathe], $item[birch battery])
Returned: aggregate int [item]
flimsy hardwood scraps => 1

> ash sell_cost($coinmaster[Your Spinmaster™ lathe], $item[wormwood wedding ring])
Returned: aggregate int [item]
wormwood stick => 1

Maybe I'll write some tests. In any case, I'll submit this, by and by.
 
Could a function be made (or exposed) such that we could get the coinmasters that accept a token item?

Currently we can search for this with the single token coinmasters by checking their token proxy record field, but for the multiple token masters who do not have this field populated, there isn't an easy way to connect them.

I believe the only way to do this right now would be to iterate through every coinmaster with sell_cost and check every coinmaster item against each coinmaster to see whether any of them return an int [item] that contains the token we'd like to check against
 
You must log in or register to reply here.
Back
Top