Bug December 2024 changes in KoL break lots of stuff

Malibu Stacey

Active member
There have been changes to the HTML KoL returns which are causing lots of things to not parse correctly e.g.

Choice adventures have blank Encounter titles.
Code:
[1467930] An Overgrown Shrine (Northeast)
Preference lastEncounter changed from Kingdom-Wide Ballot to
Encounter:
Submitting option 4 for choice 785
Encounter:
Preference _candyCaneSwordOvergrownShrine changed from false to true
Clan VIP room contents aren't being parsed so stuff like
Code:
    if (!get_property("_floundryItemCreated").to_boolean()) {
      create(1, $item[carpe]);
    }
Fails with
Code:
Your current clan does not have a Floundry.

Likely lots of other issues too but these are the ones I have noticed thus far. Many scripts are failing due to knock on effects from these issues.

This is likely a side effect of the new Crimbo content being pushed to live.
 
Looking at the VIP room HTML
Code:
<center><table  width=95%  cellspacing=0 cellpadding=0><tr><td style="background-color: blue" align=center ><b style="color: white">Clan VIP Lounge (Ground Floor)</b></td></tr>

It looks like the addition of style="color: white" to the bold tag is causing the issue as the regex in ClanLoungeRequest.java is
Code:
<table.*?<b>Clan VIP Lounge \\(Ground Floor\\)</b>.*?<center><b>(?:<a.*?>)?(.*?)(?:</a>)?</b>.*?</center>(<table.*?</table>
 
Adding ".*?" after the bold fixes that regex, like this:
Code:
<table.*?<b.*?>Clan VIP Lounge \\(Ground Floor\\)</b>.*?<center><b>(?:<a.*?>)?(.*?)(?:</a>)?</b>.*?</center>(<table.*?</table>
 
Spoke too soon. Furniture (stuff inside your housing that shows when you click the magnifying glass) isn't being recognised.
Code:
> ash get_campground()

Returned: aggregate int [item]
meat golem => 1
Dramatic™ range => 1
Queue Du Coq cocktailcrafting kit => 1
chef-in-the-box => 1
bartender-in-the-box => 1
pagoda plans => 1
Discount Telescope Warehouse gift certificate => 3
packet of winter seeds => 0
ice harvest => 0
snow fort => 1
potted tea tree => 1
haunted doghouse => 1
Witchess Set => 1
Source terminal => 1
cold medicine cabinet => 1
Giant black monolith => 1
A Guide to Burning Leaves => 1

1734311994343.png

Noticed as the maid's rollover adventures aren't listed when I do modtrace adventures and the return value of
numeric_modifier("Adventures") is 8 less than normally expected.
 
More PRs going up, keep the reports coming :)

Also with how I've implemented it (straight hardcoding the current HTML) it'll have to change again once whatever color-changing thing goes in, but that should be easier to search for (i.e. search for `<b style="color: white"`).
 
It appears the GUI for user mall stores has broken

When using this: 1734403855789.png

It will show the store as being empty here:1734403883393.png

Even when it is not empty
 

Attachments

  • 1734403784383.png
    1734403784383.png
    3.3 KB · Views: 0
When visiting the crimbo factory manually, this shows up in the graphical CLI.

--------------------
Crimbo Factory unknown lucky moai statuette Spirit of Easter (50) ROW1538
--------------------
--------------------
Crimbo Factory unknown egg gun Spirit of Easter (200) ROW1537
--------------------
--------------------
Crimbo Factory unknown lucky army helmet Spirit of St. Patrick's Day (350) ROW1540
--------------------
--------------------
Crimbo Factory unknown Secrets of the Master Egg Hunters Spirit of Easter (500) ROW1533
--------------------
--------------------
Crimbo Factory unknown How to Lose Friends and Attract Snakes Spirit of St. Patrick's Day (500) ROW1534
--------------------
--------------------
Crimbo Factory unknown Covert Ops for Kids Spirit of Veteran's Day (500) ROW1535
--------------------
That's new content, and unrelated to the bug discussed in this thread.
 
Looks like parsing and/or showing of new events is also broken. Used to get a list of PvP/kmail related events when I logged on, and it's still present outside of mafia.
 
Back
Top