OK, I’ve completed and tested a patch that does what I described. It hews closely to the existing code, adding just a few lines. In fact, most of the patch is removing unnecessary bits of modifiers.txt.
When I created this thread, I didn’t realize that a lot of familiars already had the “Underwater Familiar” modifier explicitly applied. Now that I know KoLmafia is basically already doing this, albeit with hardcoding, I think it is safe to submit a patch along these lines.
I’m not sure I follow your logic. When I give the Modifier Maximizer parameters, I am expecting it to satisfy them. I am not expecting it to specifically equip items to do so.
Underwater Familiar is a Boolean modifier. It represents whether I can adventure in underwater environments with my...
Familiars that can breathe underwater do not affect the “Underwater Familiar” Boolean modifier. This means that maximizing with “+sea” or “Underwater Familiar” causes items like “das boot” to be equipped when it isn’t necessary, which comes with serious penalties. It also means that the Modifier...
Yes, this was fixed since I encountered the issue. I believe it is because the item behaves normally as of July 2019: it wasn’t marked public before that point, and that screwed up a lot of things. Fitting, I suppose.
I remember opening a request for tracking PVP-decrementing ages ago. Glad to see it being implemented by someone.
I can sympathize with auto-formatting woes. It’s one of the reasons I use Vim: it is fairly easy to make it use existing formats over defaults if they exist. Still, it’s always...
I have a script that tries to acquire a burnt stick for decorating the Getaway Campsite tent. It is designed to fail if $item[burnt stick].retrieve_item() returns false (among other unrelated conditions).
When I run it early in an ascension, KoLmafia tries to acquire a burnt stick by spending a...