Recent content by Saklad5

  1. S

    Feature - Implemented Underwater familiars don’t affect the Underwater Familiar modifier

    OK, I’ve completed and tested a patch that does what I described. It hews closely to the existing code, adding just a few lines. In fact, most of the patch is removing unnecessary bits of modifiers.txt.
  2. S

    Feature - Implemented Underwater familiars don’t affect the Underwater Familiar modifier

    When I created this thread, I didn’t realize that a lot of familiars already had the “Underwater Familiar” modifier explicitly applied. Now that I know KoLmafia is basically already doing this, albeit with hardcoding, I think it is safe to submit a patch along these lines.
  3. S

    Feature - Implemented Underwater familiars don’t affect the Underwater Familiar modifier

    I’m not sure I follow your logic. When I give the Modifier Maximizer parameters, I am expecting it to satisfy them. I am not expecting it to specifically equip items to do so. Underwater Familiar is a Boolean modifier. It represents whether I can adventure in underwater environments with my...
  4. S

    Feature - Implemented Underwater familiars don’t affect the Underwater Familiar modifier

    Sorry, I meant “not difficult for me to do if everyone agrees it is a good idea”. On that note, do you see any issues with implementing this that way?
  5. S

    Feature - Implemented Underwater familiars don’t affect the Underwater Familiar modifier

    Familiars that can breathe underwater do not affect the “Underwater Familiar” Boolean modifier. This means that maximizing with “+sea” or “Underwater Familiar” causes items like “das boot” to be equipped when it isn’t necessary, which comes with serious penalties. It also means that the Modifier...
  6. S

    Bug - Fixed Data loss when writing maps to files

    Yes, this was fixed since I encountered the issue. I believe it is because the item behaves normally as of July 2019: it wasn’t marked public before that point, and that screwed up a lot of things. Fitting, I suppose.
  7. S

    Feature - Implemented Working on a somewhat large change for tracking attributes and quality of effects

    I remember opening a request for tracking PVP-decrementing ages ago. Glad to see it being implemented by someone. I can sympathize with auto-formatting woes. It’s one of the reasons I use Vim: it is fairly easy to make it use existing formats over defaults if they exist. Still, it’s always...
  8. S

    New Content - Implemented August 2019 IotM - Getaway Campsite

    Yes, they are. I'm not sure whether that's applied before or after things like Ol' Scratch's salad fork, though.
  9. S

    New Content - Implemented [Patch] Update bounty.txt to reflect beanbat change

    This is an extremely simple patch, merely changing the number of bean-shaped rocks needed to complete the beanbat bounty from 35 to 12.
  10. S

    Bug - Fixed Infinite Crafting Loop with Firewood

    I think this bug has since been reintroduced in r19743 or thereabouts.
  11. S

    New Content - Implemented Spring 2020 Challenge Path - Path of the Plumber

    Wait, does that mean you can overdrink?
  12. S

    Bug - Fixed Infinite Crafting Loop with Firewood

    I just skimmed through coinmasters.txt, and I believe you are correct.
  13. S

    Bug - Fixed Infinite Crafting Loop with Firewood

    I have a script that tries to acquire a burnt stick for decorating the Getaway Campsite tent. It is designed to fail if $item[burnt stick].retrieve_item() returns false (among other unrelated conditions). When I run it early in an ascension, KoLmafia tries to acquire a burnt stick by spending a...
Top