Recent content by Obeliks

It's not that simple, because the bricks can even be funkslang, so the check needs to happen outside the "free kill" block anyway. I will prepare a PR. EDIT: https://github.com/kolmafia/kolmafia/pull/2267

When you use a shadow brick on a monster that is not insta-killalble, that still counts towards the 13/day usage limit (cp wiki). However, KoLmafia (deliberately) does not count it in this case. I'm a bit unsure how to fix this: The usage is tracked in DailyLimits manager, and incremented in...

I believe the culprit is the `forceContinue()` call in JavascriptRuntime's checkInterrupted. This gets called after every AshStub (aka RuntimeLibrary function) invocation, including `abort`. It made it's way into the code in this change: cb6c048 (note that forceContinue was not called before)...

Sorry for digging up this old thread. I found the commit that restricts GOAWAY handling to retryOnTimeout requests, so it's probably related to some coincidence that causes one character to hit the 1000th request on a retriable request and the other not. Although I'm not surprised that the...

Any updates on this? Was there a fix committed? I have two characters who run the identical script with the identical build of kolmafia (in separate processes with separate home folders), one regularly hits the GOAWAY, but the other one doesn't.

Thanks!

Thanks for your detailed tests. I tried your test code, and indeed that doesn't trigger it for me as well. The problem happens if ChoiceManager gets loaded before ChoiceAdventures. If you modify the test to call the following: String result = ChoiceManager.specialChoiceDecision1(546...

I see. Thanks for trying this, I think this might be the relevant difference.

Ok, strange. This is the first thing you ran after starting KoLmafia --CLI, right? I'm running this on Ubuntu 22.04 with openjdk 17.0.5. $ java --version openjdk 17.0.5 2022-10-18 OpenJDK Runtime Environment (build 17.0.5+8-Ubuntu-2ubuntu122.04) OpenJDK 64-Bit Server VM (build...

I finally managed to try and reproduce this with vanilla KoLmafia (KoLmafia-27068) It can be triggered by running this ASH commands in the CLI: set_property("choiceAdventure546", "13") visit_url("/place.php?whichplace=town&action=town_vampout") run_choice(-1) > ash...

I believe that the problem I've outlined is legit, though. Compare this StackOverflow answer regarding a similar (more simplified) setup: https://stackoverflow.com/a/6416481/1479482 Since this seems to be clearly specified in the CLS, I don't think the concrete JVM implementation can be at...

That's a very good question :D This is quite puzzling... Perhaps it's related to the specific JVM used? Without the change where I move the Choice class to a top-level class, I cannot use the VampOut options due to the error I mentioned above. I don't think I have any changes in my fork that...

Also, a bit late, but thanks @Veracity for your detailed explanation!

Thanks, I appreciate that! I'll be happy to contribute whenever the opportunity arises.

I created a PR for this, any feedback would be greatly appreciated: https://github.com/kolmafia/kolmafia/pull/1135