Recent content by MCroft

  1. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    First, that's a great model and it tests things like I expect. This is my draft test to show that it selects an offhand and none. If we adjust "effective" to have allow the non-preferred type (melee/ranged) if the "effective" type is an empty list, this is how I'd want to test it. Honestly...
  2. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    This is actually in Kolmafia and KoL Nothing + offhand is valid for KoL, as long as the offhand isn't a weapon. It's not looking at them as accessories. It's reusing the slot to save on memory. Accessories are pulling the first three items from SLOT ACCESSORY1. That's not broken (that I know...
  3. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I am down for that discussion. I don't think we've seen any complaints about this with WotSF, but we might not, since WotSF doesn't allow offhand or weapons to be equipped at all. But let's dig into my 20250217 log (from this previous post (full logs and inventory listed above)). Here's the...
  4. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I didn't find where it should take care of that case, but it looks like in the past evaluator.java was supposed to be aware of it. It may be that it sometimes is and there's an edge case. I'm looking to see if there's an obvious place to say "offhand value=0 if weapon=null", but no one should...
  5. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    Also, it looks like we try to take care of that very case (Evaluator.java, line 143+) // Equipment slots, that aren't the primary slot of any item type, // that are repurposed here (rather than making the array bigger). // Watches have to be handled specially because only one can be // used -...
  6. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    If it tests and succeeds, great, good test for a viable condition and one less thing to futz with. If it tests and fails, also great. Thanks for keeping at this.
  7. MCroft

    Feature - Implemented Prefs file backup/restore Draft PR

    It would be great if you could get that, although it sounds like @fronobulax has at least one 'almost always' case. timein can be called by itself, and it might be possible to see if different threads timing in caused it, like a relay script and a gCLI script. I think threaded chat may be also...
  8. MCroft

    Feature - Implemented Prefs file backup/restore Draft PR

    I don't think the backup PR inside KoLmafia is the best approach. It doesn't address the underlying problem, which if we can solve it would mean all of the backup style solutions would be unnecessary. @fronobulax, is there anything anyone could do to help you with the concurrency branch testing?
  9. MCroft

    Feature - Implemented Prefs file backup/restore Draft PR

    Chatter has heated up on this again over on an unofficial channel and I wanted to capture some of the items from it. It's honestly a lot of the same questions: What are the causes, what can we do about it, are there advantages to using a database instead of a text file, etc. I don't know if...
  10. MCroft

    Multitool - An implementation and feature discussion.

    I thought that got changed when we went to git/GitHub and the revision number stopped being a serially updated integer that we could get from SF. This is the before diff of gausie's change "Set revision when building jar with gradle (#17) ... BufferedReader reader =...
  11. MCroft

    Multitool - An implementation and feature discussion.

    run works on v50. thank you!
  12. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    If I were to guess, I'd wonder if it wasn't failing because for the weapon slot, it only had stolen accordion and none and the accordion is two-handed. It finds a better combo with none and august scepter, but since you can't equip an off-hand without a weapon, both fail. That's where I'd...
  13. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    OK, so it stopped for me. I'm in HCAT Standard. Just starting this run, so I started from nekkid. attached debug and session logs. Here's the console from Autoscend with 2 Dump info. My complete inv.
  14. MCroft

    Multitool - An implementation and feature discussion.

    Exactly. The downside is that some users regularly empty out ~/Downloads. (Not me. My oldest files in ~/Downloads can now vote.). Some commercial maintenance apps recommend it. But if we're installing something, the default location is either in /Applications or ~/Applications if we want to...
Back
Top