Okay, yeah, it looks like a SIGABRT because there's a JVM signal handler that caught the SIGSEGV so it could log it.
The crash being in CVDisplayLink::calculateNextWakeUpTime() within runIOThread() definitely looks like some object got freed in a separate thread while it was still being used...
28732, huh? That rules out our recent dependency upgrade (which was in r28733).
This nominally looks like a use-after-free because of how weird that address looks (and the line stating that it's not in any region, coupled with the fact that it's way too many bitflips away from a valid memory...
We should just clear the error state via StaticEntity.setContinuationState() if we fall back to trying the replica deck (and succeed in doing so).
(All of scripting, to a first approximation.)
r28729. My test script that runs print(modifier_eval("-23963")) now succeeds. (I then extended it to check all of the other numbers from -32768 to +32768.)
Note that you'll also want to setDepth() on any pulls or other operations that internally invoke git fetch.
Are you referring to the preference `gitShowCommitMessages`? That only prints commits since the last fetch. And even then, if a repo had a thousand commits since the last fetch, we still...
I had merged the other PR, and then noticed that it generated build failures on macOS. I sent https://github.com/kolmafia/kolmafia/pull/3034 to revert back to the broken state, but I'd also approve an appropriate fix-forward.
I suspect that's more of an oversight, in that it also works in the other direction: if I temporarily disable autoSatisfyWithCoinmasters, Mafia still uses coinmasters despite the preference saying not to. However, if I force refreshConcoctions() (as with `refresh concoctions`), that clears the...
That PR has been merged onto the main branch, but hasn't yet made it to the Release branch. Track https://github.com/loathers/TourGuide/pull/258 if you want to see when the fix will be available.
@gausie asserts that this was being caused by Mafia code (possibly related to the daily deeds manager, if I had to guess?), and that this should be fixed by r28615.
That said, I also see an explicit reference in https://github.com/loathers/TourGuide/blob/main/Source/relay/TourGuide/Sets/Skills.ash#L209 which may be more relevant.