Recent content by heeheehee

  1. H

    Bug macOS 14+ GUI crash caused by deprecated Carbon menu calls

    Okay, yeah, it looks like a SIGABRT because there's a JVM signal handler that caught the SIGSEGV so it could log it. The crash being in CVDisplayLink::calculateNextWakeUpTime() within runIOThread() definitely looks like some object got freed in a separate thread while it was still being used...
  2. H

    Bug macOS 14+ GUI crash caused by deprecated Carbon menu calls

    28732, huh? That rules out our recent dependency upgrade (which was in r28733). This nominally looks like a use-after-free because of how weird that address looks (and the line stating that it's not in any region, coupled with the fact that it's way too many bitflips away from a valid memory...
  3. H

    Bug - Fixed Using the replica Deck of Every Card via CLI causes an error state, even if successful

    We should just clear the error state via StaticEntity.setContinuationState() if we fall back to trying the replica deck (and succeed in doing so). (All of scripting, to a first approximation.)
  4. H

    Bug - Fixed modifier_eval() failing with some negative numbers

    r28729. My test script that runs print(modifier_eval("-23963")) now succeeds. (I then extended it to check all of the other numbers from -32768 to +32768.)
  5. H

    Bug - Fixed modifier_eval() failing with some negative numbers

    https://github.com/kolmafia/kolmafia/pull/3137
  6. H

    Bug - Fixed modifier_eval() failing with some negative numbers

    That seems fixable if we just avoid the small integer optimization for these special cases.
  7. H

    Feature - Implemented Something to automatically prune git history

    Note that you'll also want to setDepth() on any pulls or other operations that internally invoke git fetch. Are you referring to the preference `gitShowCommitMessages`? That only prints commits since the last fetch. And even then, if a repo had a thousand commits since the last fetch, we still...
  8. H

    Bug - Fixed Small flaw in animated Hellion image

    I think https://github.com/kolmafia/kolmafia/pull/3091 should do the trick.
  9. H

    Bug - Fixed Build process no longer cleans out old jar files

    I had merged the other PR, and then noticed that it generated build failures on macOS. I sent https://github.com/kolmafia/kolmafia/pull/3034 to revert back to the broken state, but I'd also approve an appropriate fix-forward.
  10. H

    Bug - Fixed Build process no longer cleans out old jar files

    https://github.com/kolmafia/kolmafia/pull/3032 does the trick for me.
  11. H

    Bug autoSatisfyWithCoinmasters cannot be set by scripts

    I suspect that's more of an oversight, in that it also works in the other direction: if I temporarily disable autoSatisfyWithCoinmasters, Mafia still uses coinmasters despite the preference saying not to. However, if I force refreshConcoctions() (as with `refresh concoctions`), that clears the...
  12. H

    Issue with constant messages wrt deprecated preference

    That PR has been merged onto the main branch, but hasn't yet made it to the Release branch. Track https://github.com/loathers/TourGuide/pull/258 if you want to see when the fix will be available.
  13. H

    Issue with constant messages wrt deprecated preference

    Well, I sent them https://github.com/loathers/TourGuide/pull/256 so we'll see when that gets merged.
  14. H

    Issue with constant messages wrt deprecated preference

    @gausie asserts that this was being caused by Mafia code (possibly related to the daily deeds manager, if I had to guess?), and that this should be fixed by r28615.
  15. H

    Issue with constant messages wrt deprecated preference

    That said, I also see an explicit reference in https://github.com/loathers/TourGuide/blob/main/Source/relay/TourGuide/Sets/Skills.ash#L209 which may be more relevant.
Back
Top