Here is the two patches for making ctrl+tab work in chat:
http://frikod.se/~capitol/0039-some-class-layout-restructuring-in-order-to-follow-t.patch
http://frikod.se/~capitol/0040-making-crtl-tab-work-for-switching-tab.patch
and github links...
And here is what i think is the last patch in this series of improvements:
http://frikod.se/~capitol/0001-added-ctrl-number-as-a-shortcut-for-switching-tabs-i.patch
It's also a usability patch, and it adds crtl+<number> as shortcuts to the tabs, so that you can more easily change tabs when you...
Here is another patch-set for improving the chat:
http://frikod.se/~capitol/0035-got-the-chat-history-working-again-basic-functionall.patch
http://frikod.se/~capitol/0036-guard-against-an-ArrayIndexOutOfBoundsException-that.patch...
The reason i included the final patch was that I suspected that final was added for speed reasons, since there was a number of private methods marked as final and thought it might be enlightening to bring the subject up for discussion.
I'm working on some more usability improvements for the...
I posted a gigantic (and somewhat unusable) patch a couple of days ago with some java 1.5 upgrades, and got pretty good feedback on it.
I have reworked the changes into one patch per type of change, so that it's easy to cherry-pick what you like and disregard what you don't.
The patches...
Here is an improved patch that will apply with patch -p1 : http://frikod.se/~capitol/0003-improved-the-way-that-the-tabbed-chat-recieves-focus.patch
The patch contains the unit test, as the test of the functionality belongs together with the implementation of the functionality and should be...
I'll try to produce svn compatible patches, will need to do some reading on the subject :)
Regarding the size of the downloadable, it should stay the same, if you clean the build directory before you build the jar (if you have run the ant test target). The test target depends on the compilation...
broken up and submitted as two features:
http://kolmafia.us/showthread.php?10522-infrastructure-to-support-unit-tests
http://kolmafia.us/showthread.php?10523-improve-focus-handling-in-tabbed-chat
Hi
I have now done some real development instead of just cosmetic changes to the code
Here is a patch that improves the way that focus is handled on the tabbed chat, it moves focus to the input box every time that the window gains focus.
This makes it possible to tab to the chat and start...
Hi
In order to be able to write automatic unit and regression tests it's needed to have an ant target and some utility jar's.
I'm also submitting another feature that contains a unittest, but I broke out the actual unit-test stuff into it's own patch.
link to commit...
Sounds like a good idea to break the patch into two different ones, I'll do that and add them to the tracker.
Regarding svn, it's such a horrible step backwards in functionality to start using svn instead of git, so I won't do that, but what i can do is to start using a git-svn clone of your...
Hi
I have now done some real development instead of just cosmetic changes to the code ;)
Here is a patch that improves the way that focus is handled on the tabbed chat, it moves focus to the input box every time that the window gains focus.
This makes it possible to tab to the chat and start...