PVP improvements:
1) We have default "win" and "lose" messages that you can set that will be submitted when a PVP fight is initiated. These are in the defaultFlowerLossMessage and defaultFlowerWinMessage settings. If you don't have them set, we randomly pick one of four defaults for each kind of message.
- I don't see a way to configure those text messages in Preferences. It would be nice to be able to do that.
KoL itself lets you specify default win/loss message, which are only used to prefill the text boxes on the Fight! page. Those are obviously stored somewhere, but are not visible in KoL's option pages
- KoL should let use see/configure those message on the Options page (bug report submitted)
- KoL should include those messages in api.php so we can read them at login and set our own settings from what the player has set on the server (bug report submitted)
2) The various PVP CLI commands could stand a little improvement.
"steal <mission> [<stance>]" invokes PvpManager.executePvpRequest( <mission>, <stance> ).
<mission> can be "flowers", "fame", or "loot".
<stance> can be "muscle", "mysticality", "moxie", or "ballyhoo"
"flowers" or "swagger" invokes PvpManager.executePvpRequest( "flowers", 0 ).
A stance of "0" means choose a stance based on your (currently) highest buffed stat
Either of those will use all of your remaining PVP fights on the chosen mission with the chosen stance.
- I would like the option to NOT use all of my remaining fights. I'd like to be able to do 5 fights for flowers and then issue another command to do 5 fights for loot, say. (A hypothetical example; since flowers are a mini-game this season, I want all flowers all the time, but you get the idea. I have certainly been attacked for fame and for loot, on occasion, so other people have different priorities). I think PvpManager.executePvpRequest( mission, stance ) should become PvpManager.executePvpRequest( fights, mission, stance ), with fights = 0 defaulting to "all remaining", as now.
I think the "flowers" command is fine as it is, calling PvpManager.executePvpRequest( 0, "flowers", 0 )
I would like the "steal" command to become
steal <fights> <mission> [<stance>]
and call PvpManager.executePvpRequest( fights, mission, stance )
- Now that we have a beforePVPScript which can change your buffs on the fly, selecting a default stance one time before the fight loop is probably not correct. We probably want something like:
Code:
while fighting
run beforePVPScript
if needToPickStance
stance = pickStance
fight!
3) PeeVPeeRequest.registerRequest() should do a little better at recognizing fights. I find the following less than satisfying:
peevpee.php?action=fight&place=fight&pwd&ranked=1&who=&stance=1&attacktype=flowers&winmessage=&losemessage=
You acquire an item: pretty flower
You gain a little swagger
peevpee.php?action=fight&place=fight&pwd&ranked=1&who=&stance=1&attacktype=flowers&winmessage=&losemessage=
You gain a little swagger
The first is a win. The second is a loss.
- It should pull out the mission and stance - and opponent, if any, and "ranked" (1 = normal random, 2 = harder random) - and log something other than the raw URL in the session log.
- In the CLI, we log
You won the PvP fight, 5 to 2!
or
You lost the PvP fight, 2 to 5!
You lost 80 Muscle
You lost 70 Mysticality
You lost 60 Moxie
Those things should also go into the session log, in my opinion.
- For amusement, I'd like to see who I attacked in the CLI/session log message. I'd like to see:
You attacked Bale and won the PvP fight, 5 to 2!
You attacked erTEST1 and lost the PvP fight, 0 to 7!
(Well, I wouldn't necessarily like to see those exact results, but you get the idea.)
