New Content - Implemented The return of formerly extinct monsters

M

Magus_Prime

Well-known member
It's not a problem with KoLmafia per se but, in the past, messages like that have pointed to a typo in the data record for the monster.
 
lostcalpolydude

lostcalpolydude

Developer
Staff member
That's possible in some cases, but in this case the script claims that zombie2.gif doesn't match zombie2.gif for some reason.
 
Bale

Bale

Minion
"For some reason" intrigued me so I decided to look into this BatBrain error. I found the cause here:
Code: 
            matcher imgm = create_matcher("adventureimages\\/([^ ]+\\.gif)",page);
            if (imgm.find() && image_to_monster(imgm.group(1)) != m) vprint("Warning: image '"+imgm.group(1)+"' does not match monster '"+m+"' ("+m.image+").","#8585FF",3);



That causes an error because these two things don't match:

Code: 
[COLOR="#808000"]> ash $monster[white zombie].image.print()[/COLOR]

zombie2.gif
Returned: void

[COLOR="#808000"]> ash image_to_monster("zombie2.gif").print()[/COLOR]

zombie zmobie
Returned: void

My personal opinion is that BatBrain shouldn't assume all monster images are unique. Alternately, should KoLmafia provide a way of telling if an image can disambiguate to more than one monster?
 
Veracity

Veracity

Developer
Staff member
After finishing all my faxing and ascending to get all the mushroom guys:

You have exhaustively researched 1662 creatures

That includes the blazing bat, which I still have in my chateau painting but which is still not copyable.

In a recent podcast, Jick apparently said that Riff had posted a list of 9 monsters that need to be made copyable - and possibly have special end-of-fight actions removed - which all had factoids. So, we are still waiting for that.

I think I'll send a friendly message to Jick reminding him of the following monsters:

7-Foot Dwarf (Moiling)
7-Foot Dwarf (Royale)
wire-crossin' elf
Mob Penguin Smasher
Mob Penguin Smith
Mob Penguin Supervisor
rock snake
blazing bat
snakefire in the grass

I'd love to see all of those in the fax network so we can finally get the monster stats and close this thread.
 
Veracity

Veracity

Developer
Staff member
Bale said:
My personal opinion is that BatBrain shouldn't assume all monster images are unique. Alternately, should KoLmafia provide a way of telling if an image can disambiguate to more than one monster?
Click to expand...
Each monster has a list of images accessible via proxy field.
Internally, we have a map of images to monster which goes from the first listed image to the first monster with that image.
That is the data source for image_to_monster( string).

I suppose we could change our internal map to map ALL of the images for every monster into a list of all the monsters that have that image - and the first one would be as before.

We could then make

boolean [monster] image_to_monsters( string)

to get all the monsters. If the map has only one key, the image is unique.
 
Veracity

Veracity

Developer
Staff member
Bumping from page 23 of Bug Reports. I think we may as well close this, since I think it unlikely that Jick et. al. will ever bring back any more old monsters, but maybe there is something in this mega-thread that needs attention. I'll look at it later. Maybe.
 
You must log in or register to reply here.
Top