Feature "Your father's diary has been read"

[correct_username]

I'm requesting to disable auto-read function of macguffin diary if you have dance card counter set and it's >-1. 3-turn vacation with forged identification documents is a good time to use one of dance cards and after auto-reading diary dance card may be wasted (we'll all be flat may override rotting matilda adventure in ballroom).

Using 1 dance card...
Finished using 1 dance card.

[370] Muscle Vacation
Encounter: Covert Operations
You acquire an item: your father's MacGuffin diary
Your father's diary has been read.

[373] Haunted Ballroom
Encounter: We'll All Be Flat

---
NightBird

 

[roippi]

The chance that at least one person doesn't notice that no autoread occurs and subsequently burns through 50 adventures on the poop deck before posting a vitriolic bug report is approximately 100%.

 

[Fluxxdog]

There are other was to override the dance card, such as Bad Moon and holiday monsters, etc. Should these cases be considered as well? If so, would it make more sense to simply disable dance card use in these scenarios since more control can be exerted over the card?

 

[Theraze]

You also missed nemesis monsters.

 

[roippi]

So, what we could do: create a per-ascension preference to track if the diary has been read, then move reading the diary to KoLAdventure.validate(). It would read the diary if you (have the diary) && (haven't read it yet) && ((zone != ballroom) || (dance card counter == -1)).

 

[Theraze]

Wouldn't the zone always equal the vacation? As in, couldn't we just check for dance card counter not existing, since on a 4 turn counter with 3 turns (getting the diary), there's only one potential flop-turn?

 

[roippi]

I'm not sure what you're saying. validate() happens before adventuring.

 

[Theraze]

Ah... so that would move it from automatically reading it whenever they get it, to reading whenever it's possible and guaranteed not to muck up a dance card counter? Sounds good... would end up with an extra server hit once for people who have passed that point, but avoids the inevitable complaints from actually removing the auto-read.