Bug - Fixed You challenged null and lost the PvP fight, 0 to 0!

Rinn

Rinn

Developer
It seems there's a case where a pvp fight fails but mafia isn't aware that a pvp fight isn't used. I'm out of pvp fights for today so I won't be able to try and repro it with any debug settings enabled.
Code: 
    [COLOR=olive]> steal loot ballyhoo[/COLOR]

Use all     remaining PVP attacks to steal loot via ballyhoo
Attack 1 of 60
You     gain a little swagger
You challenged ParASTrA and lost the PvP fight, 0     to 7!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 82 Strongness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 66 Magicalness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 73     Sarcasm
Attack 2 of 60
You acquire an item: pretty flower
You     gain a little swagger
You challenged pixie on a stick and won the PvP     fight, 5 to 2!
Attack 3 of 60
You gain a little swagger
You     challenged Evil Bovine and lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 85 Strongness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 69     Wizardliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 78 Smarm
Attack     4 of 60
You acquire an item: six pack of Mountain Stream
You gain a     little swagger
You challenged gOObers and won the PvP fight, 5 to 2!
Attack     5 of 60
You gain a little swagger
You challenged ckB1 and lost the     PvP fight, 1 to 6!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 80     Strengthliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 66     Wizardliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 72 Cheek
Attack     6 of 60
You acquire an item: wooden stakes
You gain a little swagger
You     challenged Yahweh and won the PvP fight, 6 to 1!
Attack 7 of 60
You     gain a little swagger
You challenged Highbulp and lost the PvP fight, 0     to 7!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 83 Strengthliness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 68 Magicalness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 70     Roguishness
Attack 8 of 60
You challenged null and lost the PvP     fight, 0 to 0!
Attack 9 of 60
You acquire an item: enormous hoop     earring
You gain a little swagger
You challenged stewyr19 and won     the PvP fight, 5 to 2!
Attack 10 of 60
You acquire an item: spider     web
You gain a little swagger
You challenged Shorgorroth and won the     PvP fight, 5 to 2!
Attack 11 of 60
You gain a little swagger
You     challenged Radixius and lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 87 Strengthliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 63     Wizardliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 69 Cheek
Attack     12 of 60
You acquire an item: hopping socks
You gain a little swagger
You     challenged shakeyjake2 and won the PvP fight, 6 to 1!
Attack 13 of 60
You     gain a little swagger
You challenged TownWench and lost the PvP fight,     3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 88 Muscleboundness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 65 Mysteriousness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 73     Chutzpah
Attack 14 of 60
You acquire an item: magical ice cubes
You     gain a little swagger
You challenged Edda and won the PvP fight, 4 to 3!
Attack     15 of 60
You gain a little swagger
You challenged Very Flash and     lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR] lost     78 Fortitude
[COLOR=#2cae33]Epicgamer[/COLOR] lost 69     Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 75 Chutzpah
Attack     16 of 60
You acquire an item: blue-frosted astral cupcake
You gain a     little swagger
You challenged TehWeen and won the PvP fight, 5 to 2!
Attack     17 of 60
You challenged null and lost the PvP fight, 0 to 0!
Attack     18 of 60
You challenged null and lost the PvP fight, 0 to 0!
Attack     19 of 60
You acquire an item: hot plate
You gain a little swagger
You     challenged Agone and won the PvP fight, 6 to 1!
Attack 20 of 60
You     gain a little swagger
You challenged Tanivan and lost the PvP fight, 2     to 5!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 85 Strongness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 65 Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 75     Sarcasm
Attack 21 of 60
You acquire an item: sea tangelo
You gain     a little swagger
You challenged Tatter and won the PvP fight, 4 to 3!
Attack     22 of 60
You acquire an item: lime-and-chile-flavored chewing gum
You     gain a little swagger
You challenged Samurai Boy and won the PvP fight,     5 to 2!
Attack 23 of 60
You gain a little swagger
You challenged     Hawkthorn and lost the PvP fight, 2 to 5!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 83 Beefiness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 67     Wizardliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 75 Chutzpah
Attack     24 of 60
You gain a little swagger
You challenged Zanchvegas and     lost the PvP fight, 2 to 5!
[COLOR=#2cae33]Epicgamer[/COLOR] lost     88 Strongness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 67     Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 73 Sarcasm
Attack     25 of 60
You challenged null and lost the PvP fight, 0 to 0!
Attack     26 of 60
You gain a little swagger
You challenged Theoklymenus and     lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR] lost     85 Beefiness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 65     Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 74 Cheek
Attack     27 of 60
You acquire an item: rum and cola
You gain a little swagger
You     challenged Poncho the Sane and won the PvP fight, 4 to 3!
Attack 28 of     60
You gain a little swagger
You challenged ViewtifulJosh and lost     the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 86     Strongness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 64 Wizardliness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 71 Chutzpah
Attack 29 of 60
You acquire an item: milky potion
You     gain a little swagger
You challenged Metal Chicken and won the PvP     fight, 5 to 2!
Attack 30 of 60
You challenged null and lost the PvP     fight, 0 to 0!
Attack 31 of 60
You challenged null and lost the PvP     fight, 0 to 0!
Attack 32 of 60
You acquire an item: pretty flower
You     gain a little swagger
You challenged danteand and won the PvP fight, 5     to 2!
Attack 33 of 60
You gain a little swagger
You challenged     ujiklop and lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 84 Beefiness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 68     Magicalness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 70 Sarcasm
Attack     34 of 60
You acquire an item: sand dollar
You gain a little swagger
You     challenged Gnomam and won the PvP fight, 5 to 2!
Attack 35 of 60
You     gain a little swagger
You challenged Zanchvegas and lost the PvP fight,     2 to 5!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 88 Beefiness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 71 Mysteriousness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 68     Chutzpah
Attack 36 of 60
You acquire an item: leotarrrd
You gain     a little swagger
You challenged Turtlini and won the PvP fight, 4 to 3!
Attack     37 of 60
You gain a little swagger
You challenged ckB1 and lost the     PvP fight, 2 to 5!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 85     Muscleboundness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 69     Magicalness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 70 Sarcasm
Attack     38 of 60
You acquire an item: wad of dough
You gain a little swagger
You     challenged JamesPotter and won the PvP fight, 4 to 3!
Attack 39 of 60
You     acquire an item: saucepan
You gain a little swagger
You challenged     Thano and won the PvP fight, 5 to 2!
Attack 40 of 60
You gain a     little swagger
You challenged Random Thief and lost the PvP fight, 0 to     7!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 87 Strengthliness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 67 Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 74     Sarcasm
Attack 41 of 60
You acquire an item: 334 scroll
You gain     a little swagger
You challenged SpeakLowMrWeill and won the PvP fight,     4 to 3!
Attack 42 of 60
You gain a little swagger
You challenged     me259259 and lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 79 Strengthliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 66     Wizardliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 73 Cheek
Attack     43 of 60
You challenged null and lost the PvP fight, 0 to 0!
Attack     44 of 60
You acquire an item: pretty flower
You gain a little swagger
You     challenged derpherp and won the PvP fight, 5 to 2!
Attack 45 of 60
You     challenged null and lost the PvP fight, 0 to 0!
Attack 46 of 60
You     acquire an item: pretty flower
You gain a little swagger
You     challenged MetalShogun and won the PvP fight, 4 to 3!
Attack 47 of 60
You     challenged null and lost the PvP fight, 0 to 0!
Attack 48 of 60
You     gain a little swagger
You challenged Mrdaimion and lost the PvP fight,     3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 83 Strongness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 61 Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 77     Chutzpah
Attack 49 of 60
You acquire an item: popsicle stick
You     gain a little swagger
You challenged jojo198o and won the PvP fight, 5     to 2!
Attack 50 of 60
You challenged null and lost the PvP fight, 0     to 0!
Attack 51 of 60
You gain a little swagger
You challenged     Bale Frend and lost the PvP fight, 1 to 6!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 83 Beefiness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 66     Enchantedness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 68 Chutzpah
Attack     52 of 60
You challenged null and lost the PvP fight, 0 to 0!
Attack     53 of 60
You acquire an item: tiny plastic filthy hippy jewelry maker
You     gain a little swagger
You challenged Godsinjustice and won the PvP     fight, 4 to 3!
Attack 54 of 60
You gain a little swagger
You     challenged Jo_Anonomous and lost the PvP fight, 2 to 5!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 81 Muscleboundness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 66     Mysteriousness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 69 Chutzpah
Attack     55 of 60
You acquire an item: savoy truffle
You gain a little swagger
You     challenged craigjones and won the PvP fight, 5 to 2!
Attack 56 of 60
You     acquire an item: spring
You gain a little swagger
You challenged Sir     Arthur of Dent and won the PvP fight, 4 to 3!
Attack 57 of 60
You     gain a little swagger
You challenged thegerb and lost the PvP fight, 3     to 4!
[COLOR=#2cae33]Epicgamer[/COLOR] lost 86 Beefiness
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 66 Mysteriousness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 73     Cheek
Attack 58 of 60
You gain a little swagger
You challenged     darTHdUD and lost the PvP fight, 3 to 4!
[COLOR=#2cae33]Epicgamer[/COLOR]     lost 83 Muscleboundness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 70     Mysteriousness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 79 Smarm
Attack     59 of 60
You acquire an item: groovy prism necklace
You gain a     little swagger
You challenged tlguiry and won the PvP fight, 4 to 3!
Attack     60 of 60
You gain a little swagger
You challenged mitchelljpaul and     lost the PvP fight, 2 to 5!
[COLOR=#2cae33]Epicgamer[/COLOR] lost     82 Strengthliness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 60     Mysteriousness
[COLOR=#2cae33]Epicgamer[/COLOR] lost 80     Roguishness
You have 11 attacks remaining.
 
Veracity

Veracity

Developer
Staff member
You attack for loot, eh?

After many hundreds of fites, I have never, ever seen this issue. I'll let you diagnose and fix it. Fortunately, you are a dev and have commit access.

Good luck!
 
lostcalpolydude

lostcalpolydude

Developer
Staff member
I wonder if KoL had you fight a clanmate and then realized you can't fight clanmates. It should just need more page parsing to recognize (intentionally targeting people you can't fight should be a good way to get the message, or just specifically match for the message about losing the fight, not sure which is better at the moment). I can get to it later today if no one beats me to it.
 
Veracity

Veracity

Developer
Staff member
Ha. I fight clanmates all the time. I guess that is a per-clan thing, which might be why I have never seen it.
 
Rinn

Rinn

Developer
Yeah I'll look at it if I get a chance and lost doesn't, still it's better for everything to be logged I think.

And yeah I pvp for items, I've already gotten quite a few expensive items out of it which just fill my cold black heart with joy.
 
lostcalpolydude

lostcalpolydude

Developer
Staff member
11276 should cover all cases where a message with null could be logged (fixed compact mode, grabbed all the invalid target messages). Stat loss can't be parsed in compact mode without an api hit, which I don't think is worth doing.

I think if you get an invalid target when you tell mafia to use a bunch of pvp fights, it will count that as one of the fights you wanted to use. I don't feel like the code needed to handle that case is worth it, when a trivial amount of user interaction (tell mafia to use more fights) fixes it and you can avoid it by not being in a clan that doesn't let you attack fellow clanmates.
 
You must log in or register to reply here.
Top