We should take a habit of using Preferences.resetToDefault( String ), rather than manually setting every preference to a set value, in ValhallaManager.resetPerAscensionCounters()
I did the transition myself, and am ready to submit a patch, but while doing it, I found four discrepancies. Two of which I'm just not sure about, and two that are actual bugs.
Not sure:
I did the transition myself, and am ready to submit a patch, but while doing it, I found four discrepancies. Two of which I'm just not sure about, and two that are actual bugs.
Not sure:
- nextParanormalActivity has a default value of 0, but is reset to 1 on ascension. Is that correct?
- We're not resetting noobDeferredPoints on ascension. Is that... correct?
- backupCameraMode has a default of <blank>, but should have meat as a default.
- bondDR is mistakenly referred to as bondDA half of the time.
Referred to as bondDA:
In ValhallaManager:
Java:Preferences.setBoolean( "bondDA", false );
Java:Preferences.setBoolean( "bondDA", bondDR );
Referred to as bondDR:
In defaults.txt:
Code:user bondDR false
In modifiers.txt:
Code:Path License to Adventure (...), Damage Reduction: [10*pref(bondDR)], (...)