Chef_Rannos
Member
That could be a lot of server hits. I would rather closet some meat here or there just to make sure I have some stashed away in case I need it.
Universal Recovery Script
- Thread starter Bale
- Start date
What could be a lot of hits? The wrapper would add two hits to whatever else was being done - one to closet meat and one to un-closet meat. Unless you intend to run the wrapped function "a lot" I'm not sure how you count "a lot" of hits so it would be useful to know what I am mis-counting.
Theraze
Active member
If you use a UR wrapper, and mafia runs UR 2 times per adventure (possibly more, depending on if you've put it into your BBS and ABS due to item usage fights), that's potentially 12 (2 (hp/mp) * 3 (BBS, automatic, ABS) * 2 (closet/uncloset)) extra server hits per adventure. Bad.
StDoodle
Minion
Code:
int spendable_meat() {
if (get_property("scriptsIgnoreThisMeat").to_int() > 0)
return my_meat() - get_property("scriptsIgnoreThisMeat").to_int();
return my_meat();
}Replace all calls to my_meat() with spendable_meat() in any script you want to play nice with this setting, and then set the custom mafia property "scriptsIgnoreThisMeat" to the value of meat that scripts should pretend you don't have?
(Note: code is top-of-my-head at work, can probably be simplified)
Theraze
Active member
I'd probably have the first check look for get_property != "" and then always do my_meat - to_int. Since you're getting the same warning regardless...
Basically, you're either doing my_meat() - 0 or my_meat() - sITM. Could actually make it a bit more efficient by defining sITM as an int and only checking it once... something like
Code:
int spendable_meat() {
int sITM = get_property("scriptsIgnoreThisMeat").to_int();
return my_meat() - sITM;
}
Bale
Minion
You're all making a good argument for why meat conservation is a worthwhile feature to add to UR so that all the closeting can be avoided. However it would be troublesome, fiddly and annoying to implement and it I won't actually use the feature... so I won't do it. You're gonna have to keep using the closeting workaround and KoL will have to deal with the extra server hits. I regret that, but it would be too darn boring to fix.
Chef_Rannos
Member
I just noticed I could use Lure Minion to get rid of junk brains...and I didn't run into a meat problem getting minions so I'm not too worried about the save meat setting.
However, I am now getting this message if I have Universal Recovery enabled:
This happens before it will let me adventure, in HC Zombie Master. I have my MP set to not recover, exited mafia and went back in and still get the same message (using build 11440 and latest recovery).
However, I am now getting this message if I have Universal Recovery enabled:
Code:
Did not fully restore MP for some reason.This happens before it will let me adventure, in HC Zombie Master. I have my MP set to not recover, exited mafia and went back in and still get the same message (using build 11440 and latest recovery).
Bale
Minion
Sorry about that bug. It was because of a round-off error. I've fixed the problem in the latest version.
Changelog:
version 3.10.4 August 29, 2012
Starting with this version, Lure Minion will be used to trade in junk brains. It will always conserve enough brains to fill the rest of your stomach today plus half of what you'll need for tomorrow. (If you have a stomach of 20 and you've eaten 16 brains, it will retain 14 brains for your personal use.) It starts by trading in lower quality brains first.
Universal recovery v 3.10.4 released!
Changelog:
version 3.10.4 August 29, 2012
- Make good use of extremely powerful healing items like Camp Scout Pup Tents
- Fix for not always recognizing that restoration is set to not recover.
- Zombiecore: Use "Lure Minion" to trade brains for horde
Download Universal Recovery v3.10.4 here: View attachment 6825
(Universal_Recovery.ash goes in the /scripts folder)
(Universal_Recovery.ash goes in the /scripts folder)
Starting with this version, Lure Minion will be used to trade in junk brains. It will always conserve enough brains to fill the rest of your stomach today plus half of what you'll need for tomorrow. (If you have a stomach of 20 and you've eaten 16 brains, it will retain 14 brains for your personal use.) It starts by trading in lower quality brains first.
Chef_Rannos
Member
That sounds like a great idea to me. I think that'll be enough to make sure you can fill your stomach each day. Thanks for the awesome script!
Bale
Minion
Universal recovery v 3.10.5 released!
Changelog:
version 3.10.5 August 30, 2012
- Fixed a bug that would sometimes keep the script from checking your inventory when you are under 20% health.
Download Universal Recovery v3.10.5 here: View attachment 6827
(Universal_Recovery.ash goes in the /scripts folder)
(Universal_Recovery.ash goes in the /scripts folder)