Bug - Fixed Tracking meat progress for the nuns quest doesn't work

[Ensiferum]

As in the title - observed in r14772, confirmed by chat.

 

[Veracity]

From yesterday's session log:

[668] The Themthar Hills
Encounter: dirty thieving brigand
Round 0: Veracity wins initiative!
Round 1: Veracity casts SAUCESTORM!
Round 2: dirty thieving brigand takes 48 damage.
Round 2: dirty thieving brigand takes 48 damage.
Round 2: "Ah yes!" Psychic Grrl says, "This meat was right where I predicted it would be!" She then hands you some meat.
Round 2: You gain 11 Meat.
Round 2: Hobo Grrl climbs up and sits on your shoulder, and hands you some Meat. Huh, where did he find that?
You gain 74 Meat.
You lose 13 hit points
Round 2: Veracity casts SAUCESTORM!
Round 3: dirty thieving brigand takes 48 damage.
Round 3: dirty thieving brigand takes 96 damage.
Round 3: "Ah yes!" Psychic Grrl says, "This meat was right where I predicted it would be!" She then hands you some meat.
Round 3: You gain 7 Meat.
Round 3: Veracity wins the fight!
Your familiar gains a pound: Hobo Grrl, the 18 lb. Hobo Monkey
After Battle: Psychic Grrl surveys the scene from your back, and gains 1 Experience.
After Battle: Hobo Grrl sits on your fallen opponent's body, blows a smoke ring, and winks at you.
The nuns take 7,062 Meat; 7,062 recovered, 92,938 left to recover.
You gain 17 Strengthliness
You gain 14 Wizardliness
You gain 37 Sarcasm
You recover 7 drops of Rain

What does your session log say?

 

[Veracity]

(That is not an irrelevant question. Something that changed between yesterday and today is HTMLCleaner, which we currently use to parse the results of fight.php, which is where we process Meat gains & the nunnery.)

 

[roippi]

That's rather unfortunate if simply upgrading HTMLCleaner affected its parsing behavior. Sigh.

We'll need a session log and HTML dump of a nun fight, please.

 

[Ensiferum]

Log from yesterday in r14760:

[448] The Themthar Hills
Encounter: dirty thieving brigand
Round 0: Hadean loses initiative!
You lose 17 hit points
Round 1: Hadean uses the Rain-Doh indigo cup and uses the Rain-Doh black box!
You gain 99 hit points
You acquire an item: Rain-Doh box full of monster
Round 2: Hadean casts LIGHTNING STRIKE!
Round 3: Hadean wins the fight!
The nuns take 7,628 Meat; 7,628 recovered, 92,372 left to recover.
You gain 19 Strengthliness
You gain 47 Enchantedness
You gain 18 Sarcasm
You gain 6 Soulsauce
You swallow 50 dB of Thunder

Log from today in r14772:

[456] The Themthar Hills
Encounter: dirty thieving brigand
Round 0: Hadean loses initiative!
You lose 24 hit points
Round 1: Hadean casts MAKE IT RAIN!
You lose 23 hit points
Round 2: Hadean uses the Rain-Doh indigo cup and uses the Rain-Doh black box!
You gain 87 hit points
You acquire an item: Rain-Doh box full of monster
Round 3: Hadean casts LIGHTNING STRIKE!
You gain 7 Soulsauce

At a first glance, the 14772 logs have no "Player wins the fight!" logged anywhere in them.

 

[roippi]

Yuck. There's a lot of stuff broken. Looking into it, might just roll back if I can't figure out a quick solution.

 

[Veracity]

Good catch.

Yesterday:

[203323] The Castle in the Clouds in the Sky (Top Floor)
Encounter: Raver Giant
Round 0: Tebryn wins initiative!
Round 1: Tebryn executes a macro!
Round 1: Tebryn casts SAUCEGEYSER!
Round 2: Raver Giant takes 1577 damage.
Round 2: Stubert climbs up and sits on your shoulder, and hands you some Meat. Huh, where did he find that?
You gain 81 Meat.
Round 2: Wingwang shakes loose a considerable quantity of spice. You conjure up a canister and collect it.
You acquire an item: spices
Round 2: Tebryn wins the fight!
After Battle: Stubert sits on your fallen opponent's body, blows a smoke ring, and winks at you.
You gain 914 Meat
After Battle: Wingwang spins and whirls in the breeze, like a spicy little dust devil.
You gain 7 Muscleboundness
You gain 30 Mysteriousness
You gain 5 Chutzpah

Today:

[203593] The Castle in the Clouds in the Sky (Top Floor)
Encounter: Punk Rock Giant
Round 0: Tebryn wins initiative!
Round 1: Tebryn attacks!
Round 2: Punk Rock Giant takes 2371 damage.
You acquire an item: spices
You gain 297 Meat

Today's HTML of the round with the spices:

<html><head><script language=Javascript><!--if (parent.frames.length == 0) location.href="game.php";top.charpane.location.href="charpane.php";//--></script><script language=Javascript src="http://images.kingdomofloathing.com/scripts/keybinds.min.2.js"></script><script language=Javascript src="http://images.kingdomofloathing.com/scripts/window.20111231.js"></script><script language="javascript">function chatFocus(){if(top.chatpane.document.chatform.graf) top.chatpane.document.chatform.graf.focus();}if (typeof defaultBind != 'undefined') { defaultBind(47, 2, chatFocus); defaultBind(190, 2, chatFocus);defaultBind(191, 2, chatFocus); defaultBind(47, 8, chatFocus);defaultBind(190, 8, chatFocus); defaultBind(191, 8, chatFocus); }</script><script language=Javascript src="http://images.kingdomofloathing.com/scripts/jquery-1.3.1.min.js"></script><script type="text/javascript">jQuery(function ($) {$(document).ready(function() {throb_out();});});function throb_out() {jQuery(function ($) {$('.throbtext').fadeTo(Math.random()*400,.5);})setTimeout(throb_in,400+Math.random()*200);}function throb_in() {jQuery(function ($) {$('.throbtext').fadeTo(Math.random()*400,Math.min(.95,Math.random()+.5));setTimeout(throb_out,400+Math.random()*200);//setTimeout(throb_out,1200);})}</script><script language="javascript" src="http://images.kingdomofloathing.com/scripts/core.js"></script><script>var onturn = 2;function newpic(pic, name, width, height){var h = height || 100;var w = width || 100;mpic = getObj('monpic');mnam = getObj('monname');mpic.src=pic;mpic.width=w;mpic.height=h;mnam.innerHTML=name;}var waking = false;function killforms(sub) {sub.disabled = true;var is = document.getElementsByTagName("input");for (i=0; i < is.length; i++) {if (is[i].getAttribute('type') == 'submit') { is[i].disabled = true; }}if (waking) { clearTimeout(waking); }waking = setTimeout(function () {for (i=0; i < is.length; i++) {if (is[i].getAttribute('type') == 'submit') { is[i].disabled = false; }}}, 3000);sub.form.submit();return true;}</script><link rel="stylesheet" type="text/css" href="http://images.kingdomofloathing.com/styles.20130904.css"><style type='text/css'>.faded {zoom: 1;filter: alpha(opacity=35);opacity: 0.35;}</style></head><body><center><table  width=95%  cellspacing=0 cellpadding=0><tr><td style="color: white;" align=center bgcolor=blue><b>Combat!</b></td></tr><tr><td style="padding: 5px; border: 1px solid blue;"><center><table><tr><td><center><table><tr><td><div id=monsterpic style='position: relative;'>	<img id='monpic' src="http://images.kingdomofloathing.com/adventureimages/giant_punk.gif" width=100 height=100></div></td><td valign=center>You're fighting <span id='monname'>a Punk Rock Giant</span></td></tr></table><br><p>You hold one end of the Coily™ with both hands and hurl the other end at your opponent, dealing 2371 damage.  Sproing!<b><font color=blue> WHAM! POW! SMACK! WHAMMO! SOCKO! BARF! WHACK! BOOF! BONK! BARF!</font></b><!--familiarmessage--><center><table><tr><td align=center valign=center><img src="http://images.kingdomofloathing.com/itemimages/t_spiceghost.gif" width=30 height=30></td><td valign=center>Wingwang shakes loose a considerable quantity of spice.  You conjure up a canister and collect it.<center><table class="item" style="float: none" rel="id=8&s=1&q=0&d=1&g=0&t=1&n=1&m=0&p=0&u=u"><tr><td><img src="http://images.kingdomofloathing.com/itemimages/spice.gif" alt="spices" title="spices" class=hand onClick='descitem(266103456)'></td><td valign=center class=effect>You acquire an item: <b>spices</b></td></tr></table></center></td></tr></table></center><p><center>You win the fight!<!--WINWINWIN--><p><!--familiarmessage--><center><table><tr><td align=center valign=center><img src="http://images.kingdomofloathing.com/itemimages/hobomonkey.gif" width=30 height=30></td><td valign=center>Stubert sits on your fallen opponent's body, blows a smoke ring, and winks at you.</td></tr></table></center><center><table><tr><td align=center valign=center><img src="http://images.kingdomofloathing.com/itemimages/meat.gif" width=30 height=30></td><td valign=center>You gain 297 Meat</td></tr></table></center><!--familiarmessage--><center><table><tr><td align=center valign=center><img src="http://images.kingdomofloathing.com/itemimages/t_spiceghost.gif" width=30 height=30></td><td valign=center>Wingwang whirls around picking up items, like a little couscous tornado.</td></tr></table></center><p>You gain 12 Beefiness.<bR>You gain 33 Wizardliness.<bR>You gain 10 Cheek.<bR><p><a name="end"></a><p><a href="adventure.php?snarfblat=324">Adventure Again (The Castle in the Clouds in the Sky (Top Floor))</a><p><a href="place.php?whichplace=giantcastle">Go back to The Castle in the Clouds in the Sky</a></center><script>parent.charpane.location.href="charpane.php";</script><script language="javascript">function updateParseItem(iid, field, info) {var tbl = $('#ic'+iid);var data = parseItem(tbl);if (!data) return;data[field] = info;var out = [];for (i in data) {if (!data.hasOwnProperty(i)) continue;out.push(i+'='+data[i]);}tbl.attr('rel', out.join('&'));}function parseItem(tbl) {tbl = $(tbl);var rel = tbl.attr('rel');var data = {};if (!rel) return data;var parts = rel.split('&');for (i in parts) {if (!parts.hasOwnProperty(i)) continue;var kv = parts[i].split('=');tbl.data(kv[0], kv[1]);data[kv[0]] = kv[1];}return data;}</script><script type="text/javascript" src="http://images.kingdomofloathing.com/scripts/pop_query.20130705.js"></script><script type="text/javascript" src="http://images.kingdomofloathing.com/scripts/ircm.20120523.js"></script><script type="text/javascript">function pop_ircm_contents(i, some) {var contents = '',shown = 0,da = ' <a href="#" rel="?" class="small dojaxy">[some]</a> <a href="#" rel="',db = '" class="small dojaxy">[all]</a>',dc = '<div style="width:100%; padding-bottom: 3px;" rel="',dd = '<a href="#" rel="1" class="small dojaxy">[';one = 'one'; ss=some;if (i.d==1 && i.s>0) { shown++;contents += dc + 'sellstuff.php?action=sell&ajax=1&type=quant&whichitem%5B%5D=IID&howmany=NUM&pwd=d0309b8afefd822dab8f7fbc81907c3f" id="pircm_'+i.id+'"><b>Auto-Sell ('+i.s+' meat):</b> '+dd+one+']</a>';if (ss) { contents += da + i.n + db;}contents += '</div>';}one = 'one'; ss=some;if (i.q==0) { shown++;contents += dc + 'inventory.php?action=closetpush&ajax=1&whichitem=IID&qty=NUM&pwd=d0309b8afefd822dab8f7fbc81907c3f" id="pircm_'+i.id+'"><b>Closet:</b> '+dd+one+']</a>';if (ss) { contents += da + i.n + db;}contents += '</div>';}one = 'one'; ss=some;if (i.u && i.u != ".") { shown++;contents += dc + 'inv_'+(i.u=="a"?"redir":(lab=(i.u=="u"?"use":(i.u=="e"?"eat":(i.u=="b"?"booze":"equip")))))+'.php?ajax=1&whichitem=IID&itemquantity=NUM&quantity=NUM'+(i.u=="q"?"&action=equip":"")+'&pwd=d0309b8afefd822dab8f7fbc81907c3f" id="pircm_'+i.id+'"><b>'+ucfirst(unescape(i.ou ? i.ou.replace(/\+/g," ") : (lab=="booze"?"drink":lab)))+':</b> '+dd+one+']</a>';if (ss && i.u != 'q' && !(i.u=='u' && i.m==0)) { contents += da + i.n + db;}contents += '</div>';}return [contents, shown];}var todo = [];function nextAction() {var next_todo = todo.shift();if (next_todo) {eval(next_todo);}}function dojax(dourl, afterFunc, hoverCaller, failureFunc, method, params) {$.ajax({type: method || 'GET', url: dourl, cache: false,data: params || null,global: false,success: function (out) {nextAction();if (out.match(/no\|/)) {var parts = out.split(/\|/);if (failureFunc) failureFunc(parts[1]);else $('#ChatWindow').append('<font color="green">Oops!  Sorry, Dave, you appear to be ' + parts[1] + '.</font><br />' + "\n");return;}if (hoverCaller)  {float_results(hoverCaller, out);if (afterFunc) { afterFunc(out); }return;}$(top.mainpane.document).find("#effdiv").remove(); if(!window.dontscroll || (window.dontscroll && dontscroll==0)) { window.scroll(0,0);}var $eff = $(top.mainpane.document).find('#effdiv');if ($eff.length == 0) {var d = top.mainpane.document.createElement('DIV');d.id = 'effdiv';var b = top.mainpane.document.body;if ($('#content_').length > 0) {b = $('#content_ div:first')[0];}b.insertBefore(d, b.firstChild);$eff = $(d);}$eff.find('a[name="effdivtop"]').remove().end().prepend('<a name="effdivtop"></a><center>' + out + '</center>').css('display','block');if (!window.dontscroll || (window.dontscroll && dontscroll==0)) {top.mainpane.document.location = top.mainpane.document.location + "#effdivtop";}if (afterFunc) { afterFunc(out); }}});}</script></td></tr></table></center></td></tr><tr><td height=4></td></tr></table></center></body></html>

and the HTML tree:

<td>
  <center>
    <table>
      <tbody>
        <tr>
          <td>
          <td valign="center">
            <span id="monname">
    <br>
    <p>
      <b>
        <font color="blue">
    <center>
      <table>
        <tbody>
          <tr>
            <td align="center" valign="center">
              <img src="http://images.kingdomofloathing.com/itemimages/t_spiceghost.gif" width="30" height="30">
            <td valign="center">
              <center>
                <table class="item" style="float: none" rel="id=8&s=1&q=0&d=1&g=0&t=1&n=1&m=0&p=0&u=u">
                  <tbody>
                    <tr>
                      <td>
                        <img src="http://images.kingdomofloathing.com/itemimages/spice.gif" alt="spices" title="spices" class="hand" onclick="descitem(266103456)">
                      <td valign="center" class="effect">
                        <b>
    <p>
    <center>
      <p>
      <center>
        <table>
          <tbody>
            <tr>
              <td align="center" valign="center">
                <img src="http://images.kingdomofloathing.com/itemimages/hobomonkey.gif" width="30" height="30">
              <td valign="center">
      <center>
        <table>
          <tbody>
            <tr>
              <td align="center" valign="center">
                <img src="http://images.kingdomofloathing.com/itemimages/meat.gif" width="30" height="30">
              <td valign="center">
      <p>
      <center>
        <table>
          <tbody>
            <tr>
              <td align="center" valign="center">
                <img src="http://images.kingdomofloathing.com/itemimages/t_spiceghost.gif" width="30" height="30">
              <td valign="center">
      <p>
        <br>
        <br>
        <br>
      <p>
      <p>
      <p>
    <p>

That is vastly truncated, from what I'd expect.

 

[roippi]

Just reverting the htmlcleaner changes, this is way more than I have time to tackle right now. r14775