Bug - Fixed Some combat items not marked as such

[Sary]

What it says on the tin - some combat items aren't labeled as a combat usable item. Looks like a problem with entries in tradeitems.txt possibly?

Mislabeling means they can't be used in a CCS, among other things.

Combat items I found lacking the combat flag:
- barbed-wire fence
- Doc Galaktik's Pungent Unguent
- Hair Spray
- Handful of sand
- high-pressure seltzer bottle
- Coily
- lewd playing card
- roofie
- shaving cream

I first discovered it with the barbed wire fence, then went through tradeitems.txt and did a manual comparison with the Combat Items wiki category. I then checked the pages of the above items to confirm combat useful-ness. I also confirmed that each of the above appear on the drop-down for items during a fight.

Using the latest build, I get the following in the CLI:

> ash $item[barbed-wire fence].combat
Returned: false

> ash $item[hair spray].combat
Returned: false

> ash $item[roofie].combat
Returned: false

etcetera.

Whereas for a properly labeled combat item I get:

> ash $item[baseball].combat
Returned: true

Thanks for your attention to this matter.

 

[Veracity]

I first discovered it with the barbed wire fence, then went through tradeitems.txt and did a manual comparison with the Combat Items wiki category. I then checked the pages of the above items to confirm combat useful-ness. I also confirmed that each of the above appear on the drop-down for items during a fight.

That's a lot of work! Thanks!

Revision 10745