Bug - Fixed Some combat drops in the Crimbo 2023 zones are ignored

[wRAR]

This can happen both with native monsters and e.g. sausage goblins. The drop line is absent from the combat log and the drop is not acknowledged. A sample debug HTML where the "3 piles of Elf Army machine parts" drop was not parsed:

 

[Ryo_Sangnoir]

Right, so this looks like the message ""Arr," says a nearby Crimbuccaneer. "10 points for ye, to be sure."" is being interpreted as damage. After that, all messages between that and the stats get skipped.

 

[gausie]

Yeah the insane damage tracking regex coming before we had unit testing is really unfortunate

 

[Ryo_Sangnoir]

Fixed with r27747.

 

[VladYvhuce]

Not sure if this's the proper topic, but it seems like we can get 3 pieces of 12, but the monster info says 1-2. This is separate from the additional piece from the map. Meaning that you can get 4 pieces per fight, rather than just 3, if a map is active.

 

[VladYvhuce]

Screenshot of this happening.

 

[wRAR]

1-2 is the base, plus +0-1 from the accessory plus +0-1 from the consumable effect (this goes into the main line) plus 1 from a map active (this goes into a separate line that mentions the map), up to 5 total.

 

[Ryo_Sangnoir]

You can "modtrace piece of twelve drop" to see what you have active. This doesn't include the global one.

 

[VladYvhuce]

You can "modtrace piece of twelve drop" to see what you have active. This doesn't include the global one.

Good to know. As someone who's a more casual user, I'm not good at remembering that that's a command. Thanks.