This test and a few others, appear to be wrong.
This also looks wrong.
For starters, as soon as the 5th writing desk is defeated. Second floor does not become available. We still need to talk to the ghost.
After talking to the ghost, our spookyraven necklace disappears. Second floor can now be travelled to.
But. The adventures still cannot be visited.
We talk to the ghost again on the second floor, the adventures can now be visited and we have a ghost necklace.
Checking for the existence of a ghost necklace is still wrong unless we're in our first ascension. The ghost necklace is not a quest only item, and can be acquired without needing to do the manor quest via storage/pulls. In hardcore, it works.
It could also be autosold, making it an unreliable check.
So checking for a ghost necklace is incorrect. Checking for a spookyraven necklace is incorrect. Neither of those promises that second floor is open unless you're in a specific situation.
We should probably be checking preferences.
But as it stands, if either of the necklaces are in our inventory, mafia appears to be claiming the adventures can be visited.
I'd make a PR myself, but I'm not sure if I'm missing something given the explicit tests here.
@Veracity
This also looks wrong.
For starters, as soon as the 5th writing desk is defeated. Second floor does not become available. We still need to talk to the ghost.
After talking to the ghost, our spookyraven necklace disappears. Second floor can now be travelled to.
But. The adventures still cannot be visited.
We talk to the ghost again on the second floor, the adventures can now be visited and we have a ghost necklace.
Checking for the existence of a ghost necklace is still wrong unless we're in our first ascension. The ghost necklace is not a quest only item, and can be acquired without needing to do the manor quest via storage/pulls. In hardcore, it works.
It could also be autosold, making it an unreliable check.
So checking for a ghost necklace is incorrect. Checking for a spookyraven necklace is incorrect. Neither of those promises that second floor is open unless you're in a specific situation.
We should probably be checking preferences.
But as it stands, if either of the necklaces are in our inventory, mafia appears to be claiming the adventures can be visited.
I'd make a PR myself, but I'm not sure if I'm missing something given the explicit tests here.
@Veracity
