It looks like questscategory.txt is redundant with the Quest enum in QuestDatabase, or at least could be incorporated into that instead.
I can see how the information could be incorporated. Two concerns about this idea, though:
- Not every quest in the data file is in the enum. I can add additional entries there, if you guys are ok with that.
- It seemed to me like content specific data is kept in data files, not java code.
I'm curious what this is supposed to show that the Quest Tracker doesn't already show in the charpane.
This iteration doesn't do anything besides duplicate the quest tracker in the charpane. I wanted to get feedback on the design before I started adding additional features.
My goal is to have something that completes steps of quests. The quests dropdown implements a few of these already, but I wanted something that changed dynamically with what quests were actually active.
There are a lot of whitespace changes that would not make it into mafia.
Those changes got made when I applied the formatter in the utils directory to those files. Don't particularly care if they get included or not.
I'd have added the categories to questslog.txt rather than adding a new file.
I put it in a separate file because I wanted to minimize the risk to other parts of the codebase. The index position is hard-coded in many places and I was concerned about missing one of those instances.
I'm not sure what QuestDatabaseTest is for.
I should have mentioned this in my original post, these are some JUnit tests I wrote to give me confidence my changes worked correctly without having to relaunch the gui every few minutes. It doesn't have to be included for the functionality to work correctly, but I thought the unit tests would be useful for others as well.
The real issue I can see is that currently the information in questslog.txt doesn't contain all the quest text from the quest log, just that which can be reasonably matched. Therefore we'd need to rebuild that data manually, probably involving another lookup file, and some other coding. That's quite a lot of extra steps for something which is already available in the relay browser.
This is a first draft, I think it would make more sense to get the step text from the quest log page instead of the data files in the final version. You're probably right that it would be too much work if these were the only features, but I have more ambitious features in mind and needed a place to put them.