Bug - Fixed Multiple visits to Altar of Literacy while in Valhalla

[Winterbay]

I ascended recently (20 minutes ago) with Mafia r10327 and while I was in Valhalla clicking around buying stuff and later clicking ascend the following was printed in the CLI:

Taking off everything...
Everything removed.

Visiting the Altar of Literacy
Checking for updates...
Latest version: 0.5
You have a current version of Character Info Toolbox.
_version_chit => 0.5
You need 1 more Knob Goblin eyedrops to continue.

Visiting the Altar of Literacy

Welcome to Valhalla!

Visiting the Altar of Literacy

Hardcore perm Fashionably Late for 200 Karma (initial balance = 913)

Visiting the Altar of Literacy

Buy astral hot dog dinner for 1 Karma (initial balance = 713)

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Buy astral shield for 10 Karma (initial balance = 712)

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Ascend as a Hardcore Male Turtle Tamer under the Mongoose sign on a Trendy path, banking 702 Karma.
Refreshing session data...
Synchronizing moon data...
Requests complete.

Loading character status...
Seeing what's still trendy today...

Visiting the Altar of Literacy
Done. Are YOU a fashion plate?
New message received from Your Pen Pal.

Retrieving character data...
Requests complete.

Refreshing closet...
Examining consumables in closet...
Examining equipment in closet...
Examining miscellaneous items in closet...
Requests complete.

Updating inventory...
Requests complete.

Retrieving familiar data...
Familiar data retrieved.
Retrieving campground data...
Requests complete.

Looking through your telescope...
Requests complete.

Refreshing storage...
Examining meat in storage...
Examining consumables in storage...
Examining equipment in storage...
Examining miscellaneous items in storage...
Requests complete.

Session data refreshed.
Pulling items from storage...
Requests complete.

Is there any reason for those visits to the Altar?
Also, is it possible for Mafia to not try and run the mood while ascending?

 

[Veracity]

Is there any reason for those visits to the Altar?

I'm sure there is, but your CLI log gives me no clue about what it might be. It didn't happen to me when I ascended earlier today.

Also, is it possible for Mafia to not try and run the mood while ascending?

I saw no mood being executed in the CLI log you posted. When did it run a mood?

 

[Veracity]

Loading character status...
Seeing what's still trendy today...

Visiting the Altar of Literacy
Done. Are YOU a fashion plate?

Notice the visit in between the TrendyRequest and its response. There was something asynchronous going on. Were you running a chat script. Or ... were you in KoLmafia's Loathing Chat?

Hmm. When you ascend, we reset all the character variables - including the one which tells ChatManager that you can chat. So, next time it wants to send something, it thinks it has to go look at the altar again. OK. I will make ascending save and restore your chat literacy flag, since you still can chat when you are in Valhalla.

 

[Veracity]

Revision 10334

 

[Winterbay]

I saw no mood being executed in the CLI log you posted. When did it run a mood?

You need 1 more Knob Goblin eyedrops to continue.

That part is from when it tried to run my mood (which contained that among 3 other things). Not that it really matters since everything continues along nicely afterwards.

Also, thanks for fixing the other thing.

 

[Veracity]

Recovery (moods, etc) was triggered when you entered Valhalla, we fetched the charpane, and noticed that all your effects had run out.

Revision 10336 will not try to run Recovery actions when you are in Valhalla.

 

[Ruby Eyes]

Apparently, this is un-fixed again?

I was still in Valhalla when my computer crashed, and upon logging back in, I get loads of attempts to visit that altar ... no matter if I try to enter chat in relay (well, I can enter, just trying to send anything results in altar visitis and no chattery) or via kolmafia button.

Just upgraded from r10733 to r10822, same result.

Right after crash, logged in, got confused, upgraded, first login with new version:

Installing naive certificate validation...
Validating login server (www.kingdomofloathing.com)...
858 players online.
Sending login request...
Using data override: data/mallprices.txt
Using data override: data/mallprices.txt
Initializing session for Ruby Eyes...
Refreshing session data...
Synchronizing moon data...
Loading character status...
Welcome to Valhalla!
7 days until Halloween, Muscle bonus today and tomorrow.
Initializing chat interface...

Visiting the Altar of Literacy
You cannot access chat until you complete the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

> logout

Preparing for logout...
Sending logout request...
Logout request submitted.
Logout completed.

Logged off, logged in natively, entered chat successfully to verify it's not a KoL issue. Then logged into mafia again.
Just clicked the "enter chat" link in relay, /cls and /w, then selected my ascension details which took a while ...

Installing naive certificate validation...
Validating login server (www.kingdomofloathing.com)...
831 players online.
Sending login request...
Initializing session for Ruby Eyes...
Refreshing session data...
Synchronizing moon data...
Loading character status...
Welcome to Valhalla!
7 days until Halloween, Muscle bonus today and tomorrow.

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Visiting the Altar of Literacy

Ascend as a Normal Female ... (etc)

 

[holatuwol]

Ok, so I'm taking out the altar of literacy check that happens every single time you access chat because I don't know why that code is even there. Instead, it'll do it once per character (assuming you can access chat) and cache that value forever.

Of course, I may have introduced a regression bug in doing so. Does anyone know how you could lose access to chat? I'm not sure I care if people get banned, since I'm guessing the altar of literacy message doesn't change in that case.

 

[fronobulax]

Ok, so I'm taking out the altar of literacy check that happens every single time you access chat because I don't know why that code is even there. Instead, it'll do it once per character (assuming you can access chat) and cache that value forever.

Of course, I may have introduced a regression bug in doing so. Does anyone know how you could lose access to chat? I'm not sure I care if people get banned, since I'm guessing the altar of literacy message doesn't change in that case.

I probably was the cause of that. I perversely have a character that has refused to visit the Altar of Literacy. When KoL implemented various chat commands there was talk of implementing mafia functionality only via chat and I pointed out that doing so would require KoLmafia users to visit the Altar. So the code is there because when it wasn't, at least one of my characters had a seriously substandard mafia experience, possibly to include throwing stack traces because code assumed accessing chat would succeed. If the decision is made that mafia users are required to visit the Altar then let's update the documentation, put a check in the code and I'll become literate. Otherwise I will be glad to report things that aren't working for that character ;-)