I was thinking it would be a cool idea to have a reminder in ValhallaDecorator to remember to request your muffin so you get your tin in your next life. I tried making a patch here but I have run into some issues.
View attachment muffin.patch
My first issue was that upon requesting the muffin ItemPool.EARTHENWARE_MUFFIN_TIN didnt automatically decrement. I just added that to ItemPool, so maybe I was supposed to do something else in the choice adventure handler? I'm not sure how that is supposed to work, should that be a thing where you manually update the item pool upon requesting the muffin as part of the choice adventure? It works properly after a refresh inv.
Secondly, I don't know how to tell for a account that has multiple muffin tins whether they already have a muffin queued up at Lyle's yet, and therefore am unable to determine if the earthenware tin in their inventory could actually still be used for a muffin. I am a lot less concerned about that, I think, because then you could just ignore the reminder, but I also don't want people getting bug reports about it. I imagined that a preference could be stored, but I think that again probably falls in line with some handling of the choice adventure.
I wouldn't feel bad at all if someone wanted to implement this better, I just think that this definitely qualifies as being worth a reminder before jumping the gash.
View attachment muffin.patch
My first issue was that upon requesting the muffin ItemPool.EARTHENWARE_MUFFIN_TIN didnt automatically decrement. I just added that to ItemPool, so maybe I was supposed to do something else in the choice adventure handler? I'm not sure how that is supposed to work, should that be a thing where you manually update the item pool upon requesting the muffin as part of the choice adventure? It works properly after a refresh inv.
Secondly, I don't know how to tell for a account that has multiple muffin tins whether they already have a muffin queued up at Lyle's yet, and therefore am unable to determine if the earthenware tin in their inventory could actually still be used for a muffin. I am a lot less concerned about that, I think, because then you could just ignore the reminder, but I also don't want people getting bug reports about it. I imagined that a preference could be stored, but I think that again probably falls in line with some handling of the choice adventure.
I wouldn't feel bad at all if someone wanted to implement this better, I just think that this definitely qualifies as being worth a reminder before jumping the gash.