New Content - Implemented Mafia Eats Potato Alarm Clock Message

[reverkiller]

There is a new item called "Potato Alarm Clock".
It generates a message on log in that is NOT a yellow notification. This message gets eaten by Mafia on log in (and it does not tell you if you received it).
This is certainly not game breaking, but it has been hard for me to tell if I actually had a potato clock in my inventory since I don't keep close track of how many turns I expect to generate on rollover.
I am not sure if this qualifies as a bug or not - I am going to mark it as one until someone tells me it is not

Screenshot for how it looks outside of mafia:

 

[Veracity]

It's "eaten" at login?

I assume this shows the first time (only) you hit main.php since rollover.
Since KoLmafia hits main.php as part of its login sequence - before you can go to the Relay Browser - I expect that message is in that request's response, but never again.

What do you want to happen? Make KoL show it to you again when you open the Relay Browser?
That won't happen.

I imagine we could detect the message in the main.php response and log something to the gCLI/session log - or set a property.

I have a few characters who have the potato alarm clock. I'll log into each, with logging, and get the HTML.

 

[Veracity]

Here it is.

<center><table  width=95%  cellspacing=0 cellpadding=0><tr><td style="color: white;" align=center bgcolor=blue><b>Results:</b></td></tr><tr><td style="padding: 5px; border: 1px solid blue;"><center><table><tr><td>Your potato alarm clock has been going off for 5 minutes now!<center><table><tr><td><img src="https://d2uyhvukfffg5a.cloudfront.net/itemimages/hourglass.gif" height=30 width=30 alt="Adventures"></td><td valign=center>You gain 5 Adventures.</td></tr></table></center>

 

[reverkiller]

It's "eaten" at login?

I assume this shows the first time (only) you hit main.php since rollover.
Since KoLmafia hits main.php as part of its login sequence - before you can go to the Relay Browser - I expect that message is in that request's response, but never again.

What do you want to happen? Make KoL show it to you again when you open the Relay Browser?
That won't happen.

I imagine we could detect the message in the main.php response and log something to the gCLI/session log - or set a property.

I have a few characters who have the potato alarm clock. I'll log into each, with logging, and get the HTML.

What I meant was "There is a message for using this item, and as a result of using Mafia I am not seeing this message when I log in, or communicated to me in anyway (added to session logs, etc.)." This is why I put it as "maybe not a bug" - I am unsure of what Mafia's intended behavior should be in these kinds of instances. KoL Clearly communicated a message to me, but then the message went away because of what mafia did and it did not show it to me. If the answer is "mafia will consume this message and not notify you by design", that is fine, but I wanted to make sure it was clear KoL was providing that mafia was _potentially_ ignoring.

 

[Veracity]

I posted the HTML.

When we log in via KoLmafia, if we detect that message:

- Set _potatoAlarmClockUsed to true
- Print a message to the gCLI
- Print a message to the session log

That's all we can do; we cannot make KoL display the message for you - again - when you open the Relay Browser

 

[Veracity]

Changed this to New Content.

 

[reverkiller]

Any of the above would be great - thank you. If I can get my mafia dev environment set up, i will try my best to PR this myself

 

[Veracity]

PR submitted. It worked just fine on one of my multis - all of whom have this item now.

 

[Veracity]

The problem with our new regime of required code reviews from people other than the author is that this has been sitting there for 22 hours and there is nothing I can do to push the code, as far as I know. This PR also supports (some of) the Dec 25 items. Oh well!

(Is there some way to "push" some essential fix without waiting for hours and hours for somebody else to approve it?

 

[fronobulax]

The problem with our new regime of required code reviews from people other than the author is that this has been sitting there for 22 hours and there is nothing I can do to push the code, as far as I know. This PR also supports (some of) the Dec 25 items. Oh well!

(Is there some way to "push" some essential fix without waiting for hours and hours for somebody else to approve it?

You should be able to push and merge on the basis of your Admin Privs. If you have them there is a checkbox to override the review requirement and commit. If you don't have the checkbox then @gausie will update things so you do.

In the meantime I will review.