Github Bot
Poster of Commits
Language Server - parseVariable initializations (#27)
( from https://kolmafia.us/threads/ash-language-server-features.26098/post-163766 )
A bit more complex than the last few; this patch modifies parseVariable so that the signal indicating that we're parsing parameters is a boolean, rather than scope being null, and waits until the end to throw the error.
This, again, will allow us to still keep trying to parse a parameter initialization, and will give us a full location once we throw the error.
Also shuffles the parsing logic a little, for efficiency.
* not supposed to touch that one either..?
Why'd the test work anyway, then..?
(context: https://github.com/kolmafia/kolmafia/pull/8/commits/d353d737a167ba043c1f0a672e2a46075b2384b5)
* way to pass the variable name (and location, in the future!)
View the full commit on Github
( from https://kolmafia.us/threads/ash-language-server-features.26098/post-163766 )
A bit more complex than the last few; this patch modifies parseVariable so that the signal indicating that we're parsing parameters is a boolean, rather than scope being null, and waits until the end to throw the error.
This, again, will allow us to still keep trying to parse a parameter initialization, and will give us a full location once we throw the error.
Also shuffles the parsing logic a little, for efficiency.
* not supposed to touch that one either..?
Why'd the test work anyway, then..?
(context: https://github.com/kolmafia/kolmafia/pull/8/commits/d353d737a167ba043c1f0a672e2a46075b2384b5)
* way to pass the variable name (and location, in the future!)
View the full commit on Github