New Content - Implemented KoL's item description for sauceror potions no longer takes class into account

Veracity

Developer
Staff member
> ash my_class()

Returned: Sauceror
primestat => Mysticality

> ash numeric_modifier( $item[ tomato juice of powerful power ], "Effect Duration" )

Returned: 15.0

> use 1 tomato juice of powerful power

Using 1 tomato juice of powerful power...
You acquire an effect: Tomato Power (duration: 15 Adventures)
Finished using 1 tomato juice of powerful power.
This character has Impetuous Sauciness, which adds 5 turns of the effect.
This character is a Sauceror, which adds 5 turns of the effect.

Since the base duration is 5 turns, when I use the item, I get 5 + 5 + 5 turns of the effect.

Nothing new about that. What does the Item Description say?

Requesting: http://www.kingdomofloathing.com/desc_item.php?whichitem=811452475

Code:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN""http://www.w3.org/TR/html4/loose.dtd"><html><head><title>Item Description</title><link rel="stylesheet" type="text/css" href="http://images.kingdomofloathing.com/styles.css"><style>a.hand {cursor: pointer;}</style><script language=Javascript src="http://images.kingdomofloathing.com/scripts/keybinds.min.2.js"></script><script language=Javascript src="http://images.kingdomofloathing.com/scripts/window.20111231.js"></script><script language="javascript">function chatFocus(){if(top.chatpane.document.chatform.graf) top.chatpane.document.chatform.graf.focus();}if (typeof defaultBind != 'undefined') { defaultBind(47, 2, chatFocus); defaultBind(190, 2, chatFocus);defaultBind(191, 2, chatFocus); defaultBind(47, 8, chatFocus);defaultBind(190, 8, chatFocus); defaultBind(191, 8, chatFocus); }</script></head><body><div id="description" class=small><center><img src="http://images.kingdomofloathing.com/itemimages/milk.gif" height=30 width=30 alt="milk"><br><b>tomato juice of powerful power</b></center><p><blockquote>Doctors say that lycopene is good for you, and man, in this case, they couldn't be more right. This juice is chock full of it, and chock full of POWER. This is like an eight-cylinder juice engine in your chassis. Oh yes. <br><br>Type: <b>potion</b><br>Effect: <b><a class=nounder href="desc_effect.php?whicheffect=1eb060ef5cd5a7cff1a210edc5b62748" >Tomato Power</a></b><br>Duration: <b>5 Adventures</b><br>Selling Price: <b>36 Meat.</b></blockquote></div></body></html>
Notice the "Duration: <b>5 Adventures</b>". That's a recent server-side change; until recently, just like every other item which has a variable effect, the item description showed you the effect as seen by your character. For example:

Requesting: http://www.kingdomofloathing.com/desc_item.php?whichitem=707506403

Code:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN""http://www.w3.org/TR/html4/loose.dtd"><html><head><title>Item Description</title><link rel="stylesheet" type="text/css" href="http://images.kingdomofloathing.com/styles.css"></head><body><div id="description"><center><img src="http://images.kingdomofloathing.com/itemimages/ultracolor.gif" height=30 width=30 alt="ultracolor"><br><b>Ultracolor™ shirt</b></center><p><blockquote>This is a T-shirt made of some kind of weird space-age material that changes color.  It's supposed to reflect your mood, but in practice the mood it reflects is usually "orange armpits."<br> <br>Type: <b>shirt</b><br>Power: <b>100</b><br>Muscle Required: <b>35</b><br>Selling Price: <b>80 Meat.</b><p><center>Enchantment:<br><b><font color=blue>+12 <font color=gray>Spooky Damage</font><br>+12 <font color=green>Stench Damage</font><br>+12 <font color=red>Hot Damage</font><br>+12 <font color=blue>Cold Damage</font><br>+12 <font color=blueviolet>Sleaze Damage</font><br> <br></font></b></center></blockquote></div></body></html>
This character has 12 active effects, so the Ultracolor shirt is +12 everywhere.

As I said, this is a change in KoL's behavior. I don't know if it was intentional, but assuming it won't change, the only place that KoLmafia cares would be in the "checkitem" command, which parses effects from the item description and comapares what it finds with what we have recorded - including evaluating modifier expressions. So, when my Sauceror character ran checkitems, we got this:

# *** modifier Effect Duration: [R] evaluates to 15 but description says 5
tomato juice of powerful power Effect: "Tomato Power", Effect Duration: [R]

... which is what alerted me to this recent KoL change.

I guess this needs a change in checkitems for the Effect Duration modifier.
 
Top