Bug - Fixed KoLmafia thinks it is round # but KoL thinks it is round #-1
- Thread starter icon315
- Start date
Theraze
Active member
Well, there's 2 different bugs in that thread... one regarding a null round with just the name if auto-attack is on, one added a few days later regarding saucy salve and the molybdenum magnet being considered to increase the round though they both take no time.
The first bug? No clue how to fix, if it's still an issue. The second? Depending on what the "hr" node is, I may be able to fix. But really, the second part of that thread should have been a new bug report instead of hijacking the autoattack bug.
The first bug? No clue how to fix, if it's still an issue. The second? Depending on what the "hr" node is, I may be able to fix. But really, the second part of that thread should have been a new bug report instead of hijacking the autoattack bug.
KoL considers autoattacks to happen in round 0. They are sort of like exchanging an action for losing initiative - as I understand it, the way it works is this:
If you lose the jump, the monster acts in round 0.
If you get the jump and act normally, you act first in round 1, then the monster acts in round 1.
If you get the jump and autoattack, you act in round 0, then the monster acts in round 0.
That's why you need to use autoattack for optimal mimic/NPZR farming - they get you another round before meat stops dropping after round 10.
Not that this is really relevant to the bug in the OP, it's just an explanation of other things being discussed in this thread.
If you lose the jump, the monster acts in round 0.
If you get the jump and act normally, you act first in round 1, then the monster acts in round 1.
If you get the jump and autoattack, you act in round 0, then the monster acts in round 0.
That's why you need to use autoattack for optimal mimic/NPZR farming - they get you another round before meat stops dropping after round 10.
Not that this is really relevant to the bug in the OP, it's just an explanation of other things being discussed in this thread.
Apparently Mafia's concept of a "round" isn't the same thing as a KoL round. If it was called a "combat counter" or "action number", would that stop the bug reports?
Mafia already parses the KoL round number, maybe it could be kept on a different counter? It would be nice if the KoL round number could be used in a CCS, to replicate the KoL Combat Macro "pastround" predicate.
In any case, there are workarounds if you need to know the round number, either in a CCS or in a consult script. In a CCS you can use a KoL Combat Macro command ("if pastround X"), and in a consult script you would need to parse the round number yourself ("onturn = (\\d+)").
Mafia already parses the KoL round number, maybe it could be kept on a different counter? It would be nice if the KoL round number could be used in a CCS, to replicate the KoL Combat Macro "pastround" predicate.
In any case, there are workarounds if you need to know the round number, either in a CCS or in a consult script. In a CCS you can use a KoL Combat Macro command ("if pastround X"), and in a consult script you would need to parse the round number yourself ("onturn = (\\d+)").
Theraze
Active member
Well, part of the question is, since we get the proper round count from KoL, why do we still parse what we think the round should be? We KNOW what it is... the page tells us. It's good for knowing when things are wrong... but wouldn't it make more sense to default our display to the proper KoL reading, not the mafia internal counter?
Fluxxdog
Active member
In Magic: the Gathering, the tournament rule when using different language cards is the English translation official ruling on the card. It would make sense with KoL telling us it's round X and mafia listening instead of saying "I think it's round Y" which is absolutely unimportant in the grand scheme of everything.
According to the wiki:
If mafia is already providing an incorrect round number, the CCS would already be broken. So, are CCSs using KoL's number or mafia's number?
According to the wiki:
Code:
The main() function in the ASH script being consulted must accept three parameters:
void main(int round, monster mob, string combat)
These values will be supplied by mafia when the consult script is called.
Mafia's number. Otherwise it would be impossible to list salve once in a CCS and have it cast only once.
Bale
Minion
If you did that, the KoL round would be displayed for decorative purpose while the mafia round would be hidden even though that's the number that actually affects scripts. That sounds like a bad idea and it is the opposite of reconciling the problem.
Theraze
Active member
Well, the reason for it would be because as it stands, while consults are being called, mafia tells you what the real round (according to KoL, which is where it counts) is. Once you go into your attacks, it stops displaying KoL's corrections... which means that you don't know how close failure is becoming.
Best/what I'd prefer is if CCS were able to both plan on staging commands as well as the true round... if it's going to take 15 rounds to plink the monster, but you've saved 15 rounds and only spent 5, that means you can stasis another 5 TRUE rounds for familiar meat before starting combat with a safe margin. As it currently stands, it would hit panic mode and an intelligent CCS would slap a power or two on the monster to guarantee success at this point, while in actual fact you've still got a significant cushion.
But yeah, even if it's just the display, it would be nice to be able to look back and see where the fight led to failure.
Best/what I'd prefer is if CCS were able to both plan on staging commands as well as the true round... if it's going to take 15 rounds to plink the monster, but you've saved 15 rounds and only spent 5, that means you can stasis another 5 TRUE rounds for familiar meat before starting combat with a safe margin. As it currently stands, it would hit panic mode and an intelligent CCS would slap a power or two on the monster to guarantee success at this point, while in actual fact you've still got a significant cushion.
But yeah, even if it's just the display, it would be nice to be able to look back and see where the fight led to failure.
Fred Nefler
Member
Just in case this hasn't been noted:
A few weeks back, I had set KoL to use a macro for auto-attack, but generally that macro did not complete combat (though sometimes it did), returning mafia to its normal CCS routines if it failed.
What I've noticed is that if the ENTIRE combat is handled by an auto-attack macro, then mafia never reports issues with round numbers. If it does other actions afterwards, however, it spams the conflict message. I imagine this is expected behavior, but just in case I'll mention it. I'd need to reproduce this if you want to know if it spams the conflict for the entire fight or only once mafia takes control, as it's been awhile. I believe at that time the conflict resulted in mafia aborting (but not because I told the CCS to), actually. Sorry that's all vague. Again, if more detail is actually needed on that, I can try reproducing with a current version.
A few weeks back, I had set KoL to use a macro for auto-attack, but generally that macro did not complete combat (though sometimes it did), returning mafia to its normal CCS routines if it failed.
What I've noticed is that if the ENTIRE combat is handled by an auto-attack macro, then mafia never reports issues with round numbers. If it does other actions afterwards, however, it spams the conflict message. I imagine this is expected behavior, but just in case I'll mention it. I'd need to reproduce this if you want to know if it spams the conflict for the entire fight or only once mafia takes control, as it's been awhile. I believe at that time the conflict resulted in mafia aborting (but not because I told the CCS to), actually. Sorry that's all vague. Again, if more detail is actually needed on that, I can try reproducing with a current version.
VladYvhuce
Member
This sort of bug is still around. If you lose initiative and have a KOL combat macro set to run, you'll get something like this:
It only does this if you lose initiative. Here's from the same session log when I won initiative:
When we see this message, KoLmafia has just submitted a combat action which KoL determined did not actually advance the combat round counter.
For example, if you pickpocket in the Relay Browser and then say "script" - which runs your CCS - the first action of which is "steal", we will submit another pickpocket request, which KoL will reject without advancing the round counter.
Whether or not we should have submitted that combat directive, this is a harmless response.
And, in other cases, it has been a useful spading tool: we have learned that such-and-such an action did not actually take a round of the fight.
Revision 17473 will take KoL's reported round # and accept it - which means that subsequent actions in the same combat will no longer be "off by one".
This is as good as it's going to get for this bug report.
For example, if you pickpocket in the Relay Browser and then say "script" - which runs your CCS - the first action of which is "steal", we will submit another pickpocket request, which KoL will reject without advancing the round counter.
Whether or not we should have submitted that combat directive, this is a harmless response.
And, in other cases, it has been a useful spading tool: we have learned that such-and-such an action did not actually take a round of the fight.
Revision 17473 will take KoL's reported round # and accept it - which means that subsequent actions in the same combat will no longer be "off by one".
This is as good as it's going to get for this bug report.
zarqon
Well-known member
Not sure if it's relevant to your purposes Veracity, but the round number reported by KoL may also be off, in the case that multiple rounds are present on the page. The onturn var that KoL gives us is the current round number only at the top of the page. Additional actions on the same page may or may not advance the round counter afterwards.
For example, on round 1, a player submits a macro which casts Weaksauce, then Salve, then an item he no longer has (for example the beehive, which I always have to "refresh inv" to get rid of). The resulting page contains onturn = 2, but the actual round number is 3 or maybe 4. Weaksauce took a round, Salve didn't, and attempting to use the nonexistent item may or may not advance the counter, I've never confirmed that.
So, it's not particularly simple to parse the round number from KoL's combat pages, despite the handy JavaScript variable ostensibly containing the round number.
For example, on round 1, a player submits a macro which casts Weaksauce, then Salve, then an item he no longer has (for example the beehive, which I always have to "refresh inv" to get rid of). The resulting page contains onturn = 2, but the actual round number is 3 or maybe 4. Weaksauce took a round, Salve didn't, and attempting to use the nonexistent item may or may not advance the counter, I've never confirmed that.
So, it's not particularly simple to parse the round number from KoL's combat pages, despite the handy JavaScript variable ostensibly containing the round number.
Something in the recent change is causing an infinite combat loop with the Turbo skill. Before, if Turbo did not fire due to cool down timer, it would go to the next thing in my CCS. Now, it just sits there trying to repeat the skill. This bug was first encounted on the 17473 build.
Build 17472
Encounter: garbage tourist
Round 0: immelan wins initiative!
Round 1: immelan tries to steal an item!
You acquire an item: bag of park garbage
You gain 23 Meat.
You gain 5 Meat.
Round 2: immelan casts EXTRACT!
You acquire an item: Source essence (2)
You gain 15 Meat.
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 4: immelan casts POCKET CRUMBS!
KoLmafia thinks it is round 5 but KoL thinks it is round 4
You gain 14 Meat.
Round 5: immelan casts RUN LIKE THE WIND!
KoLmafia thinks it is round 6 but KoL thinks it is round 5
You gain 97 Meat.
Build 17473
Encounter: horrible tourist family
Strategy: C:\Users\Neph\Desktop\kol - Copy\ccs\default.ccs [horrible tourist family]
Round 0: immelan wins initiative!
Round 1: immelan tries to steal an item!
You gain 13 Meat.
Round 2: immelan casts EXTRACT!
You acquire an item: Source essence (2)
You gain 14 Meat.
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
Build 17472
Encounter: garbage tourist
Round 0: immelan wins initiative!
Round 1: immelan tries to steal an item!
You acquire an item: bag of park garbage
You gain 23 Meat.
You gain 5 Meat.
Round 2: immelan casts EXTRACT!
You acquire an item: Source essence (2)
You gain 15 Meat.
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 4: immelan casts POCKET CRUMBS!
KoLmafia thinks it is round 5 but KoL thinks it is round 4
You gain 14 Meat.
Round 5: immelan casts RUN LIKE THE WIND!
KoLmafia thinks it is round 6 but KoL thinks it is round 5
You gain 97 Meat.
Build 17473
Encounter: horrible tourist family
Strategy: C:\Users\Neph\Desktop\kol - Copy\ccs\default.ccs [horrible tourist family]
Round 0: immelan wins initiative!
Round 1: immelan tries to steal an item!
You gain 13 Meat.
Round 2: immelan casts EXTRACT!
You acquire an item: Source essence (2)
You gain 14 Meat.
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 3: immelan casts TURBO!