Eating, drinking or spleening a +pvp consumable.
This patch adds support for warning you before eating, drinking, spleening a pvp consumable, also protects you from "over-banking" your PVP fights (Edit: No it doesn't) by prompting you when you try to consume if you already have enough fights banked (ie. if you try to eat a "gunpowder burrito" when you have 98 fights remaining, it will ask if you want to waste the 1 additional fights).
It works the same way as milk/ode protection, so it will only nag you
once per session, this is one warning shared across any consumable item that gives a PvP fight. If you're warned once that consuming the item is going to be a waste (say you're at 100 fights), it won't warn you the next time. I did it this way on purpose as that's the way the milk protection works, etc. but it would be easy enough to change.
Perhaps I could make it so that if you heed the warning, you'll get warned again but if you don't heed the warning (ie. you're
sure) then it won't ask you again that session. Any thoughts on that?
CSA fire starting kit is a choice adventure, so the handling for that would need to be slightly different, I could do that at a later time, but not part of this patch.
Edit: I haven't done PvP in a while, but I just came to the realization that PvP fights may work the same way as adventures, meaning that you could have more than 100 from consumables and they only get capped at rollover. Perhaps the "over-banking" check isn't really all that useful. Can anyone familiar with PvP confirm for me?
Edit 2: According to the wiki, it's perfectly possible to have over 100 PvP fights, so protecting people from that isn't really needed, I'll update the patch shortly (read: delete a bunch of code I wrote for no reason).
Edit 3: New patch posted, sans "100 PVP fights" protection.