Bug - Fixed erroneous familiar weight adjustments

roippi

Developer
r10677, Win 7, Java 6, regular charpane, no path

Something between r10634 and r10637 (almost certainly r10635) has caused some bad behavior when applying effects that modify familiar weight.

Code:
> equip sugar shield

Putting on sugar shield...
Adjusting familiar weight by 10 pounds
Equipment changed.

> remove sugar shield

Taking off sugar shield...
Adjusting familiar weight by -20 pounds
Equipment changed.

I'd attach a debug log, but the gist of it is: EquipmentRequest calls CharpaneRequest. charpane.php received, familiar weight is erroneously adjusted.

Edit: found it. line 204

Code:
		CharPaneRequest.checkFamiliar( responseText );
needs to happen after KoLCharacter.recalculateAdjustments(). I'd move it there myself but I have absolutely no idea if that will do bad things to the clancy parsing that happens in between. Veracity? :)
 
Last edited:
Top