Bug - Cannot Reproduce erratic problems with the new drinking code using the TPS

[cankergoyle]

Hi,

Something weird is going on with mafia using tiny plastic swords consistently. Sometimes it works fine, and other times no. Below are output snippets from a single session where I was automatically doing "refresh all" before making stuff to "guarantee" mafia was seeing things correctly.

KoLmafia v14.2 r8631
Released on September 16, 2010
....
Refreshing stash contents...
Stash list retrieved.
Pulling items from stash...
You acquire an item: tiny plastic sword
Searching for "lime"...
Purchasing lime (3 @ 975)...
You acquire lime (3)
Purchases complete.
Searching for "bottle of tequila"...
Purchasing bottle of tequila (3 @ 300)...
You acquire bottle of tequila (3)
Purchases complete.
Visiting The Gnomish Micromicrobrewery...
Menu retrieved.
Verifying ingredients for bodyslam (1)...
Verifying ingredients for skewered lime (1)...
Creating skewered lime (1)...
You acquire an item: skewered lime
Successfully created skewered lime (1)
Verifying ingredients for tequila with training wheels (1)...
Creating tequila with training wheels (1)...
You acquire an item: tequila with training wheels
Successfully created tequila with training wheels (1)
Creating bodyslam (1)...
You acquire an item: bodyslam
Successfully created bodyslam (1)
Drinking bodyslam (1 of 3)...
You gain 29 Adventures
You gain 17 Strongness
You acquire an item: tiny plastic sword
You gain 6 Drunkenness
You lose some of an effect: Ode to Booze
...
Dropping items into stash...

Then I adventure and try to make 1 more tps drink as a night cap...

Refreshing session data...
Synchronizing moon data...
Retrieving character data...
Retrieving familiar data...
Familiar data retrieved.
Refreshing closet...
Updating consumable items...
Updating miscellaneous items...
Refreshing stickers...
Retrieving campground data...
Session data refreshed.
Pulling items from stash...
You acquire an item: tiny plastic sword
Searching for "lime"...
Purchasing lime (2 @ 975)...
You acquire lime (2)
Purchases complete.
Searching for "bottle of tequila"...
Purchasing bottle of tequila (1 @ 300)...
You acquire an item: bottle of tequila
Purchases complete.
Verifying ingredients for bodyslam (1)...
Verifying ingredients for tequila with training wheels (1)...
Creating tequila with training wheels (1)...
You acquire an item: tequila with training wheels
Successfully created tequila with training wheels (1)
Verifying ingredients for skewered lime (1)...
Creating skewered lime (1)...
Creation failed, no results detected.

 >

Clearly seems to have everything it needs, but cannot make it through the first creation step. Mafia worked yesterday through both sequences with the same setup, but appears to have these occasional hiccups every few days ever since the booze/food revamp. The erratic non-repeatability of it is worrying/annoying.

[EDIT: Hrmm, just noticed update 8633 for the TPS...I will monitor if that fixes things, however not so clear to me why a change in concoctions.txt would cause this erratic behavior?]

 

[lostcalpolydude]

Creation failed, no results detected.

My first thought there is internet issues, where the response from KoL failed to make it back to mafia for whatever reason. Mafia can't do anything about that.

 

[cankergoyle]

I guess that remains a possibility. Is there any useful way to test for that? Will it show up in debug logs? (basically what information would be helpful for me to track if/when it happens again?)

I am slightly skeptical of a network issue because a) the timing of the problems does seem to correlate with the booze/food revamp and b) our buffbot has been running on the same machine/version of kolmafia without a flaw for literally years (but does not use a tps). Both arguments are quite circumstantial, I realize, but do speak to the consistency of mafia with other commands both pre- and post-September revamp.

 

[fronobulax]

My first thought there is internet issues, where the response from KoL failed to make it back to mafia for whatever reason. Mafia can't do anything about that.

I have seen that with network issues but I have also seen it several times since the food and drink crafting revamp. I don't recall that there was a consistent cause but in most cases there was some reason that I could not make the requested item even though mafia thought I had met the pre-requisites. Trying the creation manually in the relay browser may help find a work around. In my case it always seemed to have something to do with the new Kitchen, crafting items and what I was trying to make. Problem went away when I manually used the items and associated boxen.