Bug - Fixed EquipmentRequest processes results even if it detects an error

[slyz]

I can reproduce this simply with Halos:

> wear

Hat: (none)
Weapon: (none)
Off-hand: (none)
Shirt: (none)
Pants: (none)

Acc. 1: (none)
Acc. 2: (none)
Acc. 3: frosty halo

Pet: Adorable Seal Larva (24 lbs)
Item: (none)

> equip shining halo

Putting on shining halo...
[color=red]You can't equip a shining halo because you're already wearing a frosty halo.[/color]

> wear

Hat: (none)
Weapon: (none)
Off-hand: (none)
Shirt: (none)
Pants: (none)

Acc. 1: shining halo (2)
Acc. 2: (none)
Acc. 3: frosty halo

Pet: Adorable Seal Larva (24 lbs)
Item: (none)

The problem is that EquipmentRequest.processResults() is called when the EquipmentRequest is run, and the error check comes afterwards.

My guess is that the error checking should be moved to EquipmentRequest.processResults(), before calling EquipmentRequest.parseEquipmentChange(). Would that be the correct way to do it?

EDIT: alternatively, EquipmentManager should know about non-stackable items, and stop before the request is submitted, or unequip the other halo like we do for offhand weapons that don't match the weapon being equipped in the main hand.

 

[Darzil]

Is this the same as when you try to equip an offhand via a link when you have a two handed item already equipped? It fails, but still thinks the offhand is equipped, and won't let you equip it via equipment manager until you've equipped something else first.

 

[slyz]

I think the problem is the same, yes.

 

[Veracity]

Revision 10282. And no, it's not the same as "trying to equip something via a link", since that is a RelayRequest, and slyz's bug was in EquipmentRequest.