EatDrink.ash: Optimize your daily diet (and see how your old diet stacks up).
- Thread starter dj_d
- Start date
is shopping supposed to be this inefficient?
(this is with most recent version, but have seen it with previous versions too)
Mafia version is 6640.
I killed the script after about ten minutes, as it was repeatedly trying and failing to buy anything. I was worried I might trigger Jick's bot filter :-(
(zipped mafia log attached as plain text was a a bit long)
thanks for the script
Dave
(this is with most recent version, but have seen it with previous versions too)
Mafia version is 6640.
I killed the script after about ten minutes, as it was repeatedly trying and failing to buy anything. I was worried I might trigger Jick's bot filter :-(
(zipped mafia log attached as plain text was a a bit long)
thanks for the script
Dave
[quote author=morgad link=topic=2038.msg10678#msg10678 date=1230063890]
is shopping supposed to be this inefficient?
I killed the script after about ten minutes, as it was repeatedly trying and failing to buy anything. I was worried I might trigger Jick's bot filter :-(
[/quote]
Kind of, unfortunately, yes. Thanks for bringing it up though - with Crimbo, that's really unacceptable. I made a quick fix in 2.01 that'll require about 4x fewer attempts to buy something that's mispriced, on average.
This is an unfortunate side effect of the workarounds due to Mafia not having a way to buy something for a certain maximum price, and not having a way to get approximate real-time mall prices.
is shopping supposed to be this inefficient?
I killed the script after about ten minutes, as it was repeatedly trying and failing to buy anything. I was worried I might trigger Jick's bot filter :-(
[/quote]
Kind of, unfortunately, yes. Thanks for bringing it up though - with Crimbo, that's really unacceptable. I made a quick fix in 2.01 that'll require about 4x fewer attempts to buy something that's mispriced, on average.
This is an unfortunate side effect of the workarounds due to Mafia not having a way to buy something for a certain maximum price, and not having a way to get approximate real-time mall prices.
Thanks dj_d, that was much better 
best regards
Dave
Code:
******************************************
Now, to recap...
******************************************
Consuming up to 15 food, 12 booze, and 15 spleen
Considering food from inventory Hagnk's the mall. Per-item budget cap is 40000.0.
Price will be a factor if you own it already. Hagnk's pulls (if enabled) will cost 1000 meat each.
An adventure has the value of 500 meat. Muscle subpoint is 10. Nonprime stat subpoint is 2.
Now at fullness of 0, eating to 15.
0: milk of magnesium price: 150
1: Crimbo pie lev:7 gain:3.0 adv:11.0 musc:35.0 myst:0.0 moxie:0.0 price:160 own:0 value:1896
2: Crimbo pie lev:7 gain:3.0 adv:11.0 musc:35.0 myst:0.0 moxie:0.0 price:160 own:0 value:1896
3: Crimbo pie lev:7 gain:3.0 adv:11.0 musc:35.0 myst:0.0 moxie:0.0 price:320 own:0 value:1843
4: Crimbo pie lev:7 gain:3.0 adv:11.0 musc:35.0 myst:0.0 moxie:0.0 price:430 own:0 value:1806
5: Crimbo pie lev:7 gain:3.0 adv:11.0 musc:35.0 myst:0.0 moxie:0.0 price:430 own:0 value:1806
Now at inebriety of 0, drinking to 12.
1: ocean motion lev:4 gain:4.0 adv:12.0 musc:26.0 myst:9.0 moxie:0.0 price:230 own:23 value:1512
2: ocean motion lev:4 gain:4.0 adv:12.0 musc:26.0 myst:9.0 moxie:0.0 price:230 own:22 value:1512
3: ocean motion lev:4 gain:4.0 adv:12.0 musc:26.0 myst:9.0 moxie:0.0 price:230 own:21 value:1512
Now at spleen of 0, spleening to 15.
1: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
2: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
3: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
4: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
5: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
6: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
7: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:180 own:0 value:446
8: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
9: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
10: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
11: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
12: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
13: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
14: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
15: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:250 own:0 value:376
Finished. You had -milk-Adventures listed above does not reflect that, but this does:
Spent 4960 meat. Gained Fullness: 15. Inebriety: 12. Spleen: 15. Adventures: 117. Muscle: 500. Moxie: 130. Mysticality: 164.
Eating, drinking, and spleening complete. Commence merrymaking (at your own discretion).best regards
Dave
spoke too soon, it hates Genalen bottles ... doe not incearse budget for them
Code:
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
Purchased 0 Genalen™ Bottle for 0 meat.
Failed to get Genalen™ Bottle for a max price of 2.0*100
FAIL: Genalen™ Bottle lev:10 gain:1.0 adv:3.0 musc:22.5 myst:22.5 moxie:0.0 price:100 own:0 value:1670
Getting prices and calculating total food scores
Choosing food to consume.
Attempting to consume...
budgeting 200 for 1 additional Genalen™ Bottle. You have 8215068 meat. You have 0 in inventory already.
You have more meat than budgeted, so putting the excess 8214868 meat in closet.
Placing meat into closet...
Searching for "Genalen™ Bottle"...
Removing meat from closet...
KoLmafia declares world peace.
Retrieving character data...
Requests complete.so ... this is possibly a stupid question ...
I didn't want all the extraneous data files in my root scripts directory, so I made an individual directory for eatdrink and put everything there. But it seems to read/write files out of scripts\ , not scripts\eat\.
I guess I don't really understand how read/write works, but I'll start to look into it
I didn't want all the extraneous data files in my root scripts directory, so I made an individual directory for eatdrink and put everything there. But it seems to read/write files out of scripts\ , not scripts\eat\.
I guess I don't really understand how read/write works, but I'll start to look into it
[quote author=dj_d link=topic=2038.msg10709#msg10709 date=1230231939]
There was a note on this in the original post, but I never hit the bug the way you are... tell me if the attached fixes your problem (it should just ignore Genalen bottles).
[/quote]
sorry - this does not fix it for me, still fails to increase budget for Genalen bottles
@kain - have you tried moving the data files to /data from /scripts ?
best regards
DAve
There was a note on this in the original post, but I never hit the bug the way you are... tell me if the attached fixes your problem (it should just ignore Genalen bottles).
[/quote]
Code:
string EATDRINK_VERSION = "2.01";
string EATDRINK_VERSION_PAGE = "2038";sorry - this does not fix it for me, still fails to increase budget for Genalen bottles
@kain - have you tried moving the data files to /data from /scripts ?
best regards
DAve
No attempt to buy Genalan this time
many thanks
Dave
Code:
******************************************
Now, to recap...
******************************************
Consuming up to 15 food, 13 booze, and 15 spleen
Considering food from inventory Hagnk's the mall. Per-item budget cap is 40000.0.
Price will be a factor if you own it already. Hagnk's pulls (if enabled) will cost 1000 meat each.
An adventure has the value of 500 meat. Muscle subpoint is 10. Nonprime stat subpoint is 2.
Now at fullness of 0, eating to 15.
0: milk of magnesium price: 1135
1: Hell ramen lev:6 gain:6.0 adv:25.5 musc:25.5 myst:25.5 moxie:25.5 price:122 own:16 value:2164
2: Hell ramen lev:6 gain:6.0 adv:25.5 musc:25.5 myst:25.5 moxie:25.5 price:122 own:15 value:2164
3: Crimbo pie lev:7 gain:3.0 adv:11.0 musc:35.0 myst:0.0 moxie:0.0 price:161 own:0 value:1896
Now at inebriety of 0, drinking to 13.
1: gimlet lev:6 gain:4.0 adv:16.0 musc:0.0 myst:43.5 moxie:0.0 price:320 own:0 value:1941
2: fuzzbump lev:4 gain:4.0 adv:12.0 musc:35.0 myst:0.0 moxie:0.0 price:230 own:0 value:1530
3: ocean motion lev:4 gain:4.0 adv:12.0 musc:26.0 myst:9.0 moxie:0.0 price:230 own:19 value:1512
4: can of Swiller lev:10 gain:1.0 adv:3.0 musc:12.5 myst:0.0 moxie:0.0 price:272 own:0 value:1353
Now at spleen of 0, spleening to 15.
1: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:35 value:356
2: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:34 value:356
3: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:33 value:356
4: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:32 value:356
5: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:31 value:356
6: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:30 value:356
7: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:29 value:356
8: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:28 value:356
9: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:27 value:356
10: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:26 value:356
11: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:25 value:356
12: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:24 value:356
13: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:23 value:356
14: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:22 value:356
15: twinkly wad lev:6 gain:1.0 adv:1.0 musc:9.0 myst:9.0 moxie:9.0 price:270 own:21 value:356
Finished. You had -milk-Adventures listed above does not reflect that, but this does:
Spent 956 meat. Gained Fullness: 15. Inebriety: 13. Spleen: 15. Adventures: 127. Muscle: 300. Moxie: 191. Mysticality: 307.
Eating, drinking, and spleening complete. Commence merrymaking (at your own discretion).many thanks
Dave
I wanted to post to thank you for your script. I have used it successfully for a week or so and it works great. The only issue I have had is remembering to set
For myself, I start the day with a fortune cookie, run eatdrink.ash with food set to 14, then when the cookie numbers are exhausted eat another cookie. It has worked well so far.
Lastly a request, is there a way to fire the summary after an abort?
Thanks again for all your hard work.
for each new version.
For myself, I start the day with a fortune cookie, run eatdrink.ash with food set to 14, then when the cookie numbers are exhausted eat another cookie. It has worked well so far.
Lastly a request, is there a way to fire the summary after an abort?
Thanks again for all your hard work.
Try the attached... it has a looooooong form calling convention where you can specify EVERY flag, like so:
eatdrink (fullness_limit(), inebriety_limit(), spleen_limit, true,
true, true, true, false, true,
true, 10000, 2.0, true, 1000, false, 600, 10, 2,
false, 999999999, 999999999, false, 0);
You can make that function call from a script, and it will call eatdrink with the appropriate parameters every time - even after downloading a new build. If you like it, I'll roll it in to main, so it'll always work with new versions.
Unfortunately I don't know any easy way to get the summary on abort. If it were easier to write & read strings to/from files I might make it so it prints any aborted output on next run, but that's a PITA right now.
By the way - why is pie_priority giving you trouble? What's the situation where you don't have the keys but don't want to eat the pies?
eatdrink (fullness_limit(), inebriety_limit(), spleen_limit, true,
true, true, true, false, true,
true, 10000, 2.0, true, 1000, false, 600, 10, 2,
false, 999999999, 999999999, false, 0);
You can make that function call from a script, and it will call eatdrink with the appropriate parameters every time - even after downloading a new build. If you like it, I'll roll it in to main, so it'll always work with new versions.
Unfortunately I don't know any easy way to get the summary on abort. If it were easier to write & read strings to/from files I might make it so it prints any aborted output on next run, but that's a PITA right now.
By the way - why is pie_priority giving you trouble? What's the situation where you don't have the keys but don't want to eat the pies?
Eatdrink cooks! The attached version should create anything for which you have the skills and ingredients (and bartender/chef-in-the-box). Costing rules are observed, so if you have consider_price_when_owned set it will avoid cooking expensive things if you're being cheap.
Let me know if this works for you; if so, I'll update the main version.
This also includes some significant bugfixes, including a divide-by-zero error when you're at low levels, plus run a bit faster.
You will have to either replace your data files with the attached, or add two columns of 'false' to your own.
Let me know if this works for you; if so, I'll update the main version.
This also includes some significant bugfixes, including a divide-by-zero error when you're at low levels, plus run a bit faster.
You will have to either replace your data files with the attached, or add two columns of 'false' to your own.
Thanks for letting me know how it works for you; I appreciate it! I found both bugs (trying to buy it, and the buy repeating itself infinitely) and updated the previous post with fixes. Try downloading it again and letting me know if it works for you.
I just realized that I only tested it in ronin, hence not finding the problem...
I just realized that I only tested it in ronin, hence not finding the problem...