Bug - Fixed Drunki-bears

[fronobulax]

Since r26920 my consumption script wants to drink a red drunki-bear as a nightcap which it cannot do since they are eaten (and the stomach is full). I will eventually investigate but since the Consumption Database was recently refactored, someone else might have an idea sooner.

 

[Veracity]

They give 4 drunk and 4 fullness..
Milk of magnesium kicks in but ode to booze does not.
You can eat it overdrunk - given 4 fullness available - so it is a lousy choice for a nightcap, regardless.

Is the KoLmafia bug that it no longer shows both of those in the proxy record fields of the item?

Or is it a bug in your script for not noticing that it has both?

 

[Veracity]

(I should add drunki-bears to the “do not consider” list of vcon, although I think it already ignores consumables that fill more than one organ.)

 

[Veracity]

r26918:

> ash $item[red drunki-bear]

Returned: red drunki-bear
name => red drunki-bear
plural => red drunki-bears
descid => 837752850
...
fullness => 4
inebriety => 4
spleen => 0
...

r26921:

> ash $item[red drunki-bear]

Returned: red drunki-bear
name => red drunki-bear
plural => red drunki-bears
descid => 837752850
...
fullness => 0
inebriety => 4
spleen => 0
...

So, OK. There's the bug.

 

[Ryo_Sangnoir]

Other changes:
In the item manager, they used to show in food but not booze. Now it's the other way around. The notes ("4 Fullness") makes more sense like this, though.

The issue came in the refactor, line 292 of ConsumablesDatabase:

usage == KoLConstants.CONSUME_EAT ? size : null

Could use the notes field to store fullness / inebriety if both, or try to combine fullness.txt / inebriety.txt if duplicate entries with the same names, or just special-case the drunki-bears.

 

[txrangersxx]

This change appears to break the Consume script

 

[Veracity]

This change appears to break the Consume script

Completely unsurprising.
It's a bug. It will get fixed.

 

[Veracity]

r26925