Bug Creating Talisman o' Nam results in an error

StDoodle

Minion
I could swear I had the "you need one more guady key" message yesterday as well, but all I have in my log is:
Code:
Use 1 gaudy key
You acquire an item: snakehead charrrm

Use 1 gaudy key
You acquire an item: snakehead charrrm

Combine 1 snakehead charrrm + 1 snakehead charrrm
You acquire an item: Talisman o' Nam
FWIW, I believe I tried using 2 gaudy keys via either cli or the [use] link... but can't recall for certain.
 

Veracity

Developer
Staff member
Looking at the code, I see that the autocrafting kicks in when you obtain a snakehead charrrm, not a gaudy key. Therefore, my comment about not being able to use gaudy key as a condition was incorrect.

Revision 8974 (untested) will only autoCraft a Talisman o'Nam when the second snakehead charrrm appears in inventory.
 

roippi

Developer
Hmm. Autoadventuring using r8978:

Code:
Validating adventure sequence...
Condition set: Talisman o' Nam
Talisman o' Nam
Requests complete.

Request 1 of 181 (Island: Belowdecks) in progress...

*snip*

Request 4 of 181 (Island: Belowdecks) in progress...

[669] Belowdecks
Encounter: gaudy pirate
Strategy: C:\Users\Ben\Desktop\KoL\ccs\default.ccs [default]
Round 0: roippi wins initiative!
(unable to macrofy due to action: consult SmartishStasis.ash)
Round 1: roippi casts ENTANGLING NOODLES!
Round 2: roippi casts WEAPON OF THE PASTALORD!
Round 3: roippi casts CANNELLONI CANNON!
Round 4: roippi wins the fight!
You gain 102 Meat
You acquire an item: gaudy key
After Battle: Tron says "Please accept this token of my devotion to my user," and hands you an actual, literal token. Now that you think of it, you actually are kind of using him. Is this really a healthy relationship?
You acquire an item: Game Grid token
You gain 13 Muscleboundness
You gain 17 Enchantedness
You gain 14 Chutzpah

Verifying ingredients for Talisman o' Nam (1)...
Verifying ingredients for snakehead charrrm (2)...
Creating snakehead charrrm (1 of 2)...
You acquire an item: snakehead charrrm
Successfully created snakehead charrrm (1)
You acquire an item: snakehead charrrm
Verifying ingredients for Talisman o' Nam (1)...
Creating Talisman o' Nam (1)...
You acquire an item: Talisman o' Nam
Successfully created Talisman o' Nam (1)
Successfully created snakehead charrrm (-1)
[COLOR="red"]Creation failed, no results detected.[/COLOR]
Creating snakehead charrrm (2 of 2)...
[COLOR="red"]Creation failed, no results detected.[/COLOR]
Conditions satisfied after 4 adventures.

Code:
> get autoCraft

true
 

Theraze

Active member
So, on that, did you have the Talisman as your goal, or 2 snakehead charrrms, or 2 gaudy keys, or none of the above? Just trying to figure out what it did to get your conditions satisfied. Obviously the 2 creation fails shouldn't happen though...
 

roippi

Developer
Talisman was set as the goal.

What I'm noticing is that there's no "Creating snakehead charrrm (2 of 2)..." line, it just acquires the second one right after the first one.
 

Veracity

Developer
Staff member
Aargh. I'm going to mark this un-fixed. This issue does not affect me, since I click on use links in the relay browser for the gaudy keys, rather than autoadventuring Belowdecks, but I will try to think of this next time I ascend.
 

psly4mne

Member
Error when creating Talisman o' Nam

After manually adventuring for 2 gaudy keys, I typed "make nam" in the CLI. The Talisman o' Nam was created, as expected, but then mafia printed an error message.

Code:
> make nam

Verifying ingredients for Talisman o' Nam (1)...
Verifying ingredients for snakehead charrrm (2)...
Creating snakehead charrrm (1 of 2)...
You acquire an item: snakehead charrrm
Successfully created snakehead charrrm (1)
You acquire an item: snakehead charrrm
Verifying ingredients for Talisman o' Nam (1)...
Creating Talisman o' Nam (1)...
You acquire an item: Talisman o' Nam
Successfully created Talisman o' Nam (1)
Successfully created snakehead charrrm (-1)
Creation failed, no results detected.
Creating snakehead charrrm (2 of 2)...
Creation failed, no results detected.

> inv nam

Talisman o' Nam
 

StDoodle

Minion
Bah, I thought that one was closed out. Goes to show I should have stuck to my "stepping back" plan for the weekend. Gr.
 

Theraze

Active member
Well, it was fixed in that it doesn't autocreate if you've only converted one of the two gaudy keys, and it happens instead when the second charrrm hits your inventory... but it appears from the report that if you create talisman instead of converting the keys, it's still buggy.

If psly4mne is actually using the latest daily version, which wasn't a part of the report. If this is using an old version, then yes... that was an issue that Veracity fixed. Update, and it should go away. :)
 

jasonharper

Developer
Is there any particular reason why the auto-create is triggering on the snakehead charm rather than the gaudy key? That seems like it would be more convenient for the user, and would avoid all these recursion problems because no instances of the trigger item are created during the process. (I'm assuming that the gaudy key is not pickpocketable, which would make it completely unsuitable as the trigger.)
 

Veracity

Developer
Staff member
Because there are people who, for some unknown reason, adventure with the goal of "2 gaudy key", intending to manually use them later, and if we auto-converted them, their condition would never get satisfied.
 

lostcalpolydude

Developer
Staff member
Also, people could decide to fax a gaudy pirate before they open belowdecks, and then mafia is left trying to use it when it can't be used. It's kind of unfortunate, because it's a good enough idea that I took the time to add it to my own version.
 
Graaggh...

Verifying ingredients for Talisman o' Nam (1)...
Verifying ingredients for snakehead charrrm (2)...
Creating snakehead charrrm (1 of 2)...
You acquire an item: snakehead charrrm
Successfully created snakehead charrrm (1)
You acquire an item: snakehead charrrm
Verifying ingredients for Talisman o' Nam (1)...
Creating Talisman o' Nam (1)...
You acquire an item: Talisman o' Nam
Successfully created Talisman o' Nam (1)
Successfully created snakehead charrrm (-1)
Creation failed, no results detected.
Creating snakehead charrrm (2 of 2)...
Creation failed, no results detected.
Conditions satisfied after 9 adventures.
 

lostcalpolydude

Developer
Staff member
Graaggh...

Verifying ingredients for Talisman o' Nam (1)...
Verifying ingredients for snakehead charrrm (2)...
Creating snakehead charrrm (1 of 2)...
You acquire an item: snakehead charrrm
Successfully created snakehead charrrm (1)
You acquire an item: snakehead charrrm
Verifying ingredients for Talisman o' Nam (1)...
Creating Talisman o' Nam (1)...
You acquire an item: Talisman o' Nam
Successfully created Talisman o' Nam (1)
Successfully created snakehead charrrm (-1)
Creation failed, no results detected.
Creating snakehead charrrm (2 of 2)...
Creation failed, no results detected.
Conditions satisfied after 9 adventures.

It seems that mafia only had to make one snakehead charrrm before making the talisman. That means one was made earlier, and information about that is probably useful.
 
Top