Bug - Fixed crafting "and sour" sauces r10226

[Captain Kirk]

I am an accordion thief and wanted to make some "and sour" sauces.. (I have Way of the Sauce permed). So from the crafting
menu, I selected cold and sour sauce and to my horror the following happened:

Putting on Travoltan trousers...
Equipment changed.
Verifying ingredients...
Verifying ingredients for cold and sour sauce (60)...
Searching for "scrumdiddlyumptious solution"...
Search complete.
Purchasing scrumdiddlyumptious solution (60 @ 2,367)...
You acquire scrumdiddlyumptious solution (60)
Purchases complete.
Creating cold and sour sauce (60)...
You acquire cold and sour sauce (60)
Successfully created cold and sour sauce (60)


What I expected to happpen was to:
1) purchase 60 delectable catalyst from the pasta guild store
2) use the 60 delectable to create scrumdiddlyumptious solution
3) cook with the cold nuggets to make the sauce

So this should have cost 950 * 60 = 57,000 meat instead of 60 * 2,367 (lowest mall price) = 142,020

I was able to do all of this manually later on, but I had already lost the meat to the mall.

Could this be fixed please?

Thanks.

 

[Veracity]

What I expected to happpen was to:
1) purchase 60 delectable catalyst from the pasta guild store
2) use the 60 delectable to create scrumdiddlyumptious solution
3) cook with the cold nuggets to make the sauce

Each catalyst usage also consumes a scrumptious reagent.

So this should have cost 950 * 60 = 57,000 meat instead of 60 * 2,367 (lowest mall price) = 142,020

--> 950 * 60 + 1,200 (5th lowest mall price for scrumptious reagent) * 60 = 129,000

Which is still lower than 142,002, but we don't know what the current price for the reagents was when you did this.

I was able to do all of this manually later on, but I had already lost the meat to the mall.

Could this be fixed please?

Thanks.

I am not convinced there was a bug, that you "lost" meat in the mall, or that anything needs to be "fixed". You did not give enough information - in particular, the current mall price of the reagent - to determine.

I do have the question, though, whether we consider Travoltan trousers when calculating crafting costs that use NPC items.

 

[Veracity]

By the way - this thread seems related to the current report. Possibly related enough that they are probably the same issue and could be merged. I dunno. This one also mentions Travoltan trousers...

 

[Captain Kirk]

Each catalyst usage also consumes a scrumptious reagent.


--> 950 * 60 + 1,200 (5th lowest mall price for scrumptious reagent) * 60 = 129,000

Which is still lower than 142,002, but we don't know what the current price for the reagents was when you did this.


I am not convinced there was a bug, that you "lost" meat in the mall, or that anything needs to be "fixed". You did not give enough information - in particular, the current mall price of the reagent - to determine.

I do have the question, though, whether we consider Travoltan trousers when calculating crafting costs that use NPC items.

Well, this happened today, so I would assume your guess at reagent price is good.
Also, I tend to like to use ingredients I have on hand when crafting, so given that I have
tons of reagents in my inventory, I'd rather use them, then try to sell them when crafting.
(I realize there is no option to specify use ingredients on-hand if available).

 

[Winterbay]

Well, sort of. YOu can go to item manager - fine tuning and set things in inventory to "free" which should make that a more interesting option for Mafia.

 

[slyz]

I think there is something fishy going on. Trying to acquire a scrumdiddlyumptious solution with an AT multi with store access, with debugBuy on, I get this:

☯ delectable catalyst mall=2147483647 make=2147483647

 

[slyz]

I think I found the problem. It looks like NPC items like the delectable catalyst are considered only if they are already in your inventory

> buy 1 delectable catalyst

Purchasing delectable catalyst (1 @ 1,000)...
You acquire an item: delectable catalyst
You spent 1,000 Meat
Purchases complete.
Transferring items to store...
Items offered up for sale.

> acquire 1 scrumdiddlyumptious solution

☯ delectable catalyst onhand=799
☯ scrumptious reagent onhand=960
☯ delectable catalyst onhand=0
☯ scrumptious reagent onhand=960
☯ scrumdiddlyumptious solution mall=2367 make=960
Verifying ingredients for scrumdiddlyumptious solution (1)...
Creating scrumdiddlyumptious solution (1)...
You acquire an item: scrumdiddlyumptious solution

but since they have a mall price of 0, they aren't considered as a viable option when you don't have any.

EDIT: or maybe the delectable catalyst is a special case because it is not tradeable.

 

[slyz]

r10230 should fix this.

The problem was this check in StoreManager.getMallPrice( item ):

if ( item.getItemId() < 1 || !ItemDatabase.isTradeable( item.getItemId() ) )
{
	return 0;
}

where "mall price" also means NPC price where applicable.

This resulted in untradeable NPC items like the delectable catalyst being assigned a price of 0, whereas other (tradeable) NPC items would end up being assigned their NPC price:

> ash mall_price( $item[ tomato ] )

Returned: 70

> ash mall_price( $item[ delectable catalyst ] )

Returned: 0

With the change, only untradeable non-NPC items and untradeable NPC items you don't have access to will return a price of 0.

> acquire 1 scrumdiddlyumptious solution

☯ delectable catalyst mall=1000 make=2147483647
☯ scrumptious reagent mall=1200 make=2147483647
Searching for "scrumdiddlyumptious solution"...
Search complete.
☯ delectable catalyst mall=1000 make=2147483647
Searching for "scrumptious reagent"...
Search complete.
☯ scrumptious reagent mall=1269 make=2147483647
☯ scrumdiddlyumptious solution mall=2367 make=2269
☯ delectable catalyst mall=1000 make=2147483647
☯ scrumptious reagent mall=1269 make=2147483647
☯ delectable catalyst mall=1000 make=2147483647
☯ scrumptious reagent mall=1269 make=2147483647
☯ scrumdiddlyumptious solution mall=2367 make=2269
Verifying ingredients for scrumdiddlyumptious solution (1)...
Purchasing delectable catalyst (1 @ 1,000)...
You acquire an item: delectable catalyst
You spent 1,000 Meat
Purchases complete.
Using cached search results for scrumptious reagent...
Purchasing scrumptious reagent (1 @ 1,200)...
You acquire an item: scrumptious reagent
Purchases complete.
Creating scrumdiddlyumptious solution (1)...
You acquire an item: scrumdiddlyumptious solution
Successfully created scrumdiddlyumptious solution (1)

 

[Veracity]

Nice job! I knew there was a reason I hired you.

 

[Captain Kirk]

Thank you both slyz and Veracity, for the fix and not nuking the thread too quickly

 

[Bale]

Nice job! I knew there was a reason I hired you.

I thought you hired him because he works really cheap? With slyz you really get more than your money's worth out of him.