I've seen a good number of reports of people saying mafia turned off clover protection for them (here and here, plus in /hardcore and /clan). Individually they would sound like user error, but the frequency of it happening makes me think that there might actually be an issue.
Since mafia only changes that setting in one place (besides the settings window of course), that would point to InventoryManager.retrieveItem(), which was changed in 10516.
According to Veracity's post in this bug report, there were good reasons for that change.
Hopefully someone can look and easily tell that it can't be the cause, or can spot something simple to fix. I see that retrieveItem() calls doRetrieveItem() which I think can lead to another call of retrieveItem() sometimes, but the variables are only defined for that function so I would expect recursive calls to not cause a problem.
Since mafia only changes that setting in one place (besides the settings window of course), that would point to InventoryManager.retrieveItem(), which was changed in 10516.
According to Veracity's post in this bug report, there were good reasons for that change.
Hopefully someone can look and easily tell that it can't be the cause, or can spot something simple to fix. I see that retrieveItem() calls doRetrieveItem() which I think can lead to another call of retrieveItem() sometimes, but the variables are only defined for that function so I would expect recursive calls to not cause a problem.
