CanAdv -- check whether you can adventure at a given location

Theraze

Active member
Okay, with that, no more current missing zones for r16502.
> ash import <canadv.ash> foreach it in $locations[] can_adv(it);

Checking resistance to stench...
You can already resist stench.
Returned: void
 

fronobulax

Developer
Staff member
Confirming that as of r16506 there are no problematic locations except the machine tunnels which are New Content (and might have been fixed in r16507).
 
Unknown location: The SMOOCH Army HQ (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Velvet / Gold Mine (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: LavaCo™ Lamp Factory (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Bubblin' Caldera (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Ice Hotel (zone: The Glaciest)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: VYKEA (zone: The Glaciest)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027

??????? This seems incorrect. The svn update command tells me I'm at revision 72.
 

Darzil

Developer
The version I downloaded a couple of days don't seem to have these entries from the // always open if their zone is section.

case $location[The Secret Government Laboratory]:
case $location[The SMOOCH Army HQ]:
case $location[The Velvet / Gold Mine]:
case $location[LavaCo™ Lamp Factory]:
case $location[The Bubblin' Caldera]:
case $location[The Ice Hotel]:
case $location[VYKEA]:

case $location[The Ice Hole]: should be in there with a check for underwater adventuring
 

fronobulax

Developer
Staff member
Updating changes nothing.



I have tried every method I can think of to update this script, including deleting it and reinstalling it. Somehow I remain at revision 72.

Look for files named canadv.ash in the scripts and relay directory trees. Hopefully you will find more than one. If so uninstall candav from SVN, delete the versions that remain, and then reinstall from SVN. It sounds like the version you are actually running is not the version you updated.
 
Look for files named canadv.ash in the scripts and relay directory trees. Hopefully you will find more than one. If so uninstall candav from SVN, delete the versions that remain, and then reinstall from SVN. It sounds like the version you are actually running is not the version you updated.
I am also having this problem on a fresh install... using r72. :S

> ash import <canadv.ash> can_adv($location[VYKEA])
Unknown location: VYKEA (zone: The Glaciest)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Returned: false
 

xKiv

Active member
Latest on sourceforge is r72, which definitely can't handle VYKEA (at least; that's the only one I checked).

.. the commit for r69 says "Detect the Glaciest zones", but that's just "you can access the zone at all", isn't it? Fixing this one just allowed canadv to progress past "if you can't access to zone, don't bother checking if you can access the locations in it", exposing the lack of handling there.

(paragraph removed, because almost definitely wrong)
 
Last edited:
Yeah, I checked for extra copies of canadv.ash, and there weren't any.

And then, just to be sure, I went back and manually rechecked all those other zones, just in case it was actually mostly fixed and just VYKEA was missing. Nope.
 

fronobulax

Developer
Staff member
I deleted canadv, verified that there were no copies of canadv.ash anywhere, reinstalled, confirmed I had r72, ran and the only unknown location I got was the machine tube. Specifically VYKEA (zone: The Glaciest) is not unknown. I am running mafia r16552 in case there is a version dependency that has not been articulated.
 

xKiv

Active member
I deleted canadv, verified that there were no copies of canadv.ash anywhere, reinstalled, confirmed I had r72, ran and the only unknown location I got was the machine tube. Specifically VYKEA (zone: The Glaciest) is not unknown. I am running mafia r16552 in case there is a version dependency that has not been articulated.

Jsut to be sure ... do you actually have the cold charter (as far as mafia knows, so coldAirportAlways or _coldAirportToday)?
 
I deleted canadv, verified that there were no copies of canadv.ash anywhere, reinstalled, confirmed I had r72, ran and the only unknown location I got was the machine tube. Specifically VYKEA (zone: The Glaciest) is not unknown. I am running mafia r16552 in case there is a version dependency that has not been articulated.
Also running r16552 and r72 of CanAdv. Cannot reproduce your results.

Also checked coldAirportAlways, set it to true. Didn't help.
 

xKiv

Active member
Also checked coldAirportAlways, set it to true. Didn't help.

Having access to the charter is what triggers the "Unknown location: VYKEA (zone: The Glaciest)" message.
Not having access would simply return false.

ETA: which, well, Theraze's "it works" example returns false, so ...
 

fronobulax

Developer
Staff member
Having access to the charter is what triggers the "Unknown location: VYKEA (zone: The Glaciest)" message.
Not having access would simply return false.

ETA: which, well, Theraze's "it works" example returns false, so ...

Actually
having access to the charter is what triggers the "Unknown location: VYKEA (zone: The Glaciest)" message.
was not always true. There was a point at which the message was unconditionally generated. I reported it, it was "fixed" and the message went away for me. But I don't have access to the charter so...
 

Veracity

Developer
Staff member
Revision 72.

Just adding to the choir of bug reports:

Unknown location: The Deep Machine Tunnels (zone: Town)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Ruins of the Fully Automated Crimbo Factory (zone: Crimbo15)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The SMOOCH Army HQ (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Velvet / Gold Mine (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: LavaCo™ Lamp Factory (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Bubblin' Caldera (zone: That 70s Volcano)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Ice Hotel (zone: The Glaciest)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: VYKEA (zone: The Glaciest)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027
Unknown location: The Ice Hole (zone: The Glaciest)
Please report this missing location here: http://kolmafia.us/showthread.php?t=2027

> get coldAirportAlways

true

> get hotAirportAlways

true

> get sleazeAirportAlways

true

> get spookyAirportAlways

true

> get stenchAirportAlways

true
 
Top