Bug - Fixed Bunch of item data fixes

[Cool12309]

Multiusability:
goblin water is multiusable, but KoLmafia thought it was not
Huggler Radio is multiusable, but KoLmafia thought it was not
liquid ice is multiusable, but KoLmafia thought it was not

Plurals:
Unexpected plural of 'catfish whiskers' found: catfish whiskers
Unexpected plural of 'gourmet gourami oil' found: vails of gourmet gourami oil
Unexpected plural of 'pie man was not meant to eat' found: pies men were not meant to collectively eat

On a totally unrelated note, I bet you could fix all the multiusability issues (and maybe the plurals, though I don't know if you need 2 for that to work) if you have holder take everything out of his DC then place it back in

 

[heeheehee]

You can find plurals for non-quest items by trying to pull multiple of an item via /pull? 2 itemname.

 

[Bale]

Why is there a question mark after pull? How does that change the command? The wiki has "pull" and "pulls", but nothing for "pull?" Is that a typo?

 

[lostcalpolydude]

Why is there a question mark after pull? How does that change the command? The wiki has "pull" and "pulls", but nothing for "pull?" Is that a typo?

It works in KoL sort of like it does in mafia. You get to see what item would be picked, though KoL's message is more verbose and happens to include the plural.

 

[lostcalpolydude]

Added most of the stuff in 14521.

Huggler Radio is multiusable, but KoLmafia thought it was not

That's a weird one, didn't do anything with it yet.

 

[Cool12309]

Found these too while this thread is open:
Unexpected plural of 'French bronilla brogurt' found: cups of French bronilla brogurt
Unexpected plural of 'brocolate brogurt' found: cups of brocolate brogurt

 

[Veracity]

You can find plurals for non-quest items by trying to pull multiple of an item via /pull? 2 itemname.

Sweet. Hagnk just told me a whole bunch more plurals. Revision 14523

 

[Veracity]

Revision 14524 soups up the "checkplurals" command. That used to (and still does) compare KoLmafia's item of item plurals vs. the Wiki. Not something you want to run often, since it hits every (non-quest) item page on the Wiki! Perhaps we can repay them for that by fixes the (numerous) errors this data scraping showed up on the Wiki pages...

KoLmafia has a map of item id to plural. It's sparsely populated; not only do we not know the plural of all items, but if the plural is made by simply adding an "s" to the end of the item name, we don't need to enter it into the map, since if we look up the item and don't find it, we make the plural by doing exactly that. However, we do have a bunch of items in items.txt that explicitly list the default-form plural. I wish we hadn't done that.

I suggest the following as a first pass over the data file: remove all plurals that are simply item name + "s".

Then, we can use the output of "checkplurals", which I attach. I see bunches of all the following:

- KoLmafia is missing a plural, but the Wiki has what looks like a good plural.
- KoLmafia has what looks like a good plural, but the Wiki has none.
- KoLmafia has a "default" plural, but the Wiki's plural looks better.
- KoLmafia has a special plural, as does the Wiki, but they differ. It's not always clear which one is correct, although there are obvious typos in both sources.

Which is to say, it will take some actual thought to use this data correctly.

I'm about to go to bed and will not have time to look at this tomorrow. If anybody else wants to, please jump in.

Checking plurals...
*** El Sombrero De Lopez: KoLmafia plural = "Los Sombreros De Lopezes", Wiki plural = "El Sombrero De Lopezs"
*** Lord of the Flies-sized fries: KoLmafia plural = "Lords of the Flieses-sized fries", Wiki plural = "Lords of the Flieses-sized Fries"
*** Item #13: KoLmafia plural = "Items #13", Wiki plural = ""
*** skull of the Bonerdagon: KoLmafia plural = "skull of the Bonerdagons", Wiki plural = "skulls of the Bonerdagon"
*** Blatantly Canadian: KoLmafia plural = "Blatantly Canadians", Wiki plural = "bottles of Blatantly Canadian"
*** stainless steel suspenders: KoLmafia plural = "stainless steel suspenders", Wiki plural = "stainless steel suspenderss"
*** box of sunshine: KoLmafia plural = "boxen of sunshine", Wiki plural = "boxes of sunshine"
*** bowl of oriole's nest soup: KoLmafia plural = "bowl of oriole's nest soups", Wiki plural = "bowls of oriole's nest soup"
*** zmobie: KoLmafia plural = "zombeis", Wiki plural = ""
*** ultimate wad: KoLmafia plural = "Ultimate Wads", Wiki plural = "ultimate wads"
*** Gnomish toolbox: KoLmafia plural = "Gnomish toolboxs", Wiki plural = "Gnomish toolboxes"
*** Counterclockwise Watch: KoLmafia plural = "Counterclockwise Watches", Wiki plural = "Counterwatchwise Clocks"
*** Lockenstock™ sandals: KoLmafia plural = "Lockenstocken sandals", Wiki plural = "Lockenstocken Sandals"
*** flaming familiar doppelgänger: KoLmafia plural = "flaming familiar doppelgängers", Wiki plural = "flaming familiar doppelgänger"
*** Slow Talkin' Elliot's dogtags: KoLmafia plural = "pairs of Slow Talkin' Elliot's dogtags", Wiki plural = "Slow Talkin' Elliot's dogtagss"
*** wreath of laurels: KoLmafia plural = "wreath of laurelss", Wiki plural = "wreathes of laurels"
*** Manual of Transcendent Olfaction: KoLmafia plural = "Manuals of Transcendent Olfaction", Wiki plural = "Manual of Transcendent Olfaction"
*** black greaves: KoLmafia plural = "pairs of black greaves", Wiki plural = "black greavess"
*** frightful feather: KoLmafia plural = "frightful feathers", Wiki plural = "frightful feather"
*** tiny plastic The Big Wisniewski: KoLmafia plural = "tiny plastic plastic The Big Wisniewski", Wiki plural = "tiny plastic The Big Wisniewski"
*** gold lamé pants: KoLmafia plural = "pairs of gold lamé pants", Wiki plural = "gold lamé pantss"
*** Bulky Buddy Box: KoLmafia plural = "Bulky Buddy Boxen", Wiki plural = ""
*** overclocked avian microprocessor: KoLmafia plural = "overclocked avian microprocessor", Wiki plural = "overclocked avian microprocessors"
*** quasi-ethereal macaroni fragments: KoLmafia plural = "quasi-ethereal macaroni fragmentss", Wiki plural = "lots of quasi-ethereal macaroni fragments"
*** abandoned candy: KoLmafia plural = "abandoned candys", Wiki plural = "buckets of abandoned candy"
*** The Ballad of Richie Thingfinder: KoLmafia plural = "copies of The Ballad of Richie Thingfinder", Wiki plural = ""
*** Benetton's Medley of Diversity: KoLmafia plural = "copies of Benetton's Medley of Diversity", Wiki plural = ""
*** Elron's Explosive Etude: KoLmafia plural = "copies of Elron's Explosive Etude", Wiki plural = ""
*** Chorale of Companionship: KoLmafia plural = "copies of Chorale of Companionship", Wiki plural = ""
*** Prelude of Precision: KoLmafia plural = "copies of Prelude of Precision", Wiki plural = ""
*** Hodgman's journal #1: The Lean Times: KoLmafia plural = "copies of Hodgman's journal #1", Wiki plural = ""
*** Hodgman's journal #2: Entrepreneurythmics: KoLmafia plural = "copies of Hodgman's journal #2", Wiki plural = ""
*** Hodgman's journal #3: Pumping Tin: KoLmafia plural = "copies of Hodgman's journal #3", Wiki plural = ""
*** Hodgman's journal #4: View From The Big Top: KoLmafia plural = "copies of Hodgman's journal #4", Wiki plural = ""
*** little box of fireworks: KoLmafia plural = "little box of fireworkss", Wiki plural = "little boxes of fireworks"
*** sterno-flavored Hob-O: KoLmafia plural = "sterno-flavored Hob-O", Wiki plural = "sterno-flavored Hob-Os"
*** rusty compass: KoLmafia plural = "rusty compassses", Wiki plural = "rusty compasses"
*** pair of ragged claws: KoLmafia plural = "pair of ragged clawss", Wiki plural = "pairs of ragged claws"
*** elven limbos gingerbread: KoLmafia plural = "wafers of limbos gingerbread", Wiki plural = ""
*** tiny plastic mutant elf: KoLmafia plural = "tiny plastic mutant elfs", Wiki plural = "tiny plastic mutant elves"
*** tiny plastic fat stack of cash: KoLmafia plural = "tiny plastic fat stack of cashs", Wiki plural = "tiny plastic fat stacks of cash"
*** tiny plastic strand of DNA: KoLmafia plural = "tiny plastic strand of DNAs", Wiki plural = "tiny plastic strands of DNA"
*** tiny plastic chunk of depleted Grimacite: KoLmafia plural = "tiny plastic chunk of depleted Grimacites", Wiki plural = "tiny plastic chunks of depleted Grimacite"
*** teflon swim fins: KoLmafia plural = "pairs of teflon swim fins", Wiki plural = "teflon swim finss"
*** anniversary balsa wood socks: KoLmafia plural = "pairs of anniversary balsa wood socks", Wiki plural = "pairs of anniversary balsa wood socks (which you r"
*** Mer-kin sawdust: KoLmafia plural = "Mer-kin sawdusts", Wiki plural = "bags of Mer-kin sawdust"
*** Annual Ascot: KoLmafia plural = "Annual Ascots", Wiki plural = "I am a fish"
*** throwing wrench: KoLmafia plural = "throwing wrenches", Wiki plural = "throwing wrenchs"
*** The Art of Slapfighting: KoLmafia plural = "copies of The Art of Slapfighting", Wiki plural = "copies of the Art of Slapfighting"
*** Inigo's Incantation of Inspiration: KoLmafia plural = "copies of Inigo's Incantation of Inspiration", Wiki plural = ""
*** puzzling trophy: KoLmafia plural = "puzzling trophys", Wiki plural = "puzzling trophies"
*** BRICKO octopus: KoLmafia plural = "BRICKO octopodes", Wiki plural = ""
*** Vial of jus de larmes: KoLmafia plural = "vials of jus de larmes", Wiki plural = ""
*** Lobster qua Grill: KoLmafia plural = "pieces of Lobster qua Grill", Wiki plural = ""
*** left parenthesis: KoLmafia plural = "left parenthesiss", Wiki plural = "left parentheses"
*** right parenthesis: KoLmafia plural = "right parenthesiss", Wiki plural = "right parentheses"
*** pixel whip: KoLmafia plural = "pixel whip", Wiki plural = "pixel whips"
*** bottle of Goldschnöckered: KoLmafia plural = "bottle of Goldschnöckereds", Wiki plural = "bottles of Goldschnöckered"
*** super-sweet boom box: KoLmafia plural = "super-sweet boom boxs", Wiki plural = "super-sweet boom boxes"
*** Space Trip safety headphones: KoLmafia plural = "Space Trip safety headphoness", Wiki plural = "pairs of official Space Trip headphones"
*** Ellsbury's skull: KoLmafia plural = "Ellsbury's skulls", Wiki plural = "skulls of Ellsbury"
*** booze-soaked cherry: KoLmafia plural = "booze-soaked cherrys", Wiki plural = "booze-soaked cherries"
*** sponge cake: KoLmafia plural = "sponge cakes", Wiki plural = "slabs of sponge cake"
*** gin-soaked blotter paper: KoLmafia plural = "gin-soaked blotter papers", Wiki plural = "sheets of gin-soaked blotter paper"
*** pottery training pants: KoLmafia plural = "pottery training pantss", Wiki plural = "pairs of pottery training pants"
*** fossilized bat skull: KoLmafia plural = "fossilized bat skulls", Wiki plural = "fossilized bat skulls."
*** affordable teak perch: KoLmafia plural = "affordable teak perchs", Wiki plural = "affordable teak perches"
*** kitty sheet music: KoLmafia plural = "pages of kitty sheet music", Wiki plural = "Pages of kitty sheet music"
*** Essence of Annoyance: KoLmafia plural = "Essence of Annoyances", Wiki plural = "flask of Essence of Annoyance"
*** tiny plastic hobo elf: KoLmafia plural = "tiny plastic hobo elfs", Wiki plural = "tiny plastic hobo elves"
*** robot reindeer protocol D.O.N.N.E.R.: KoLmafia plural = "D.O.N.N.E.R. disks", Wiki plural = "D.O.N.N.E.R disks"
*** Uncle Hobo's gift baggy pants: KoLmafia plural = "Uncle Hobo's gift baggy pantss", Wiki plural = "pairs of gift baggy pants"
*** Uncle Hobo's fingerless tinsel gloves: KoLmafia plural = "Uncle Hobo's fingerless tinsel glovess", Wiki plural = "pairs of fingerless tinsel gloves"
*** gift-a-pult: KoLmafia plural = "gift-a-pults", Wiki plural = "gifts-a-pults"
*** holly-flavored Hob-O: KoLmafia plural = "holly-flavored Hob-Os", Wiki plural = "holly-flavored Hob-O"
*** paperclip sproinger: KoLmafia plural = "paperclip sproingers", Wiki plural = "paperclip sproingers."
*** Loathing Legion knife: KoLmafia plural = "Loathing Legion knifes", Wiki plural = "Loathing Legion knives"
*** Loathing Legion rollerblades: KoLmafia plural = "Loathing Legion rollerbladess", Wiki plural = "pairs of Loathing Legion rollerblades"
*** Loathing Legion abacus: KoLmafia plural = "Loathing Legion abacuss", Wiki plural = "Loathing Legion abacusses"
*** flimsy clipboard: KoLmafia plural = "flimsy clipboards", Wiki plural = "flimsy clipboard"
*** Knob nuts: KoLmafia plural = "pairs of Knob Nuts", Wiki plural = "pairs of Knob nuts"
*** Alice's Army Foil Lanceman: KoLmafia plural = "Alice's Army Foil Lancemen", Wiki plural = "Alice's Army Foil Lancermen"
*** creepy voodoo doll: KoLmafia plural = "creepy voodoo dolls", Wiki plural = "Creepy voodoo dolls"
*** Jeppson's Malort: KoLmafia plural = "Jeppson's Malorts", Wiki plural = "bottles of Jeppson's Malort"
*** mirrored aviator shades: KoLmafia plural = "mirrored aviator shadess", Wiki plural = "pairs of mirrored aviator shades"
*** plush alielf: KoLmafia plural = "plush alielfs", Wiki plural = "plush alielves"
*** plush hamsterpus: KoLmafia plural = "plush hamsterpuss", Wiki plural = "plush hamsterpi"
*** plush ferrelf: KoLmafia plural = "plush ferrelfs", Wiki plural = "plush ferrelves"
*** plush alien hamsterpus: KoLmafia plural = "plush alien hamsterpuss", Wiki plural = "plush alien hamsterpi"
*** plush mutated alielf: KoLmafia plural = "plush mutated alielfs", Wiki plural = "plush mutated alielves"
*** Crimbo paste: KoLmafia plural = "globs of crimbo paste", Wiki plural = "globs of Crimbo paste"
*** forbidden danish: KoLmafia plural = "forbidden danished", Wiki plural = "forbidden danishes"
*** hammerus: KoLmafia plural = "hammeruss", Wiki plural = "hammurabi"
*** slightly thicker filthy rags: KoLmafia plural = "slightly thicker filthy ragss", Wiki plural = "piles of slightly thicker filthy rags"
*** plastic vampire fangs: KoLmafia plural = "plastic vampire fangss", Wiki plural = "sets of plastic vampire fangs"
*** Bone's Farm "wine": KoLmafia plural = "bottles of Bone's Farm "wine"", Wiki plural = "bottles of Bone's Farm "wine""
*** The Necbronomicon (used): KoLmafia plural = "The Necbronomicon (used)s", Wiki plural = "used copies of The Necbronomicon"
*** sorority girl's box: KoLmafia plural = "sorority girl's boxess", Wiki plural = "sorority girl's boxes"
*** A Crimbo Carol, Ch. 1 (used): KoLmafia plural = "A Crimbo Carol, Ch. 1 (used)s", Wiki plural = "used copies of A Crimbo Carol, Ch. 1"
*** A Crimbo Carol, Ch. 2 (used): KoLmafia plural = "A Crimbo Carol, Ch. 2 (used)s", Wiki plural = "used copies of A Crimbo Carol, Ch. 2"
*** A Crimbo Carol, Ch. 3 (used): KoLmafia plural = "A Crimbo Carol, Ch. 3 (used)s", Wiki plural = "used copies of A Crimbo Carol, Ch. 3"
*** A Crimbo Carol, Ch. 4 (used): KoLmafia plural = "A Crimbo Carol, Ch. 4 (used)s", Wiki plural = "used copies of A Crimbo Carol, Ch. 4"
*** A Crimbo Carol, Ch. 5 (used): KoLmafia plural = "A Crimbo Carol, Ch. 5 (used)s", Wiki plural = "used copies of A Crimbo Carol, Ch. 5"
*** A Crimbo Carol, Ch. 6 (used): KoLmafia plural = "A Crimbo Carol, Ch. 6 (used)s", Wiki plural = "used copies of A Crimbo Carol, Ch. 6"
*** The Art of Slapfighting (used): KoLmafia plural = "The Art of Slapfighting (used)s", Wiki plural = "used copies of the Art of Slapfighting"
*** Uncle Romulus (used): KoLmafia plural = "Uncle Romulus (used)s", Wiki plural = "used copies of Uncle Romulus"
*** A Beginner's Guide to Charming Snakes (used): KoLmafia plural = "A Beginner's Guide to Charming Snakes (used)s", Wiki plural = "used copies of A Beginner's Guide to Charming Snak"
*** Zu Mannkäse Dienen (used): KoLmafia plural = "Zu Mannkäse Dienen (used)s", Wiki plural = "used copies of Zu Mannkäse Dienen"
*** Autobiography Of Dynamite Superman Jones (used): KoLmafia plural = "Autobiography Of Dynamite Superman Jones (used)s", Wiki plural = "used Autobiographies Of Dynamite Superman Jones"
*** Inigo's Incantation of Inspiration (crumpled): KoLmafia plural = "Inigo's Incantation of Inspiration (crumpled)s", Wiki plural = "crumpled copies of Inigo's Incantation of Inspirat"
*** Tales of a Kansas Toymaker (used): KoLmafia plural = "Tales of a Kansas Toymaker (used)s", Wiki plural = "used copies of Tales of a Kansas Toymaker"
*** The Joy of Wassailing (used): KoLmafia plural = "The Joy of Wassailing (used)s", Wiki plural = "used copies of The Joy of Wassailing"
*** CRIMBCO Employee Handbook (chapter 1) (used): KoLmafia plural = "CRIMBCO Employee Handbook (chapter 1) (used)s", Wiki plural = "CRIMBCO Employee Handbooks (chapter 1) (used)"
*** CRIMBCO Employee Handbook (chapter 2) (used): KoLmafia plural = "CRIMBCO Employee Handbook (chapter 2) (used)s", Wiki plural = "CRIMBCO Employee Handbooks (chapter 2) (used)"
*** CRIMBCO Employee Handbook (chapter 3) (used): KoLmafia plural = "CRIMBCO Employee Handbook (chapter 3) (used)s", Wiki plural = "CRIMBCO Employee Handbooks (chapter 3) (used)"
*** CRIMBCO Employee Handbook (chapter 4) (used): KoLmafia plural = "CRIMBCO Employee Handbook (chapter 4) (used)s", Wiki plural = "CRIMBCO Employee Handbooks (chapter 4) (used)"
*** CRIMBCO Employee Handbook (chapter 5) (used): KoLmafia plural = "CRIMBCO Employee Handbook (chapter 5) (used)s", Wiki plural = "CRIMBCO Employee Handbooks (chapter 5) (used)"
*** Ellsbury's journal (used): KoLmafia plural = "Ellsbury's journal (used)s", Wiki plural = "used copies of Ellsbury's journal"
*** peppermint rhino baby: KoLmafia plural = "peppermint rhino babys", Wiki plural = "peppermint rhino babies"
*** sucker hakama: KoLmafia plural = "sucker hakamas", Wiki plural = "pairs of sucker hakama"
*** Libram of Resolutions: KoLmafia plural = "Librams of Resolutions", Wiki plural = "Libram of Resolutionss"
*** gummi canary: KoLmafia plural = "gummi canarys", Wiki plural = "gummi canaries"
*** lollipop cufflinks: KoLmafia plural = "lollipop cufflinkss", Wiki plural = "sets of lollipop cufflinks"
*** Trivial Avocations Card: What?: KoLmafia plural = "Trivial Avocations Cards: What?", Wiki plural = ""
*** Trivial Avocations Card: When?: KoLmafia plural = "Trivial Avocations Cards: When?", Wiki plural = ""
*** Trivial Avocations Card: Who?: KoLmafia plural = "Trivial Avocations Cards: Who?", Wiki plural = ""
*** Trivial Avocations Card: Where?: KoLmafia plural = "Trivial Avocations Cards: Where?", Wiki plural = ""
*** pog #01 (spider): KoLmafia plural = "pog #01s (spider)", Wiki plural = ""
*** pog #02 (Knob goblin): KoLmafia plural = "pog #02s (Knob goblin)", Wiki plural = ""
*** pog #03 (warwelf): KoLmafia plural = "pog #03s (warwelf)", Wiki plural = ""
*** pog #04 (skleleton): KoLmafia plural = "pog #04s (skleleton)", Wiki plural = ""
*** pog #05 (ninja snowman): KoLmafia plural = "pog #05s (ninja snowman)", Wiki plural = ""
*** pog #06 (filthy hippy): KoLmafia plural = "pog #06s (filthy hippy)", Wiki plural = ""
*** pog #07 (orcish frat boy): KoLmafia plural = "pog #07s (orcish frat boy)", Wiki plural = ""
*** pog #08 (hellion): KoLmafia plural = "pog #08s (hellion)", Wiki plural = ""
*** pog #09 (pirate): KoLmafia plural = "pog #09s (pirate)", Wiki plural = ""
*** pog #10 (hobo): KoLmafia plural = "pog #10s (hobo)", Wiki plural = ""
*** pog #11 (Naughty Sorceress): KoLmafia plural = "pog #11s (Naughty Sorceress)", Wiki plural = ""
*** Leapin' Trousers: KoLmafia plural = "Leapin' Trouserss", Wiki plural = "I Am A Fish"
*** PB&BP: KoLmafia plural = "PB&BPs", Wiki plural = "PB&BPs"
*** Drac & Tan: KoLmafia plural = "Dracs & Tans", Wiki plural = "Dracs & Tans"
*** Humanitini: KoLmafia plural = "Humanitinis", Wiki plural = "Humanitinii"
*** Dark & Starry: KoLmafia plural = "Dark & Starries", Wiki plural = "Dark & Starries"
*** Small Medium: KoLmafia plural = "Small Mediums", Wiki plural = "Small Media"
*** Boris's Helm (askew): KoLmafia plural = "Boris's Helm (askew)s", Wiki plural = "Boris's Askew Helms"
*** How to Tolerate Jerks: KoLmafia plural = "How to Tolerate Jerkss", Wiki plural = "copies of How to Tolerate Jerks"
*** How to Hold a Grudge: KoLmafia plural = "How to Hold a Grudges", Wiki plural = "copies of How to Hold a Grudge"
*** handful of juicy garbage: KoLmafia plural = "handfuls of juicy garbage", Wiki plural = "handful of juicy garbages"
*** Hjodor's Guide to Arctic Dalmatians (used): KoLmafia plural = "Hjodor's Guide to Arctic Dalmatians (used)s", Wiki plural = "copies of Hjodor's Guide to Arctic Dalmatians"
*** forbidden sausage: KoLmafia plural = "forbidden danishes", Wiki plural = "forbidden sausages"
*** Drizzlers™ Black Licorice: KoLmafia plural = "Drizzlers™ Black Licorices", Wiki plural = "packs of Drizzlers™"
*** Staff of Holiday Sensations: KoLmafia plural = "Staff of Holiday Sensationss", Wiki plural = "Staves of Holiday Sensations"
*** Superhero Reboots: KoLmafia plural = "Superhero Rebootss", Wiki plural = "pairs of Superhero Reboots"
*** papier-mâché toothpicks: KoLmafia plural = "papier-mâché toothpickss", Wiki plural = "pairs of papier-mâché toothpicks"
*** papier-mâchuridars: KoLmafia plural = "papier-mâchuridarss", Wiki plural = "pairs of papier-mâchuridars"
*** Pete & Jackie's Dragon Tooth Emporium Catalog: KoLmafia plural = "Pete & Jackie's Dragon Tooth Emporium Catalogs", Wiki plural = "Pete & Jackie's Dragon Tooth Emporium Catalogs"
*** dreaming Jung man: KoLmafia plural = "dreaming Jung mans", Wiki plural = "dreaming Jung men"
*** avatar of the Unconscious Collective: KoLmafia plural = "avatar of the Unconscious Collectives", Wiki plural = "avatars of the Unconscious Collective"
*** Solstice Shield: KoLmafia plural = "Solstice Shields", Wiki plural = "I am a fish"
*** tiny plastic ChibiBuddy™: KoLmafia plural = "tiny plastic ChibiBuddy™s", Wiki plural = "tiny plastic ChibiBuddies™"
*** tiny plastic taco-clad Crimbo elf: KoLmafia plural = "tiny plastic taco-clad Crimbo elfs", Wiki plural = "tiny plastic taco-clad Crimbo elves"
*** tiny plastic Uncle Crimboku: KoLmafia plural = "tiny plastic Uncle Crimbokus", Wiki plural = "tiny plastic Uncle Crimboku"
*** tiny plastic MechaElf: KoLmafia plural = "tiny plastic MechaElfs", Wiki plural = "tiny plastic MechaElves"
*** tiny plastic beebee gunners: KoLmafia plural = "tiny plastic beebee gunnerss", Wiki plural = "tiny plastic beebee gunners"
*** electronic dulcimer pants: KoLmafia plural = "electronic dulcimer pantss", Wiki plural = "pairs of electronic dulcimer pants"
*** record of infuriating silence: KoLmafia plural = "record of infuriating silences", Wiki plural = "records of infuriating silence"
*** record of infuriating silence (used): KoLmafia plural = "record of infuriating silence (used)s", Wiki plural = "records of infuriating silence (used)"
*** record of tranquil silence: KoLmafia plural = "record of tranquil silences", Wiki plural = "records of tranquil silence"
*** record of tranquil silence (used): KoLmafia plural = "record of tranquil silence (used)s", Wiki plural = "records of tranquil silence (used)"
*** record of menacing silence: KoLmafia plural = "record of menacing silences", Wiki plural = "records of menacing silence"
*** record of menacing silence (used): KoLmafia plural = "record of menacing silence (used)s", Wiki plural = "records of menacing silence (used)"
*** screwing pooch: KoLmafia plural = "screwing poochs", Wiki plural = "screwing pooches"
*** wad of spider silk: KoLmafia plural = "wad of spider silks", Wiki plural = "wads of spider silk"
*** Thinknerd's Grimoire of Geeky Gifts: KoLmafia plural = "Thinknerd's Grimoire of Geeky Giftss", Wiki plural = "Thinknerd's Grimoires of Geeky Gifts"
*** Thinknerd T-Shirt: KoLmafia plural = "Thinknerd T-Shirts", Wiki plural = "Thinknerd T-shirts"
*** pile of useless robot parts: KoLmafia plural = "pile of useless robot partss", Wiki plural = "piles of useless robot parts"
*** brass abacus: KoLmafia plural = "brass abacuss", Wiki plural = "brass abaci"
*** magical battery: KoLmafia plural = "magical batterys", Wiki plural = "magical batteries"
*** butterfly knife: KoLmafia plural = "butterfly knifes", Wiki plural = "butterfly knives"
*** Deactivated MiniMechaElf: KoLmafia plural = "Deactivated MiniMechaElfs", Wiki plural = "Deactivated MiniMechaElves"
*** foam naval trousers: KoLmafia plural = "foam naval trouserss", Wiki plural = "pairs of foam naval trousers"
*** candy crayons: KoLmafia plural = "candy crayonss", Wiki plural = "packs of candy crayons"
*** ectoplasm au jus: KoLmafia plural = "bottles of ectoplasm au jus", Wiki plural = ""
*** single swig of vodka: KoLmafia plural = "single swigs of vodka", Wiki plural = "multiple swigs of vodka"
*** KoLHS Pep Squad Box: KoLmafia plural = "KoLHS Pep Squad Boxs", Wiki plural = "KoLHS Pep Squad Boxes"
*** twist of lime: KoLmafia plural = "twist of limes", Wiki plural = "twists of lime"
*** dreadful sweater: KoLmafia plural = "dreadful sweater", Wiki plural = "dreadful sweaters"
*** Warms-Your-Tush: KoLmafia plural = "Warms-Your-Tushs", Wiki plural = "Warm-Your-Tushes"
*** Protects-Your-Junk: KoLmafia plural = "Protects-Your-Junks", Wiki plural = "Protect-Your-Junks"
*** Great Wolf's beastly trousers: KoLmafia plural = "Great Wolf's beastly trouserss", Wiki plural = "pairs of Great Wolf's beastly trousers"
*** Great Wolf's lice: KoLmafia plural = "Great Wolf's lices", Wiki plural = "Great Wolf's lice"
*** zombie mariachi pants: KoLmafia plural = "zombie mariachi pantss", Wiki plural = "pairs of zombie mariachi pants"
*** HOA zombie eyes: KoLmafia plural = "HOA zombie eyess", Wiki plural = "pairs of HOA zombie eyes"
*** Mayor Ghost's khakis: KoLmafia plural = "Mayor Ghost's khakiss", Wiki plural = "pairs of Mayor Ghost's khakis"
*** Mayor Ghost's sash: KoLmafia plural = "Mayor Ghost's sashs", Wiki plural = "Mayor Ghost's sashes"
*** Mayor Ghost's scissors: KoLmafia plural = "Mayor Ghost's scissorss", Wiki plural = "pairs of Mayor Ghost's scissors"
*** Drunkula's silky pants: KoLmafia plural = "Drunkula's silky pantss", Wiki plural = "pairs of Drunkula's silky pants"
*** Drunkula's ring of haze: KoLmafia plural = "Drunkula's ring of hazes", Wiki plural = "Drunkula's rings of haze"
*** Drunkula's wineglass: KoLmafia plural = "Drunkula's wineglasss", Wiki plural = "Drunkula's wineglasses"
*** bottle of Bloodweiser: KoLmafia plural = "bottle of Bloodweisers", Wiki plural = "bottles of Bloodweiser"
*** Unkillable Skeleton's shinguards: KoLmafia plural = "Unkillable Skeleton's shinguardss", Wiki plural = "pairs of Unkillable Skeleton's shinguards"
*** shiny brass tailfeathers: KoLmafia plural = "shiny brass tailfeatherss", Wiki plural = "sets of shiny brass tailfeathers"
*** hangman's hood: KoLmafia plural = "hangman's hoods", Wiki plural = "hangmens' hoods"
*** Dreadsylvanian hot toddy: KoLmafia plural = "Dreadsylvanian hot toddys", Wiki plural = "Dreadsylvanian hot toddies"
*** Dreadsylvanian dank and stormy: KoLmafia plural = "Dreadsylvanian dank and stormys", Wiki plural = "Dreadsylvanian dank and stormies"
*** dreadful box: KoLmafia plural = "dreadful boxs", Wiki plural = "dreadful boxes"
*** Clan hot dog stand: KoLmafia plural = "Clan hot dog stand", Wiki plural = "Clan hot dog stands"
*** jar of frostigkraut: KoLmafia plural = "jar of frostigkrauts", Wiki plural = "jars of frostigkraut"
*** over-the-shoulder Folder Holder: KoLmafia plural = "over-the-shoulders Folder Holders", Wiki plural = "over-the-shoulders Folders Holders"
*** fountain 'soda': KoLmafia plural = "'fountain' sodas", Wiki plural = "'fountain' sodas"
*** Cursed Punch: KoLmafia plural = "cups of Cursed Punch", Wiki plural = "Cups of Cursed Punch"
*** Shore Inc. Ship Trip Scrip: KoLmafia plural = "Shore Inc. Ship Trip Scrips", Wiki plural = "Shore Inc. Ship Trip Scrip"
*** eternal car battery: KoLmafia plural = "eternal car batterys", Wiki plural = "eternal car batteries"
*** junk trunks: KoLmafia plural = "junk trunkss", Wiki plural = "pairs of junk trunks"
*** liquid bread: KoLmafia plural = "liquid breads", Wiki plural = "glasses of liquid bread"
*** flask of embalming fluid: KoLmafia plural = "flask of embalming fluids", Wiki plural = "flasks of embalming fluid"
*** mama's squeezebox: KoLmafia plural = "mama's squeezeboxs", Wiki plural = "mama's squeezeboxes"
*** bag of W&Ws: KoLmafia plural = "bags of W&Ws", Wiki plural = "bags of W&Ws"
*** little red jam: KoLmafia plural = "little red jams", Wiki plural = "jars of little red jam"
*** vial of blood simple syrup: KoLmafia plural = "vial of blood simple syrups", Wiki plural = "vials of blood simple syrup"
*** bone bons: KoLmafia plural = "bone bonss", Wiki plural = "handfuls of bone bons"
*** huge bowl of candy: KoLmafia plural = "huge bowl of candys", Wiki plural = "huge bowls of candy"
*** a suspicious address: KoLmafia plural = "a suspicious addresss", Wiki plural = "suspicious addresss"
*** Pantsgiving: KoLmafia plural = "Pantsgivings", Wiki plural = "pairs of Pantsgiving"
*** spirit gum: KoLmafia plural = "sticks of spirit gum", Wiki plural = "spirit gums"
*** spirit mattress: KoLmafia plural = "spirit mattresses", Wiki plural = "spirit mattresss"
*** Can of Spaghetto: KoLmafia plural = "Can of Spaghettos", Wiki plural = "Cans of Spaghetto"
*** Chef Boy, R&D's business card: KoLmafia plural = "Chef Boy, R&D's business cards", Wiki plural = "Chef Boy, R&D's business cards"
*** flask flops: KoLmafia plural = "flask flopss", Wiki plural = "flasks flops"
*** tiny plastic warbear fortress: KoLmafia plural = "tiny plastic warbear fortresss", Wiki plural = "tiny plastic warbear fortresses"
*** tiny plastic K.R.A.M.P.U.S.: KoLmafia plural = "tiny plastic K.R.A.M.P.U.S.s", Wiki plural = "tiny plastic K.R.A.M.P.U.S.es"
*** warbear energy bracers: KoLmafia plural = "warbear energy bracerss", Wiki plural = "pairs of warbear energy bracers"
*** warbear jackhammer drill press: KoLmafia plural = "warbear jackhammer drill presss", Wiki plural = "warbear jackhammer drill presses"
*** tiny die-cast goose a-laying: KoLmafia plural = "tiny die-cast goose a-layings", Wiki plural = "tiny die-cast geese a-laying"
*** tiny die-cast swarm a-swarming: KoLmafia plural = "tiny die-cast swarm a-swarmings", Wiki plural = "tiny die-cast swarms a-swarming"
*** tiny die-cast blade a-spinning: KoLmafia plural = "tiny die-cast blade a-spinnings", Wiki plural = "tiny die-cast blades a-spinning"
*** warbear black box: KoLmafia plural = "warbear black boxs", Wiki plural = "warbear black boxes"
*** grimstone galoshes: KoLmafia plural = "grimstone galoshess", Wiki plural = "pairs of grimstone galoshes"
*** packet of winter seeds: KoLmafia plural = "packet of winter seedss", Wiki plural = "packets of winter seeds"
*** snow cleats: KoLmafia plural = "snow cleatss", Wiki plural = "pairs of snow cleats"
*** warbear dress bracers: KoLmafia plural = "warbear dress bracerss", Wiki plural = "pairs of warbear dress bracers"
*** warbear dress greaves: KoLmafia plural = "warbear dress greavess", Wiki plural = "pairs of warbear dress greaves"
*** sour powder: KoLmafia plural = "sour powders", Wiki plural = "piles of sour powder"
*** lemonhead caviar: KoLmafia plural = "lemonhead caviars", Wiki plural = "piles of lemonhead caviar"
*** witch's bread: KoLmafia plural = "witch's breads", Wiki plural = "slices of witch's bread"
*** Rümpelstiltz: KoLmafia plural = "Rümpelstiltzs", Wiki plural = "bottles of Rümpelstiltz"
*** polo trophy: KoLmafia plural = "polo trophys", Wiki plural = "polo trophies"
*** fire hose: KoLmafia plural = "fire hoses", Wiki plural = "pairs of fire hose"
*** lynyrdskin breeches: KoLmafia plural = "lynyrdskin breechess", Wiki plural = "pairs of lynyrdskin breeches"
*** jug of Sneaky Pete's Mojo: KoLmafia plural = "jug of Sneaky Pete's Mojos", Wiki plural = "jugs of Sneaky Pete's Mojo"
*** Sneaky Pete's leather jacket (collar popped): KoLmafia plural = "Sneaky Pete's leather jacket (collar popped)s", Wiki plural = "Sneaky Pete's leather jackets (collar popped)"
*** robot grease: KoLmafia plural = "robot greases", Wiki plural = "globs of robot grease"
*** wind-up vampire teeth: KoLmafia plural = "wind-up vampire teeths", Wiki plural = "sets of wind-up vampire teeth"
*** elevennis shoes: KoLmafia plural = "elevennis shoess", Wiki plural = "pairs of elevennis shoes"
*** ghost of a necklace: KoLmafia plural = "ghost of a necklaces", Wiki plural = "ghosts of necklaces"
*** haunted battery: KoLmafia plural = "haunted batterys", Wiki plural = "haunted batteries"
*** ancient oil painting of yourself: KoLmafia plural = "ancient oil painting of yourselfs", Wiki plural = "ancient oil paintings of yourself"
*** deluxe layer cake: KoLmafia plural = "deluxe layer cakes", Wiki plural = "deluxe layer cake"
*** Pendant of Gargalesis: KoLmafia plural = "Pendant of Gargalesiss", Wiki plural = "Pendants of Gargalesis"
*** Taco Dan's Super Taco-Riffic Taco Sauce!: KoLmafia plural = "Taco Dan's Super Taco-Riffic Taco Sauce!s", Wiki plural = "bottles of Taco Dan's Super Taco-Riffic Taco Sauce"
*** regular-size brogurt: KoLmafia plural = "cups of regular-size brogurt", Wiki plural = "regular-size cups of Brogurt"
*** super-size brogurt: KoLmafia plural = "cups of super-size brogurt", Wiki plural = "super-size cups of brogurt"
*** Sloppy Seconds Diner Employee Handbook: KoLmafia plural = "copies of Sloppy Seconds Diner Employee Handbook", Wiki plural = "copies of the Sloppy Seconds Diner Employee Handbo"
*** Yolo™ chocolates: KoLmafia plural = "Yolo™ chocolatess", Wiki plural = "Yolo™ chocolates"
*** space beast fur pants: KoLmafia plural = "space beast fur pantss", Wiki plural = "pairs of space beast fur pants"
*** Chroner: KoLmafia plural = "Chroner", Wiki plural = "Chroners"
*** Time Lord Badge of Honor: KoLmafia plural = "Time Lord Badge of Honors", Wiki plural = "Time Lord Badges of Honor"
*** Time Bandit Badge of Courage: KoLmafia plural = "Time Bandit Badge of Courages", Wiki plural = "Time Bandit Badges of Courage"
*** solid shifting time weirdness: KoLmafia plural = "solid shifting time weirdnesss", Wiki plural = "solid shifting time weirdnesses"
*** steampunk potion: KoLmafia plural = "steampunk potions", Wiki plural = "bottles of steampunk potion"
*** bubblin' chemistry solution: KoLmafia plural = "bubblin' chemistry solutions", Wiki plural = "beakers of bubblin' chemistry solution"
*** button rouge: KoLmafia plural = "button rouges", Wiki plural = "tins of button rouge"
*** goblin water: KoLmafia plural = "goblin waters", Wiki plural = "jars of goblin water"
*** dumb mud: KoLmafia plural = "dumb muds", Wiki plural = "globs of dumb mud"
*** Sogg-Os: KoLmafia plural = "Sogg-Oss", Wiki plural = "bowls of Sogg-Os"
*** Lord Soggyraven's Slippers: KoLmafia plural = "Lord Soggyraven's Slipperss", Wiki plural = "pairs of Lord Soggyraven's Slippers"
*** Ancient Protector Soda: KoLmafia plural = "Ancient Protector Sodas", Wiki plural = "cans of Ancient Protector Soda"
*** hep waders: KoLmafia plural = "pairs of hep waders", Wiki plural = "hep waders"
*** dog ointment: KoLmafia plural = "dog ointments", Wiki plural = "tubes of dog ointment"
*** plastic nunchaku: KoLmafia plural = "plastic nunchakus", Wiki plural = "plastic nunchaku"
*** chewable paper: KoLmafia plural = "chewable papers", Wiki plural = "pieces of chewable paper"
*** rubber nubbin: KoLmafia plural = "rubber nubbins", Wiki plural = "rubber nubbins (but I hardly know her!)"
*** candy UFOs: KoLmafia plural = "candy UFOss", Wiki plural = "handfuls of candy UFOs"
*** water wings for babies: KoLmafia plural = "water wings for babiess", Wiki plural = "pairs of water wings for babies"
*** Strix stix: KoLmafia plural = "Strix stixs", Wiki plural = "Strix stix"
*** non-aged vinegar: KoLmafia plural = "non-aged vinegars", Wiki plural = "bottles of non-aged vinegar"
*** gladiator tunica: KoLmafia plural = "gladiator tunicas", Wiki plural = "gladiator tunicae"
*** Roman sadnals: KoLmafia plural = "Roman sadnalss", Wiki plural = "pairs of Roman sadnals"
*** madius: KoLmafia plural = "madiuss", Wiki plural = "madii"
*** salt wages: KoLmafia plural = "salt wagess", Wiki plural = "salt wages"
*** Chroner cross: KoLmafia plural = "Chroner crosss", Wiki plural = "Chroner crosses"
*** pteruges: KoLmafia plural = "pterugess", Wiki plural = "sets of pteruges"
Plurals checked.

 

[lostcalpolydude]

I suggest the following as a first pass over the data file: remove all plurals that are simply item name + "s".

I guess that makes sense if checkplurals is going to be run somewhat regularly. I did that whenever I manually checked plurals for lots of items and didn't want to end up rechecking those plurals later. If I added any like that and they are now wrong, it's because KoL changed the plural later.

 

[Veracity]

I did that whenever I manually checked plurals for lots of items and didn't want to end up rechecking those plurals later. If I added any like that and they are now wrong, it's because KoL changed the plural later.

I'll explain my reasoning.

When we parse items.txt, there is an optional field that has the plural. It's optional, because if you omit it, KoLmafia will assume that the plural is item name + "s". If the field is there, we make an entry in the ItemDatabase.pluralById map. How is this used?

- ItemDatabase.getPluralName (with an itemId or a string ) will look up the item in the map and either return the plural it finds or the name + "s". This is used any time we want to display the plural - because we have other than 1 of an item, say. It is also used in the "unexpected plural" check in ResultProcessor. Also in ASH - the .plural item proxy field and the to_plural() function.
- ItemDatabase.getPluralById simply "gets" a value and returns it. It is the caller's responsibility to do something if it returns null. This is used by a bunch of places. Many of them should actually be using ItemDatabase.getPluralName.

Now, we don't actually look up the plural that often. So, why should we use all the memory in the map for plurals that we can derive at run time if and when they are ever used? in fact, when getPluralName generates the name + "s" plural because the plural was not in the map, it could put() it in the map for repeated use, if we wanted.

I think you are saying that if the data file lists a plural, that it has been "tested". If so, I think you are the only one who is treating it like that. I don't think it's necessary for that purpose, since I thought we don't actually "test" plurals, anyway; we simply "fix" them when KoLmafia reports that we have not registered the non-trailing-"s" plural for a particular item. Except, you are saying you "didn't want to retest plurals", so you really are using it as a marker.

Well, whatever. If that is how you are using it, I suppose that's fair enough. Too bad it results in having the plural map using a bunch (10s of K bytes worth of memory! ) of extra key/value pairs in it.

I'll fix the places that use getPluralById when they should be using getPluralName. I'll leave the redundant plurals in items.txt. You can do something (or not) with them, depending on how you feel about the "tested plural" vs. the "unnecessary memory usage" argument.

 

[lostcalpolydude]

I'm going through that list of plurals now and checking them. I'll also go through and remove the explicitly-stated plurals that just have an s added, since I see you made the necessary changes to other code for that to not be an issue.

 

[lostcalpolydude]

It occurred to me as I was going through the list that the easiest way to check some of these items (if they are sufficiently common) is api.php. That's always an option for checkplurals maybe, if the person running it has at least 2 of the item. It means a KoL server hit instead of a wiki server hit, but it's guaranteed to give a correct result.

 

[Veracity]

That is a really good idea!

http://localhost:60080/api.php?what=item&id=2403&for=Veracity gave me:

{"name":"barrel of gunpowder","plural":"barrels of gunpowder","descid":"615941452","sellvalue":"0","picture":"powderkeg","type":"","hands":"1","power":"0","candiscard":"0","cantransfer":"0","fancy":"0","quest":"1","combine":"0","smith":"0","jewelry":"0","cook":"0","cocktail":"0","unhardcore":"0"}

I also tried it with items in storage, but it said "You don't own that item". That's a pity. But, yes - for items you have 2 or more of in inventory, we could ask KoL, rather than the Wiki.

 

[lostcalpolydude]

Lots of plural changes made in 14527 (and plenty of wiki plurals fixed in the process). Below are some things that I can't check, or don't want to spend the meat to check. Below that are some cases where mafia and the wiki agree, but due to special characters mafia failed to recognize that. I discovered that there is a 50 character limit for plurals, which leads to a few cut off things that I haven't changed in mafia. At the bottom there are some items that I will check at some point if no one beats me to it (I get the 8th anniversary item within a few days).

I started manually removing plurals where it's just the name plus an s, but then I checked and found that there are 2333 more of those to remove, so that should really be automated.

Unverifiable by me
*** skull of the Bonerdagon: KoLmafia plural = "skull of the Bonerdagons", Wiki plural = "skulls of the Bonerdagon"
*** bowl of oriole's nest soup: KoLmafia plural = "bowl of oriole's nest soups", Wiki plural = "bowls of oriole's nest soup"
*** ultimate wad: KoLmafia plural = "Ultimate Wads", Wiki plural = "ultimate wads"
*** Manual of Transcendent Olfaction: KoLmafia plural = "Manuals of Transcendent Olfaction", Wiki plural = "Manual of Transcendent Olfaction"
*** sterno-flavored Hob-O: KoLmafia plural = "sterno-flavored Hob-O", Wiki plural = "sterno-flavored Hob-Os"
*** pair of ragged claws: KoLmafia plural = "pair of ragged clawss", Wiki plural = "pairs of ragged claws"
*** Annual Ascot: KoLmafia plural = "Annual Ascots", Wiki plural = "I am a fish"
*** puzzling trophy: KoLmafia plural = "puzzling trophys", Wiki plural = "puzzling trophies"
*** left parenthesis: KoLmafia plural = "left parenthesiss", Wiki plural = "left parentheses"
*** right parenthesis: KoLmafia plural = "right parenthesiss", Wiki plural = "right parentheses"
*** super-sweet boom box: KoLmafia plural = "super-sweet boom boxs", Wiki plural = "super-sweet boom boxes"
*** Essence of Annoyance: KoLmafia plural = "Essence of Annoyances", Wiki plural = "flask of Essence of Annoyance"
*** Jeppson's Malort: KoLmafia plural = "Jeppson's Malorts", Wiki plural = "bottles of Jeppson's Malort"
*** Libram of Resolutions: KoLmafia plural = "Librams of Resolutions", Wiki plural = "Libram of Resolutionss"
*** Leapin' Trousers: KoLmafia plural = "Leapin' Trouserss", Wiki plural = "I Am A Fish"
*** Small Medium: KoLmafia plural = "Small Mediums", Wiki plural = "Small Media"
*** How to Tolerate Jerks: KoLmafia plural = "How to Tolerate Jerkss", Wiki plural = "copies of How to Tolerate Jerks"
*** How to Hold a Grudge: KoLmafia plural = "How to Hold a Grudges", Wiki plural = "copies of How to Hold a Grudge"
*** Superhero Reboots: KoLmafia plural = "Superhero Rebootss", Wiki plural = "pairs of Superhero Reboots"
*** dreaming Jung man: KoLmafia plural = "dreaming Jung mans", Wiki plural = "dreaming Jung men"
*** avatar of the Unconscious Collective: KoLmafia plural = "avatar of the Unconscious Collectives", Wiki plural = "avatars of the Unconscious Collective"
*** Solstice Shield: KoLmafia plural = "Solstice Shields", Wiki plural = "I am a fish"
*** KoLHS Pep Squad Box: KoLmafia plural = "KoLHS Pep Squad Boxs", Wiki plural = "KoLHS Pep Squad Boxes"
*** Clan hot dog stand: KoLmafia plural = "Clan hot dog stand", Wiki plural = "Clan hot dog stands"
*** jar of frostigkraut: KoLmafia plural = "jar of frostigkrauts", Wiki plural = "jars of frostigkraut"
*** Can of Spaghetto: KoLmafia plural = "Can of Spaghettos", Wiki plural = "Cans of Spaghetto"
*** packet of winter seeds: KoLmafia plural = "packet of winter seedss", Wiki plural = "packets of winter seeds"
*** Rümpelstiltz: KoLmafia plural = "Rümpelstiltzs", Wiki plural = "bottles of Rümpelstiltz"
*** Sloppy Seconds Diner Employee Handbook: KoLmafia plural = "copies of Sloppy Seconds Diner Employee Handbook", Wiki plural = "copies of the Sloppy Seconds Diner Employee Handbo"
*** button rouge: KoLmafia plural = "button rouges", Wiki plural = "tins of button rouge"

Weird wiki case
These wiki page names don't have # for obvious reasons
*** Hodgman's journal #1: The Lean Times: KoLmafia plural = "copies of Hodgman's journal #1", Wiki plural = ""
*** Hodgman's journal #2: Entrepreneurythmics: KoLmafia plural = "copies of Hodgman's journal #2", Wiki plural = ""
*** Hodgman's journal #3: Pumping Tin: KoLmafia plural = "copies of Hodgman's journal #3", Wiki plural = ""
*** Hodgman's journal #4: View From The Big Top: KoLmafia plural = "copies of Hodgman's journal #4", Wiki plural = ""
*** pog #01 (spider): KoLmafia plural = "pog #01s (spider)", Wiki plural = ""
*** pog #02 (Knob goblin): KoLmafia plural = "pog #02s (Knob goblin)", Wiki plural = ""
*** pog #03 (warwelf): KoLmafia plural = "pog #03s (warwelf)", Wiki plural = ""
*** pog #04 (skleleton): KoLmafia plural = "pog #04s (skleleton)", Wiki plural = ""
*** pog #05 (ninja snowman): KoLmafia plural = "pog #05s (ninja snowman)", Wiki plural = ""
*** pog #06 (filthy hippy): KoLmafia plural = "pog #06s (filthy hippy)", Wiki plural = ""
*** pog #07 (orcish frat boy): KoLmafia plural = "pog #07s (orcish frat boy)", Wiki plural = ""
*** pog #08 (hellion): KoLmafia plural = "pog #08s (hellion)", Wiki plural = ""
*** pog #09 (pirate): KoLmafia plural = "pog #09s (pirate)", Wiki plural = ""
*** pog #10 (hobo): KoLmafia plural = "pog #10s (hobo)", Wiki plural = ""
*** pog #11 (Naughty Sorceress): KoLmafia plural = "pog #11s (Naughty Sorceress)", Wiki plural = ""
(not sure why this fails)
*** Trivial Avocations Card: What?: KoLmafia plural = "Trivial Avocations Cards: What?", Wiki plural = ""
*** Trivial Avocations Card: When?: KoLmafia plural = "Trivial Avocations Cards: When?", Wiki plural = ""
*** Trivial Avocations Card: Who?: KoLmafia plural = "Trivial Avocations Cards: Who?", Wiki plural = ""
*** Trivial Avocations Card: Where?: KoLmafia plural = "Trivial Avocations Cards: Where?", Wiki plural = ""
Italics in name give weird result
*** elven limbos gingerbread: KoLmafia plural = "wafers of limbos gingerbread", Wiki plural = ""
*** Vial of jus de larmes: KoLmafia plural = "vials of jus de larmes", Wiki plural = ""
*** Lobster qua Grill: KoLmafia plural = "pieces of Lobster qua Grill", Wiki plural = ""
*** ectoplasm au jus: KoLmafia plural = "bottles of ectoplasm au jus", Wiki plural = ""
(disambiguation page)
*** zmobie: KoLmafia plural = "zombeis", Wiki plural = ""
*** Bulky Buddy Box: KoLmafia plural = "Bulky Buddy Boxen", Wiki plural = ""
*** The Ballad of Richie Thingfinder: KoLmafia plural = "copies of The Ballad of Richie Thingfinder", Wiki plural = ""
*** Benetton's Medley of Diversity: KoLmafia plural = "copies of Benetton's Medley of Diversity", Wiki plural = ""
*** Elron's Explosive Etude: KoLmafia plural = "copies of Elron's Explosive Etude", Wiki plural = ""
*** Chorale of Companionship: KoLmafia plural = "copies of Chorale of Companionship", Wiki plural = ""
*** Prelude of Precision: KoLmafia plural = "copies of Prelude of Precision", Wiki plural = ""
*** Inigo's Incantation of Inspiration: KoLmafia plural = "copies of Inigo's Incantation of Inspiration", Wiki plural = ""
*** BRICKO octopus: KoLmafia plural = "BRICKO octopodes", Wiki plural = ""
Match
*** PB&BP: KoLmafia plural = "PB&BPs", Wiki plural = "PB&BPs"
*** Drac & Tan: KoLmafia plural = "Dracs & Tans", Wiki plural = "Dracs & Tans"
*** Dark & Starry: KoLmafia plural = "Dark & Starries", Wiki plural = "Dark & Starries"
*** Pete & Jackie's Dragon Tooth Emporium Catalog: KoLmafia plural = "Pete & Jackie's Dragon Tooth Emporium Catalogs", Wiki plural = "Pete & Jackie's Dragon Tooth Emporium Catalogs"
*** fountain 'soda': KoLmafia plural = "'fountain' sodas", Wiki plural = "'fountain' sodas"
*** Bone's Farm "wine": KoLmafia plural = "bottles of Bone's Farm "wine"", Wiki plural = "bottles of Bone's Farm "wine""
*** bag of W&Ws: KoLmafia plural = "bags of W&Ws", Wiki plural = "bags of W&Ws"
*** Chef Boy, R&D's business card: KoLmafia plural = "Chef Boy, R&D's business cards", Wiki plural = "Chef Boy, R&D's business cards"


wiki is right, seems like a KoL bug
*** stainless steel suspenders: KoLmafia plural = "stainless steel suspenders", Wiki plural = "stainless steel suspenderss"
*** throwing wrench: KoLmafia plural = "throwing wrenches", Wiki plural = "throwing wrenchs"
*** A Beginner's Guide to Charming Snakes (used): KoLmafia plural = "A Beginner's Guide to Charming Snakes (used)s", Wiki plural = "used copies of A Beginner's Guide to Charming Snak"
*** Inigo's Incantation of Inspiration (crumpled): KoLmafia plural = "Inigo's Incantation of Inspiration (crumpled)s", Wiki plural = "crumpled copies of Inigo's Incantation of Inspirat"


come back to these
*** anniversary balsa wood socks: KoLmafia plural = "pairs of anniversary balsa wood socks", Wiki plural = "pairs of anniversary balsa wood socks (which you r"
*** plush alielf: KoLmafia plural = "plush alielfs", Wiki plural = "plush alielves"
*** plush hamsterpus: KoLmafia plural = "plush hamsterpuss", Wiki plural = "plush hamsterpi"
*** plush ferrelf: KoLmafia plural = "plush ferrelfs", Wiki plural = "plush ferrelves"
*** plush alien hamsterpus: KoLmafia plural = "plush alien hamsterpuss", Wiki plural = "plush alien hamsterpi"
*** plush mutated alielf: KoLmafia plural = "plush mutated alielfs", Wiki plural = "plush mutated alielves"

 

[Veracity]

I started manually removing plurals where it's just the name plus an s, but then I checked and found that there are 2333 more of those to remove, so that should really be automated.

Well, revision 14528 has redundant plurals for item numbers up to 2446. I did it by hand and it was tedious and error prone and I had to fix things that I broke - like removing more than just the final tab and plural.

You know - I think I can make checkitems do a lot of this; it generates lines which look exactly like those in items.txt. I'll make it not put a plural on the line if the plural is name + "s". Stay tuned.

 

[Veracity]

Yeah, OK. Revision 14529 gets rid of all the remaining "default" plurals from items.txt. Thanks for all you have done with verification! That was a lot of work, eh?

 

[Veracity]

Lots of plural changes made in 14527 (and plenty of wiki plurals fixed in the process). Below are some things that I can't check, or don't want to spend the meat to check. Below that are some cases where mafia and the wiki agree, but due to special characters mafia failed to recognize that. I discovered that there is a 50 character limit for plurals, which leads to a few cut off things that I haven't changed in mafia. At the bottom there are some items that I will check at some point if no one beats me to it (I get the 8th anniversary item within a few days).

The 50 character limit is KoL-limit? So if it actual says "You acquire 2 xxx", the xxx will be truncated at 50 characters? I'll have to see if there are any cases where it says "You acquire 2 xxx", where xxx is the plural, without an accompanying "rel" string or something. Perhaps moving things out the display case or something...

I started manually removing plurals where it's just the name plus an s, but then I checked and found that there are 2333 more of those to remove, so that should really be automated.

This is done.

Unverifiable by me
*** sterno-flavored Hob-O: KoLmafia plural = "sterno-flavored Hob-O", Wiki plural = "sterno-flavored Hob-Os"
*** super-sweet boom box: KoLmafia plural = "super-sweet boom boxs", Wiki plural = "super-sweet boom boxes"
*** Can of Spaghetto: KoLmafia plural = "Can of Spaghettos", Wiki plural = "Cans of Spaghetto"
*** Rümpelstiltz: KoLmafia plural = "Rümpelstiltzs", Wiki plural = "bottles of Rümpelstiltz"

Hagnk's doesn't have that many of your bottles of Rümpelstiltz, he's only got 1.
Hagnk's doesn't have that many of your super-sweet boom boxes, he's only got 1
Hagnk's doesn't have that many of your sterno-flavored Hob-O, he's only got 1.
Hagnk's doesn't have that many of your Cans of Spaghetto, he's only got 1.

Unverifiable by me
*** skull of the Bonerdagon: KoLmafia plural = "skull of the Bonerdagons", Wiki plural = "skulls of the Bonerdagon"
*** left parenthesis: KoLmafia plural = "left parenthesiss", Wiki plural = "left parentheses"
*** right parenthesis: KoLmafia plural = "right parenthesiss", Wiki plural = "right parentheses"
*** button rouge: KoLmafia plural = "button rouges", Wiki plural = "tins of button rouge"

I will make some of these tomorrow before I ascend.
untinker a badass belt -> skull of the Bonerdagon
Adventure in Enormous Greater Than Sign (which I didn't bother to do this run; I just pulled 2 large boxes and made blessed large boxes to get my bang potions) to get left and right parenthesis. They don't seem to be quest items...
button rouge is the avatar potion for the man with the red buttons. I'll rain man him a few times and see if I can get one.

*** Clan hot dog stand: KoLmafia plural = "Clan hot dog stand", Wiki plural = "Clan hot dog stands"
*** packet of winter seeds: KoLmafia plural = "packet of winter seedss", Wiki plural = "packets of winter seeds"

Well, if I didn't want to ascend with my winter garden, I'd make the seed packet. Someday.
I also own a Clan hot dog stand. It's in my display case. I'll try to remember to remove it before I ascend.

Weird wiki case

We have a simple algorithm for generating the name of the Wiki page. For the ones for which that algorithm fails, we do have a modifier we can add to names in modifiers.txt: Wiki Name: "frigid hankyu" (which we found with the Unicode character, anyway.) "checkplurals" doesn't look at that, but it could. There would still be issues; the ones which lead to disambiguation pages do so for a reason - an Effect and a Skill or and Item with the same name, for example. We already can't handle that correctly in modifiers.txt.

 

[Veracity]

Untinkering badass belt (2)...
untinker * badass belt
You acquire batskin belt (2)
Unexpected plural of 'skull of the Bonerdagon' found: skulls of the Bonerdagon
You acquire skull of the Bonerdagon (2)
Successfully untinkered badass belt (2)

Removing items from closet (request 1 of 3)...
Unexpected plural of 'left parenthesis' found: left parentheses
You acquire left parenthesis (2)
Removing items from closet (request 2 of 3)...
Unexpected plural of 'right parenthesis' found: right parentheses
You acquire right parenthesis (2)
Removing items from closet (request 3 of 3)...
Unexpected plural of 'button rouge' found: tins of button rouge
You acquire button rouge (2)
Requests complete.

So, the Wiki is correct for all of those and we need to change.

 

[Veracity]

Unexpected plural of 'rubber nubbin' found: rubber nubbins (but I hardly know her!)

Hagnk's doesn't have that many of your Clan hot dog stands, he's only got 1.

So, the Wiki is correct for both of those.

I have a character who has a bowl of oriole's nest soup. It's not a quest item, but it's not tradeable, so I don't know how to test the plural; I can put it in and out of the closet, but only one.

Of course, since it is not tradeable and you can only have one, the plural hardly matters.

 

[Cool12309]

So, the Wiki is correct for both of those.

I have a character who has a bowl of oriole's nest soup. It's not a quest item, but it's not tradeable, so I don't know how to test the plural; I can put it in and out of the closet, but only one.

Of course, since it is not tradeable and you can only have one, the plural hardly matters.

/closet? 5 bowl of oriole's nest soup

That will give you the plural.