Bug Aftercore Auto-Ode to Booze doesn't check turns remaining

[Yvain]

In aftercore Mafia has a nice feature where it will cast ode of booze for you automatically when you try to drink. However if you already have ode of booze it doesn't look at how many turns of the buff are remaining compared to what is being drunk resulting in some drinks (from a stack) being drunk without ode to booze.

In the following GLI output I had 10 turns of Ode to Booze, queued up 7 dusty bottles and a 1 drunkenness booze.

Drinking 9 dusty bottle of great Zinfandel...
You gain 12 Adventures
You gain 13 Strengthliness
You gain 13 Enchantedness
You gain 11 Roguishness
You gain 2 Drunkenness
You lose some of an effect: Ode to Booze
You gain 8 Adventures
You gain 10 Strengthliness
You gain 13 Mysteriousness
You gain 15 Chutzpah
You gain 2 Drunkenness
You lose some of an effect: Ode to Booze
You gain 8 Adventures
You gain 14 Strengthliness
You gain 15 Wizardliness
You gain 10 Chutzpah
You gain 2 Drunkenness
You lose some of an effect: Ode to Booze
You gain 9 Adventures
You gain 10 Strengthliness
You gain 16 Mysteriousness
You gain 11 Roguishness
You gain 2 Drunkenness
You lose some of an effect: Ode to Booze
You gain 9 Adventures
You gain 13 Strengthliness
You gain 15 Mysteriousness
You gain 11 Smarm
You gain 2 Drunkenness
You lose an effect: Ode to Booze
You gain 8 Adventures
You gain 14 Muscleboundness
You gain 15 Mysteriousness
You gain 10 Sarcasm
You gain 2 Drunkenness
You gain 5 Adventures
You gain 15 Beefiness
You gain 14 Enchantedness
You gain 10 Roguishness
You gain 2 Drunkenness
You gain 6 Adventures
You gain 13 Strengthliness
You gain 17 Mysteriousness
You gain 15 Smarm
You gain 2 Drunkenness
You gain 6 Adventures
You gain 13 Strengthliness
You gain 15 Magicalness
You gain 12 Roguishness
You gain 2 Drunkenness
Finished drinking 9 dusty bottle of great Zinfandel.
Casting The Ode to Booze 1 times...
You acquire an effect: Ode to Booze (duration: 20 Adventures)
The Ode to Booze was successfully cast.
Drinking 1 CSA cheerfulness ration...
You gain 5 Adventures
You gain 40 Fortitude
You gain 50 Wizardliness
You gain 45 Smarm
You gain 1 Drunkenness
You lose some of an effect: Ode to Booze
Finished drinking 1 CSA cheerfulness ration.

 

[eviltwinskippy]

I tried to reproduce this.
I cast ode (manually) and adventured it down to 2 turns left.
Then told mafia to drink 4 sir schlitz.
It correctly cast ode before drinking.

If I had to guess, it is something with the dusty bottles being dynamic.

I will try that after rollover.

edit: Yes trying it with zinfandel failed as you described.

 

[Yvain]

I drink a lot of dusty bottles. I didn't think to try it with anything else. Glad it was only a minor bug I found.

 

[eviltwinskippy]

Ok, what happens is that identifying bottles updates Inebriety to properly set the drunk level for that bottle.
So, it would set "dusty bottle of zinfandel " to 2.
Unfortunately mafia later asks for the Inebriety of "dusty bottle of 'great' zinfandel" doesnt find it and returns 0.

This could be fixed by:

1. Removing the modifier before asking for the Inebriety.
2. Add an entry to Inebriety for the modified bottle name when identifying it.
3. Just add all of the combinations to Inebriety (great/glassy/spooky...) since great zinfandel is always the same no matter what this characters bottles are.
4. Some other answer that I haven't found in the mafia code