philmasterplus
Active member
This patch adds a new unit test for CharSheetRequest.java.
Tested on r20582.
P.S. While testing this, DataFileTest.java kept failing for me, so I had to disable it (patch not included). I assume its unrelated to my patch.
- Added a new class,
CharSheetRequest.ParsedSkillInfo
. It's a simple POJO class representing a parsed (but not identified) skill. - Extracted the skill parsing code to a method,
CharSheetRequest.parseSkills()
. This method takes an XML Document node as argument and returns anArrayList<ParsedSkillInfo>
. - Added a unit test that exercises this method. The accompanying
test_charsheet.html
has been scrubbed of any real-world user names and actual pwd hashes (replaced with dummy hashes).
build.xml
so that unit tests could import JARs in src/jar/
. I did this because the unit test needed to use HTMLCleaner. I hope I'm not breaking anything by modifying build.xml
...Tested on r20582.
P.S. While testing this, DataFileTest.java kept failing for me, so I had to disable it (patch not included). I assume its unrelated to my patch.
Attachments
Last edited: