Feature Add S'mores to consumables (and all the lovely math that goes with it)
- Thread starter Yvain
- Start date
s'more tracking
I've been eating a lot of s'mores lately, so I decided to try adding support for them. In the patch I made, eating a s'more updates a preference showing how many you've had. Ascending should reset that. The Item Manager correctly displays the adventures gained from the item, the adv/full for the item, and the fullness, but it still uses the fullness from fullness.txt (which I luckily set to 21 for this testing, meaning mafia did not let me eat it, compared to the actual fullness for that character of 6). I tried changing the fullness to 0, which led to the prompt asking how many I wanted to eat (pre-filled with 2 when I had 3 on hand, no creation queue), but clicking OK led to it saying (1 possible, 3 current) and they weren't actually consumed.
Among other issues, mafia will probably assume that all s'mores have the same fullness if several are eaten at once, before updating the preference for that (assuming other stuff is made to work). Also, eating one from the relay browser updated smoresEaten but did not update the fullness value returned as part of its proxy data, which might mean that I'm not refreshing the data properly.
I've been eating a lot of s'mores lately, so I decided to try adding support for them. In the patch I made, eating a s'more updates a preference showing how many you've had. Ascending should reset that. The Item Manager correctly displays the adventures gained from the item, the adv/full for the item, and the fullness, but it still uses the fullness from fullness.txt (which I luckily set to 21 for this testing, meaning mafia did not let me eat it, compared to the actual fullness for that character of 6). I tried changing the fullness to 0, which led to the prompt asking how many I wanted to eat (pre-filled with 2 when I had 3 on hand, no creation queue), but clicking OK led to it saying (1 possible, 3 current) and they weren't actually consumed.
Among other issues, mafia will probably assume that all s'mores have the same fullness if several are eaten at once, before updating the preference for that (assuming other stuff is made to work). Also, eating one from the relay browser updated smoresEaten but did not update the fullness value returned as part of its proxy data, which might mean that I'm not refreshing the data properly.
Merged with a few other threads. My previously-posted patch isn't very good.
Crowther
Active member
I've no idea of the internals involved, but maybe mafia could be "tricked" into thinking you can't eat more than one. Then the display can be accurate for that one and state can be updated after each one is eaten. Sure you'd have to do more work in scripts and more GUI clicking, but at least the info would be there for the next s'more.
We have the mechanism for declaring that items have to be eaten one at a time, using EatItemRequest.singleConsume() and eatItemRequest.sequentialConsume(). Right off hand, I don't recall why you would use one vs. the other. I also don't think those were intended to deal with things that change in fullness after each consumption, so, they might not really fit the need for this...