looking further at the changes to build.xml and build.properties, it looks like you're changing the ant build process to add the lib/jar directory to the classpath (via adding the classpath to the compile task).
The classpath file has a long history of not being required except for eclipse, and the project has generally had a model where compile-time dependencies on external jars were managed by importing the source and and runtime depenedencies were managed by adding a jar to lib/jar .
I can't tell you why, but I'm cautious about changing it. Does it need to be changed to get this patch to work? What are the implications of it for other jars? There are users (recently) who've had issues in Eclipse when they had two conflicting versions of some jar, so what complexity are we buying to get this?
tl;dr - I'd be more comfortable if we didn't change the build.xml, but I don't have a concrete failure to report.
The classpath file has a long history of not being required except for eclipse, and the project has generally had a model where compile-time dependencies on external jars were managed by importing the source and and runtime depenedencies were managed by adding a jar to lib/jar .
I can't tell you why, but I'm cautious about changing it. Does it need to be changed to get this patch to work? What are the implications of it for other jars? There are users (recently) who've had issues in Eclipse when they had two conflicting versions of some jar, so what complexity are we buying to get this?
tl;dr - I'd be more comfortable if we didn't change the build.xml, but I don't have a concrete failure to report.