I'm looking to quash some of the weird edge cases where people do stuff with unexpected results.
We use forceContinue all over the place. It has two effects. It sets MafiaState.CONTINUE, and it set StaticEntity.userAborted to false.
Most of those appear in one of two roles:
Before running a command or script
After doing something that might cause a failure and handling it
Unfortunately, we can have more than one thing happening at once, and this means unexpected results occur. For example, user aborts getting ignored and activity continuing.
I think what we need is forceContinue to no longer ignore user aborts. We want user aborts to stop everything, not just something, sometimes. And we want using a command (CLI, GCLI, Adventure Request, Relay request, Script), when nothing else (CLI, GCLI, Adventure Request, Relay request, Script) is currently running, to reset StaticEntity.userAborted to false.
It's possible this just involves more checks of !KoLmafia.refusesContinue() before using forceContinue().
But this is way further into Mafia's weeds than I've been before, so feedback welcomed!
We use forceContinue all over the place. It has two effects. It sets MafiaState.CONTINUE, and it set StaticEntity.userAborted to false.
Most of those appear in one of two roles:
Before running a command or script
After doing something that might cause a failure and handling it
Unfortunately, we can have more than one thing happening at once, and this means unexpected results occur. For example, user aborts getting ignored and activity continuing.
I think what we need is forceContinue to no longer ignore user aborts. We want user aborts to stop everything, not just something, sometimes. And we want using a command (CLI, GCLI, Adventure Request, Relay request, Script), when nothing else (CLI, GCLI, Adventure Request, Relay request, Script) is currently running, to reset StaticEntity.userAborted to false.
It's possible this just involves more checks of !KoLmafia.refusesContinue() before using forceContinue().
But this is way further into Mafia's weeds than I've been before, so feedback welcomed!