It's Spring! And it means two things:
1- Taco Season (one day, I'm telling you...)
2- Spring cleaning!
So... uh... I kind of snapped, and went/am going on a cleaning rampage throughout mafia...
For now, let's start "simple": Whitespaces. Spaces, tabs, and newlines, to be exact.
A hyyuuuuuuge buttload of nothing but whitespace changes.
I tried very hard to have all of mafia conform to the intended style guidelines.
This was most likely not ALL of them, but I'm very confident that I managed to find the vast majority. (Except a few files like ChoiceManager, as I'm currently in the middle (actually more like the end) of a big rework of them, and changing them would give no benefit other than throwing in some merge conflicts on my side).
There was no clear indications, so I had to "take a gamble" on some.
The one I'm the least sure about is the array declaration; I wasn't sure whether we wanted
or
I went for the former, hope I wasn't wrong ._.
This was all done BY HAND. If there was any mistake, let me know; there's an actual human on the other side of the screen who will learn from this.
(literally had to make 2 patch files because I was busting the site's upload limit...)
Edit: removed group 1 and 2 mentioned in https://kolmafia.us/threads/shout-spring-cleaning-shout-whitespaces.25975/post-161844
1- Taco Season (one day, I'm telling you...)
2- Spring cleaning!
So... uh... I kind of snapped, and went/am going on a cleaning rampage throughout mafia...
For now, let's start "simple": Whitespaces. Spaces, tabs, and newlines, to be exact.
A hyyuuuuuuge buttload of nothing but whitespace changes.
I tried very hard to have all of mafia conform to the intended style guidelines.
This was most likely not ALL of them, but I'm very confident that I managed to find the vast majority. (Except a few files like ChoiceManager, as I'm currently in the middle (actually more like the end) of a big rework of them, and changing them would give no benefit other than throwing in some merge conflicts on my side).
There was no clear indications, so I had to "take a gamble" on some.
The one I'm the least sure about is the array declaration; I wasn't sure whether we wanted
Java:
String[] name
Java:
String [] name
This was all done BY HAND. If there was any mistake, let me know; there's an actual human on the other side of the screen who will learn from this.
(literally had to make 2 patch files because I was busting the site's upload limit...)
Edit: removed group 1 and 2 mentioned in https://kolmafia.us/threads/shout-spring-cleaning-shout-whitespaces.25975/post-161844
Attachments
Last edited: