Bug - Fixed requireSerwerTestItems not working as intended

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Code:
			if ( KoLCharacter.hasEquipped( ItemPool.get( ItemPool.GATORSKIN_UMBRELLA, 1 ) ) &&
			     KoLCharacter.hasEquipped( ItemPool.get( ItemPool.HOBO_CODE_BINDER, 1 ) ) &&
			     InventoryManager.retrieveItem( ItemPool.SEWER_WAD ) &&
			     InventoryManager.retrieveItem( ItemPool.OOZE_O ) &&
			     InventoryManager.retrieveItem( ItemPool.DUMPLINGS ) &&
			     InventoryManager.retrieveItem( ItemPool.OIL_OF_OILINESS, 3 ) )
			{
				StringBuilder message = new StringBuilder();
				message.append("requireSewerTestItems is true so: ");
				if (!(KoLCharacter.hasEquipped( ItemPool.get( ItemPool.GATORSKIN_UMBRELLA, 1 )))) {
					message.append("Equip a gatorskin umbrella. ");
				}
				if (!(KoLCharacter.hasEquipped( ItemPool.get( ItemPool.HOBO_CODE_BINDER, 1 ) ) ) ) {
					message.append("Equip a hobo code binder. ");
				}
				if (!InventoryManager.retrieveItem( ItemPool.SEWER_WAD )) {
					message.append("Acquire 1 sewer wad. ");
				}
				if (!InventoryManager.retrieveItem( ItemPool.OOZE_O )) {
					message.append("Acquire 1 bottle of Ooze-O. ");
				}
				if (!InventoryManager.retrieveItem( ItemPool.DUMPLINGS )) {
					message.append("Acquire 1 unfortunate dumpling. ");
				}
				if (!InventoryManager.retrieveItem( ItemPool.OIL_OF_OILINESS, 3 ) ) {
					message.append("Acquire 3 oil of oiliness. ");
				}
				KoLmafia.updateDisplay( MafiaState.ERROR, message.toString() );
				this.isValidAdventure = false;
			}

Surely the conditions of this if should be inverted? It's a quick fix but I'm sceptical because its been around for a good while.
 

Veracity

Developer
Staff member
Yeah, I busted that when I moved some existing code to a more rational place.
Revision 20024
 
Top