According to grep, the following frames override the useSidePane() function:
CommandDisplayFrame: return true
AdventureFrame: return true
BuffBotFrame: return true
CharSheetFrame: return false
GenericFrame: return false
It's only invoked inside CreateFrameRunnable.java and only for things that inherit from GenericFrame, so the false items seem like they're redundant.
I'm not sure why it's true on BuffBotFrame, but I don't run a buff bot to determine if it's valuable. It certainly seems out of place, but mostly I solve that by not opening that Window. Adventure and CommandDisplay seem reasonable, if someone is opening them via Startup as Window.
tl;dr can BuffBotFrame drop the useSidePanel() override?
CommandDisplayFrame: return true
AdventureFrame: return true
BuffBotFrame: return true
CharSheetFrame: return false
GenericFrame: return false
It's only invoked inside CreateFrameRunnable.java and only for things that inherit from GenericFrame, so the false items seem like they're redundant.
I'm not sure why it's true on BuffBotFrame, but I don't run a buff bot to determine if it's valuable. It certainly seems out of place, but mostly I solve that by not opening that Window. Adventure and CommandDisplay seem reasonable, if someone is opening them via Startup as Window.
tl;dr can BuffBotFrame drop the useSidePanel() override?