20599: More code tidying * Remove unnecessary escapes in regexes * Remove unnecessary type...

RSS Bot

Feed Reader
More code tidying

* Remove unnecessary escapes in regexes
* Remove unnecessary type casting
* Remove unnecessary StringBuilding
* General semi-automated code deduplication and simplification

by innerdreams on 2021-01-05 12:01:23

M /src/net/sourceforge/kolmafia/AdventureResult.java (view) (diff)
M /src/net/sourceforge/kolmafia/BuffBotHome.java (view) (diff)
M /src/net/sourceforge/kolmafia/CakeArenaManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/CoinmasterData.java (view) (diff)
M /src/net/sourceforge/kolmafia/DebugModifiers.java (view) (diff)
M /src/net/sourceforge/kolmafia/EdServantData.java (view) (diff)
M /src/net/sourceforge/kolmafia/Expression.java (view) (diff)
M /src/net/sourceforge/kolmafia/FamiliarData.java (view) (diff)
M /src/net/sourceforge/kolmafia/KoLAdventure.java (view) (diff)
M /src/net/sourceforge/kolmafia/KoLCharacter.java (view) (diff)
M /src/net/sourceforge/kolmafia/KoLDesktop.java (view) (diff)
M /src/net/sourceforge/kolmafia/KoLMailMessage.java (view) (diff)
M /src/net/sourceforge/kolmafia/KoLmafiaASH.java (view) (diff)
M /src/net/sourceforge/kolmafia/Modifiers.java (view) (diff)
M /src/net/sourceforge/kolmafia/MonsterData.java (view) (diff)
M /src/net/sourceforge/kolmafia/PastaThrallData.java (view) (diff)
M /src/net/sourceforge/kolmafia/PokefamData.java (view) (diff)
M /src/net/sourceforge/kolmafia/RequestEditorKit.java (view) (diff)
M /src/net/sourceforge/kolmafia/RequestThread.java (view) (diff)
M /src/net/sourceforge/kolmafia/SpecialOutfit.java (view) (diff)
M /src/net/sourceforge/kolmafia/Speculation.java (view) (diff)
M /src/net/sourceforge/kolmafia/chat/ChatFormatter.java (view) (diff)
M /src/net/sourceforge/kolmafia/chat/ChatManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/chat/ChatParser.java (view) (diff)
M /src/net/sourceforge/kolmafia/chat/ChatSender.java (view) (diff)
M /src/net/sourceforge/kolmafia/chat/SentMessageEntry.java (view) (diff)
M /src/net/sourceforge/kolmafia/chat/StyledChatBuffer.java (view) (diff)
M /src/net/sourceforge/kolmafia/combat/Macrofier.java (view) (diff)
M /src/net/sourceforge/kolmafia/maximizer/Boost.java (view) (diff)
M /src/net/sourceforge/kolmafia/maximizer/CheckedItem.java (view) (diff)
M /src/net/sourceforge/kolmafia/maximizer/Evaluator.java (view) (diff)
M /src/net/sourceforge/kolmafia/maximizer/Maximizer.java (view) (diff)
M /src/net/sourceforge/kolmafia/maximizer/MaximizerSpeculation.java (view) (diff)
M /src/net/sourceforge/kolmafia/moods/ManaBurn.java (view) (diff)
M /src/net/sourceforge/kolmafia/moods/ManaBurnManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/moods/Mood.java (view) (diff)
M /src/net/sourceforge/kolmafia/moods/MoodTrigger.java (view) (diff)
M /src/net/sourceforge/kolmafia/moods/RecoveryManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/objectpool/Concoction.java (view) (diff)
M /src/net/sourceforge/kolmafia/objectpool/ItemPool.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/AdventureDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/BuffBotDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/ConcoctionDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/ConsumablesDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/DebugDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/EffectDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/EquipmentDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/FamiliarDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/FaxBotDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/HolidayDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/ItemDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/MonsterDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/NPCStoreDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/PocketDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/ProfileSnapshot.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/Script.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/ScriptManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/SkillDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/persistence/TCRSDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/preferences/Preferences.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/ArcadeRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/AscensionHistoryRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/BURTRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/BasementRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/CakeArenaRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/CharPaneRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/CharSheetRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/ClanLogRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/ClanLoungeRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/ClanStashRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/CoinMasterRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/DwarfFactoryRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/FightRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/FudgeWandRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/GenericRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/MallSearchRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/ManageStoreRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/PasswordHashRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/PeeVPeeRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/ProfileRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/PurchaseRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/RelayRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/SewerRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/SpaaaceRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/SpelunkyRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/SushiRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/TerrifiedEagleInnRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/UseItemRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/UseSkillRequest.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/BeachManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/BuffBotManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/ChoiceManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/ClanManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/DadManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/DreadScrollManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/DvorakManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/EncounterManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/EquipmentManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/GoalManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/HaciendaManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/InventoryManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/MonorailManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/MonsterManuelManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/NemesisManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/RabbitHoleManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/SorceressLairManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/StoreManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/TurnCounter.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/VolcanoMazeManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/session/WumpusManager.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/CakeArenaFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/CoinmastersFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/CommandDisplayFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/ContactListFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/FamiliarTrainingFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/FaxRequestFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/ItemManageFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/MallSearchFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/OptionsFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/RequestFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/SendMessageFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/SkillBuffFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/StoreManageFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/TabbedChatFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/TrophyFrame.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/listener/HyperlinkAdapter.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/menu/UntinkerMenuItem.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/AddCustomDeedsPanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/AdventureSelectPanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/DailyDeedsPanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/InventoryPanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/ItemManagePanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/PulverizePanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/panel/SynthesizePanel.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/widget/AutoFilterTextField.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/widget/GenericScrollPane.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/widget/ListCellRendererFactory.java (view) (diff)
M /src/net/sourceforge/kolmafia/swingui/widget/ShowDescriptionTable.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/DataTypes.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/Parser.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/RuntimeLibrary.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/FoldItemCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/KitchenCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/MushroomFieldCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/RestaurantCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/SendMessageCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/TelescopeCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/WikiLookupCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/command/WumpusCommand.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/javascript/EnumeratedWrapperPrototype.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/parsetree/LibraryFunction.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/parsetree/RecordType.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/parsetree/TypeDef.java (view) (diff)
M /src/net/sourceforge/kolmafia/textui/parsetree/Value.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/ByteBufferUtilities.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/CharacterEntities.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/HTMLParserUtils.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/IntegerArray.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/KoLDatabase.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/ReleaseNotes.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/StringArray.java (view) (diff)
M /src/net/sourceforge/kolmafia/utilities/StringUtilities.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/BasementDecorator.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/CharPaneDecorator.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/DiscoCombatHelper.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/FightDecorator.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/IslandDecorator.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/RelayAgent.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/StationaryButtonDecorator.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/UseItemDecorator.java (view) (diff)
M /src/net/sourceforge/kolmafia/webui/ValhallaDecorator.java (view) (diff)
 

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
I'm doing a few of IntelliJ's more innocuous automatic refactors. They're in separate revisions so we can track down if anything weird is affected but these should really affect nothing
 
Top