20523: This patch should handle relay scripts correctly, both override scripts and those from the...

[RSS Bot]

This patch should handle relay scripts correctly, both override scripts and those from the menu. Notably, in order to avoid breaking backwards compatibility with e.g. Guide, I've added a new GET argument to the relay menu scripts that triggers execution of any relay_x.js script vs simply returning it as a JS file. Guide calls its main JS file "relay_Guide.js." Thanks @ikzann

by innerdreams on 2020-11-24 17:33:43

M /src/net/sourceforge/kolmafia/KoLmafiaASH.java (view) (diff)
M /src/net/sourceforge/kolmafia/KoLmafiaCLI.java (view) (diff)
M /src/net/sourceforge/kolmafia/request/RelayRequest.java (view) (diff)

 

[Ezandora]

Hmm. Perhaps I should rename relay_Guide.js to Guide.js, due to this ambiguity. (at the moment it shows up in the menu, as it should under this new paradigm) Does that cause a user-side pop-up to appear, when you add a new file? I can't remember.

If I do that, you might want to consider removing &relay=true, since it might not be necessary otherwise? Unless there's other scripts out there that break.