Bug - Fixed mumming trunk modifiers are no longer counted in stats

Malibu Stacey

Active member
Noticed recently that my meat drop was 30 lower than it used to be when using the Robortender with The Captain mumming trunk outfit. Decided to empirically test it today after a bit of experimentation yesterday

Code:
> modtrace meat drop

                            type                          source                          Meat Drop                          Sporadic Meat Drop                          Meat Drop Penalty                                      
Item                          garbage sticker                          +30.00                          = +30.00                                                                                                                                              
Item                          stinky cheese eye                          +1.00                          = +31.00                                                                                                                                              
Item                          Mr. Screege's spectacles                          +20.00                          = +51.00                                                                                                                                              
Skill                          5-D Earning Potential                          +20.00                          = +71.00                                                                                                                                              
Skill                          Budget Conscious                          +10.00                          = +81.00                                                                                                                                              
Skill                          Nimble Fingers                          +20.00                          = +101.00                                                                                                                                              
Skill                          Expert Panhandling                          +10.00                          = +111.00                                                                                                                                              
Skill                          Thief Among the Honorable                          +10.00                          = +121.00                                                                                                                                              
Effect                          Rave Nirvana                          +50.00                          = +171.00                                                                                                                                              
Effect                          Driving Observantly                          +50.00                          = +221.00                                                                                                                                              
Effect                          Disco Leer                          +10.00                          = +231.00                                                                                                                                              
Effect                          Synthesis: Greed                          +300.00                          = +531.00                                                                                                                                              
Effect                          Polka of Plenty                          +50.00                          = +581.00                                                                                                                                              
Familiar                          Robortender                          +423.12                          = +1004.12                                                                                                                                              
BoomBox                          Total Eclipse of Your Meat                          +30.00                          = +1034.12                                                                                                                              
    
    
    Costume 1 applied to Robortender
Preference _mummeryUses changed from     3, to 3,1,
Preference _mummeryMods changed from Experience (Muscle):     [4*fam(Cat Burglar)], to Experience (Muscle): [4*fam(Cat Burglar)],Meat     Drop: [30*fam(Robortender)],

> modtrace meat     drop

                            type                          source                          Meat Drop                          Sporadic Meat Drop                          Meat Drop Penalty                                      
Item                          garbage sticker                          +30.00                          = +30.00                                                                                                                                              
Item                          stinky cheese eye                          +1.00                          = +31.00                                                                                                                                              
Item                          Mr. Screege's spectacles                          +20.00                          = +51.00                                                                                                                                              
Skill                          5-D Earning Potential                          +20.00                          = +71.00                                                                                                                                              
Skill                          Budget Conscious                          +10.00                          = +81.00                                                                                                                                              
Skill                          Nimble Fingers                          +20.00                          = +101.00                                                                                                                                              
Skill                          Expert Panhandling                          +10.00                          = +111.00                                                                                                                                              
Skill                          Thief Among the Honorable                          +10.00                          = +121.00                                                                                                                                              
Effect                          Rave Nirvana                          +50.00                          = +171.00                                                                                                                                              
Effect                          Driving Observantly                          +50.00                          = +221.00                                                                                                                                              
Effect                          Disco Leer                          +10.00                          = +231.00                                                                                                                                              
Effect                          Synthesis: Greed                          +300.00                          = +531.00                                                                                                                                              
Effect                          Polka of Plenty                          +50.00                          = +581.00                                                                                                                                              
Familiar                          Robortender                          +423.12                          = +1004.12                                                                                                                                              
BoomBox                          Total Eclipse of Your Meat                          +30.00                          = +1034.12

Not sure if the table copy/paste spam will be readable but the gist of it is my meat drop was showing as +1034.12 before using the mumming trunk and still +1034.12 after using it to give my Robortender the Captain outfit (at which point it should have been +1064.12).

I haven't tested any of the other mumming trunk outfits yet but I suspect they'll all suffer the same issue.

Code:
> version

KoLmafia v18.11 r19278
 
Last edited:

Malibu Stacey

Active member
Applies to Voting Booth daily modifiers too.

Code:
> prefref votemodifier

Name Value Default Scope
_voteModifier Monster Level: +10, Muscle Percent: +25 user

> modtrace monster level

type source Monster Level
MCD MCD +10.00 = +10.00

> modtrace muscle percent

type source Muscle Percent
Effect Big +20.00 = +20.00
Effect Rage of the Reindeer +10.00 = +30.00

> version

KoLmafia v18.11 r19314
 

Darzil

Developer
This appears to be a result of the changes made by Heeheehee to not evaluate modifiers if they don't contain expressions. This breaks everywhere that we convert a string of modifiers to modifiers, which include these.

Maybe they can suggest an alternative?
 

Veracity

Developer
Staff member
Not that I can see the original post, but I see that Darzil is referring this to heeheehee to comment on, so I'm bumping it to the first page.
 

heeheehee

Developer
Staff member
Ah, I must have missed this. Thanks for the bump, Veracity.

I'll think about it some more over the next day or so.
 

heeheehee

Developer
Staff member
forceEval is not necessary... I've just reverted that optimization entirely, since it's clearly breaking those modifiers, and I don't think there's a feasible workaround, especially for Mummery (since changing familiar will change that value).
 

heeheehee

Developer
Staff member
Actually, upon some further investigation, it looks like modifierIndicesByName just isn't working correctly. Needs some more evaluation.

Either way, I'll be experimenting further before re-submitting that change, if at all.
 

heeheehee

Developer
Staff member
Yeah. r19394 puts that optimization back in place; I've confirmed that "modtrace Meat Drop" contains Mummery as a line.
 

Veracity

Developer
Staff member
Thanks for finding this. I assume it was my fault, since I created Modifiers.resetModifiers to allow re-loading modifiers.txt when you leave TCRS. I made that method clear out all the maps and sets which were loaded from that file - and must have cleared that one, too, without understanding what it was. Turns out I missed another thing which needed to be reset: the bitmap masks. Revision 19396 fixes that one.
 

Malibu Stacey

Active member
Confirming mumming trunk modifiers and voting booth daily modifiers both show up again in stats (and modtrace) as of r19396.

Thanks.
 

heeheehee

Developer
Staff member

You misinterpreted the change that I made. The change was to avoid executing parseModifiers(), and instead rely on a HashMap to go from modifier name to modifier index, rather than serializing the ModifierList, then immediately deserializing it.

Veracity's referring to r19256, wherein she added the resetModifiers() block which inadvertently cleared the HashMap I'd been using to make that association (as that was the underlying issue).
 
Top