Results 1 to 4 of 4

Thread: [Patch] Track inflation of brainwave-controlled unicorn horn

  1. #1
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Post [Patch] Track inflation of brainwave-controlled unicorn horn

    This patch adds a property, "unicornHornInflation", for tracking the inflation of the brainwave-controlled unicorn horn. This value ranges from 0 to 100, and is incremented by winning combats. It resets upon ascension, and when a currently-unimplemented skill (Uni-Gore) is used. I have not included support for the skill, but I have added the ability to parse the inflation value from the item description and after-battle messages.
    Unicorn Horn.patch
    Last edited by Saklad5; 07-08-2019 at 08:15 PM. Reason: Updated patch to work on newer revision

  2. #2
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,859

    Default

    Bumping another patch...

  3. #3
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,384

    Default

    r19390

    Two comments. Unless I personally care about a patch I won't review it unless there is obvious interest or I am explicitly asked to do so. A bump from veracity is an expression of interest.

    Second, I have had problems applying saklad5's patches. I'm not sure why but it may be the starting directory when the patch is created. I prefer to create and apply patches at the highest level.

  4. #4
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,859

    Default

    Two comments. Unless I personally care about a patch I won't review it unless there is obvious interest or I am explicitly asked to do so. A bump from veracity is an expression of interest.
    Originally Posted by fronobulax View Post
    Well, thank you. I agree with the "is this personally interesting" criterion, but, we end up with lots of things slipping through because NOBODY is "personally interested". I think I spent a LOT of time on TCRS and (potentially) now on the Beach Comb, so, random other stuff is overwhelming, and I thank you for stepping up.

    Second, I have had problems applying saklad5's patches. I'm not sure why but it may be the starting directory when the patch is created. I prefer to create and apply patches at the highest level.
    Me too. I am at "/source/KoLmafia" - which is the "root of all KoLmafia files", but Saklad5 initiates them from "src". What about "lib"? What about "data"? We have other things we submit to the repository which are NOT under the "src" directory.

    "patch" tells me the issue, I copy/paste the correct head, and it continues, but, it is extra work.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •