Page 2 of 2 FirstFirst 1 2
Results 11 to 18 of 18

Thread: [Patch] Implement PirateRealm-only modifiers

  1. #11
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Default

    OK, my patch is written, I just need to test it. It compiled successfully, at least.

  2. #12
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Default

    OK, itís going into an infinite loop. It looks like the parent zone of a top-level zone is itself? Iím probably just misunderstanding the output of
    Code:
    AdventureDatabase.PARENT_ZONES.get( currentZone );
    For now, Iím going to assume thatís intended behavior and adjust the loop accordingly.

  3. #13
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Default

    A lot of modifiers appear to be incorrect, actually. They’re using “zone” instead of “location”, which is breaking now.
    Code:
    Item    slime-covered shovel    Weapon Damage: [100*zone(The Slime Tube)+60], Initiative: -10
    This shouldn’t be difficult to fix as part of the patch, though. Whoever made KoLmafia capable of surviving NullPointerExceptions, thank you.
    Last edited by Saklad5; 06-24-2019 at 07:18 PM.

  4. #14
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Default

    OK, itís going into an infinite loop. It looks like the parent zone of a top-level zone is itself? Iím probably just misunderstanding the output of
    Code:
    AdventureDatabase.PARENT_ZONES.get( currentZone );
    For now, Iím going to assume thatís intended behavior and adjust the loop accordingly.
    Originally Posted by Saklad5 View Post
    It seems like this isnít always true. For now, Iím going to check for both the parent being null and the parent being the child.

  5. #15
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Default

    It turns out this is somewhat difficult to test during a TCRS run. If anyone wants to test the patch now and see if it fixes the issue, be my guest.
    Recursive Zones.patch
    Just to be clear, I have not been able to check if this resolves the issue. Donít merge it without testing it yourself. When Iím finished with my current run, I can see if it works myself.

  6. #16
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,384

    Default

    It turns out this is somewhat difficult to test during a TCRS run. If anyone wants to test the patch now and see if it fixes the issue, be my guest.
    Recursive Zones.patch
    Just to be clear, I have not been able to check if this resolves the issue. Don’t merge it without testing it yourself. When I’m finished with my current run, I can see if it works myself.
    Originally Posted by Saklad5 View Post
    Since I am tracking this, does r19341 mean the patch has been checked and verified? I'm going to assume Yes but this is an opportunity for someone to tell me I am wrong :-)
    Well, thank you.
    Originally Posted by Veracity View Post

  7. #17
    Senior Member
    Join Date
    Apr 2018
    Posts
    301

    Default

    Since I am tracking this, does r19341 mean the patch has been checked and verified? I'm going to assume Yes but this is an opportunity for someone to tell me I am wrong :-)
    Originally Posted by fronobulax View Post
    I messaged Veracity that it was working, yes. This thread was technically about a different issue, so it was a bit off-topic in the first place.

  8. #18
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,384

    Default

    I messaged Veracity that it was working, yes. This thread was technically about a different issue, so it was a bit off-topic in the first place.
    Originally Posted by Saklad5 View Post
    I got the off topic :-) At a real high level, I committed something, it did not work as expected and my sense of professionalism requires me to revert it or confirm that something else changed so that it did work as expected. I just wanted to make sure I could cross revert r19336 off of my list of things I might have to do.
    Well, thank you.
    Originally Posted by Veracity View Post

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •