Thanks! Revision 19281
I'm being cautious about the new spoon. The first IOTM after a new path rolls out tends to be something special for that path.
So, is what's "special" aboit the spoon that it has 11 modifiers? Are they hand-picked to be appropriate to the class/sign?
Or, perhaps, do they differ per player, a la the ring?
Since it came out yesterday, it is too early to tell. So, for now, I am not saving the TCRS mods for it in the data files. For now, I'll treat it like we (soon will) treat the ring - load the modifiers from the description at run time, in case it does vary per player.
It'll all work with the (soon to come) "tcrs update", which is needed for new items which are not in the published data files - all 20 something of them.
We'll know soon enough how this item works.
Regarding "the spoon"...When I got the spoon I was in a Sauceror - Marmot run and the modifiers were set. I then went into aftercore and I'd swear that the modifiers changed, I then ascended into a Sauceror - Mongoose run and got, I'm pretty sure, another set of modifiers.
Sadly the modifiers do not appear in the session log nor, it seems, does the output of "tcrs spoon".
I didn't think to copy them out of the gCLI.
I am sure that the modifiers changed in aftercore; if you are not in a TCRS run, you get a fancy set of standard modifiers.
I'll add the output of tcrs spoon to the session log.
In the mean time, revision 19283 adds "tcrs update" - which is done automatically when you log in to (or ascend into) a TCRS run.
After loading the TCRS modifiers, it will look at all known items and derive modifiers for items added since the data file was created. It will then save the (updated) modifiers in your data directory. This future proofs us against the inevitable new items KoL adds after we have published TCRS data files; we won't HAVE to keep publishing updated data files.
Revision 19284 prints the output of "tcrs spoon" to the session log.
It also loads the modifiers for "ring" and "hewn moon-rune spoon" when you reset the TCRS modifiers (by freeing the king or simply logging in) or log in (or ascend into) a TCRS run. That might be all the support we need for "ring". And it may be overkill if the hewn moon-rune spoon is the same for everybody for a particular class/sign TCRS run. If so, I'll eventually remove the unnecessary code.
I expected 3 * 3 ('good') + 5 ('Saucemaven') + 1 ('Special Seasoning') = 15 adventures.
So, Saucemaven works as expected in TCRS.Code:Eating 1 fettucini Inconnu... You gain 15 Adventures You gain 37 Beefiness You gain 10 Wizardliness You gain 9 Smarm You ate Special Seasoning with your food Finished eating 1 fettucini Inconnu
Also, revision 19285 improves what we show in the Usables (Food/Booze/Spleen) panels for consumables that grant an effect:
Unspaded 50 EFFECTNAME (EFFECT MODIFIERS)
(Since the adv/mus/mys/mox are still unspaded.)
Makes we wish we had a "Potions" panel which would list all the potions you have in inventory and what effect they grant.
Ph'nglui mglw'nafh Cthulhu
R'lyeh wgah-nagl fhtagn.
So, if I reincarnate into a class for which files don't exist (e.g. Disco Bandit Opossum), the Java GUI pops up a dialog box asking if I want to generate the files for the class/Path.
Except, I reincarnated in the relay browser and so the request is behind a browser window. It took me a moment to figure out that KoLMafia was waiting for user input in the background.
I can't think of an obvious fix for that, but hopefully someone else can!
The hidden window problem is noted but I personally am going to do nothing about it. First, once we have a complete set of files the problem is unlikely to occur. So it is something that can be fixed by just waiting a few days or weeks for the files to be generated and checked in. Second, the problem of windows popping up where they are not noticed exists elsewhere in KoLmafia and has been around for a while. In general it is an extremely difficult problem to solve and again, I have other things I would rather do with my time than beat my head against this wall yet another time. As a user I am resigned to the fact that sometimes I just have to go hunting for a window when things seem to be not running.